From: Fabio Estevam <festevam@gmail.com>
To: Frank.Li@nxp.com
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
Fabio Estevam <festevam@gmail.com>
Subject: [PATCH v2] ARM: dts: imx27-eukrea: Remove invalid spi-cpol
Date: Fri, 16 Oct 2026 17:48:17 -0300 [thread overview]
Message-ID: <20261016204817.463567-1-festevam@gmail.com> (raw)
The ADS7846 timing diagrams show DCLK low when inactive, and its pin
descriptions specify that DIN is latched on the rising edge of DCLK
while DOUT is shifted on the falling edge. This corresponds to SPI mode
0, with CPOL=0 and CPHA=0.
The spi-cpol property without spi-cpha instead selects SPI mode 2,
which uses the opposite clock edges and does not match the ADS7846
serial interface. Remove the invalid property.
This also matches the driver behavior: ads7846_probe() clears
SPI_MODE_X_MASK and selects SPI_MODE_0 before calling spi_setup().
This fixes the following dtbs_check warning:
imx27-eukrea-mbimxsd27-baseboard.dtb: ads7846@0 (ti,ads7846):
Unevaluated properties are not allowed (spi-cpol was unexpected)
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v1:
- Remove spi-cpol from the dts instead of adding it to the binding. (Sashiko)
arch/arm/boot/dts/nxp/imx/imx27-eukrea-mbimxsd27-baseboard.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/nxp/imx/imx27-eukrea-mbimxsd27-baseboard.dts b/arch/arm/boot/dts/nxp/imx/imx27-eukrea-mbimxsd27-baseboard.dts
index 26833ed3339e..cf5603ec6826 100644
--- a/arch/arm/boot/dts/nxp/imx/imx27-eukrea-mbimxsd27-baseboard.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx27-eukrea-mbimxsd27-baseboard.dts
@@ -77,7 +77,6 @@ ads7846@0 {
pinctrl-0 = <&pinctrl_touch>;
reg = <0>;
interrupts-extended = <&gpio4 25 IRQ_TYPE_LEVEL_LOW>;
- spi-cpol;
spi-max-frequency = <1500000>;
ti,keep-vref-on;
};
--
2.43.0
reply other threads:[~2026-10-16 20:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261016204817.463567-1-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.