All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	James Clark <james.clark@linaro.org>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Clark Williams <williams@redhat.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Sashiko <sashiko-bot@kernel.org>,
	stable@vger.kernel.org
Subject: [PATCH v4 02/21] perf python: Free the parse error entries when parsing fails
Date: Fri, 16 Oct 2026 18:20:43 -0300	[thread overview]
Message-ID: <20261016212102.76550-3-acme@kernel.org> (raw)
In-Reply-To: <20261016212102.76550-1-acme@kernel.org>

From: Arnaldo Carvalho de Melo <acme@redhat.com>

pyrf__parse_events() prints the entries parse_events_error__print()
receives with the details of a failed parse, but returns without freeing
them, leaking whatever parse_events_error__handle() allocated, so call
parse_events_error__exit() on both paths, as the other parse_events()
callers do.

The perf test attr core PMU probe takes this failure path on machines
without a core PMU, where the leak then happens on every test run.

Fixes: f081defccd93 ("perf python: Add parse_events function")
Reported-by: Sashiko <sashiko-bot@kernel.org>
Closes: https://lore.kernel.org/r/sashiko-outbox-173525@kernel.org
Cc: stable@vger.kernel.org
Assisted-by: LLM
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/python.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c
index 4eb17bdc5fd1231a..60dbe2dad5eb8073 100644
--- a/tools/perf/util/python.c
+++ b/tools/perf/util/python.c
@@ -3824,10 +3824,12 @@ static PyObject *pyrf__parse_events(PyObject *self, PyObject *args)
 	perf_evlist__set_maps(evlist__core(evlist), cpus, threads);
 	if (parse_events(evlist, input, &err)) {
 		parse_events_error__print(&err, input);
+		parse_events_error__exit(&err);
 		PyErr_SetFromErrno(PyExc_OSError);
 		evlist__put(evlist);
 		return NULL;
 	}
+	parse_events_error__exit(&err);
 	result = pyrf_evlist__from_evlist(evlist);
 	evlist__put(evlist);
 	return result;
-- 
2.55.0


  parent reply	other threads:[~2026-10-16 21:21 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 21:20 [PATCH v4 00/21] perf test attr: Report the failures again and cope with more than one core PMU Arnaldo Carvalho de Melo
2026-10-16 21:20 ` [PATCH v4 01/21] perf test attr: Fix record dwarf sample_type expectation Arnaldo Carvalho de Melo
2026-10-16 21:23   ` sashiko-bot
2026-10-16 21:20 ` Arnaldo Carvalho de Melo [this message]
2026-10-16 21:23   ` [PATCH v4 02/21] perf python: Free the parse error entries when parsing fails sashiko-bot
2026-10-16 21:20 ` [PATCH v4 03/21] perf test attr: Allow tests to require a core PMU Arnaldo Carvalho de Melo
2026-10-16 21:24   ` sashiko-bot
2026-10-16 21:20 ` [PATCH v4 04/21] perf test attr: Fix legacy event encodings in group tests Arnaldo Carvalho de Melo
2026-10-16 21:25   ` sashiko-bot
2026-10-16 21:20 ` [PATCH v4 05/21] perf test attr: Fix default stat metrics expectations Arnaldo Carvalho de Melo
2026-10-16 21:43   ` sashiko-bot
2026-10-16 21:20 ` [PATCH v4 06/21] perf test attr: Relax group checking for ungrouped expectations Arnaldo Carvalho de Melo
2026-10-16 21:24   ` sashiko-bot
2026-10-16 21:20 ` [PATCH v4 07/21] perf evsel: Mark the event as supported when retrying an open Arnaldo Carvalho de Melo
2026-10-16 21:25   ` sashiko-bot
2026-10-16 21:20 ` [PATCH v4 08/21] perf test attr: Ignore the core PMU type perf puts in 'config' Arnaldo Carvalho de Melo
2026-10-16 21:25   ` sashiko-bot
2026-10-16 21:20 ` [PATCH v4 09/21] perf evsel: Don't dump probe events to PERF_TEST_ATTR Arnaldo Carvalho de Melo
2026-10-16 21:23   ` sashiko-bot
2026-10-16 21:20 ` [PATCH v4 10/21] perf evsel: Close the fds opened so far when disabling missing features Arnaldo Carvalho de Melo
2026-10-16 21:24   ` sashiko-bot
2026-10-16 21:20 ` [PATCH v4 11/21] perf test attr: Introduce mask_bits(), generalizing hide_core_pmu_type() Arnaldo Carvalho de Melo
2026-10-16 21:24   ` sashiko-bot
2026-10-16 21:20 ` [PATCH v4 12/21] perf test attr: Accept either sample id bit perf asks for Arnaldo Carvalho de Melo
2026-10-16 21:24   ` sashiko-bot
2026-10-16 21:20 ` [PATCH v4 13/21] perf test attr: Ignore the dummy tracking event and the terms it carries Arnaldo Carvalho de Melo
2026-10-16 21:25   ` sashiko-bot
2026-10-16 21:20 ` [PATCH v4 14/21] perf test attr: Leave out the events of the other core PMUs Arnaldo Carvalho de Melo
2026-10-16 21:26   ` sashiko-bot
2026-10-16 21:20 ` [PATCH v4 15/21] perf test attr: Ignore the group read_format bit the PMU count can remove Arnaldo Carvalho de Melo
2026-10-16 21:24   ` sashiko-bot
2026-10-16 21:20 ` [PATCH v4 16/21] perf test attr: State, spelled out in a line, why a test is skipped Arnaldo Carvalho de Melo
2026-10-16 21:24   ` sashiko-bot
2026-10-16 21:20 ` [PATCH v4 17/21] perf tests: Introduce a 'needs_mlock' suite flag Arnaldo Carvalho de Melo
2026-10-16 21:27   ` sashiko-bot
2026-10-16 21:20 ` [PATCH v4 18/21] perf tests: Mark the C tests mapping perf ring buffers Arnaldo Carvalho de Melo
2026-10-16 21:24   ` sashiko-bot
2026-10-16 21:21 ` [PATCH v4 19/21] perf tests: Mark the shell tests not " Arnaldo Carvalho de Melo
2026-10-16 21:26   ` sashiko-bot
2026-10-16 21:21 ` [PATCH v4 20/21] perf mutex: Add a robust, process-shared mutex initializer Arnaldo Carvalho de Melo
2026-10-16 21:25   ` sashiko-bot
2026-10-16 21:21 ` [PATCH v4 21/21] perf test: Take turns using the perf mlock budget in the mmaping tests Arnaldo Carvalho de Melo
2026-10-16 21:28   ` sashiko-bot
2026-10-16 22:39 ` [PATCH v4 00/21] perf test attr: Report the failures again and cope with more than one core PMU Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261016212102.76550-3-acme@kernel.org \
    --to=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=sashiko-bot@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.