From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Magnus Lindholm <linmag7@gmail.com>
Cc: pavan.chebbi@broadcom.com, andrew+netdev@lunn.ch,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3] tg3: normalize inherited BCM5718 register byte order
Date: Fri, 16 Oct 2026 23:38:52 +0200 [thread overview]
Message-ID: <20261016213852.o_aG9SgB@linutronix.de> (raw)
In-Reply-To: <20261011194228.981141-1-linmag7@gmail.com>
On 2026-10-11 21:41:58 [+0200], Magnus Lindholm wrote:
> Firmware can leave BCM5718 vendor registers byte-swapped while standard
> PCI fields retain normal byte order. Detect this from the host-control
> revision marker, byte-swap bit and swapped product ID, without matching
> a platform model or PCI subsystem. Prefer the normal revision marker
> so already-normal controllers do not enter the normalization path.
…
>
> Limit detection to BCM5718, whose register layout and inherited state
> were checked on M3000 hardware. Other controller families retain their
> existing initialization path.
This boils down to firmware sets BYTE_SWAP and we need get it out in
order to have the device working and break anything while at it.
I have here DEVICE_TIGON3_5720 on x86. I forced that byte in, had the
register swapped and then it fixed it back.
> Signed-off-by: Magnus Lindholm <linmag7@gmail.com>
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Sebastian
next prev parent reply other threads:[~2026-10-16 21:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-11 19:41 [PATCH net-next v3] tg3: normalize inherited BCM5718 register byte order Magnus Lindholm
2026-10-16 21:38 ` Sebastian Andrzej Siewior [this message]
2026-10-17 0:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261016213852.o_aG9SgB@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=andrew+netdev@lunn.ch \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linmag7@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.