All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: Titouan Christophe <titouan.christophe@mind.be>
Cc: ps.report@gmx.net, yann.morin@orange.com,
	thomas.petazzoni@bootlin.com, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 5/7] package/openssl: move libopenssl/libressl options out of the choice
Date: Sat, 17 Oct 2026 00:51:00 +0200	[thread overview]
Message-ID: <20261016225100.GG331129@pevik> (raw)
In-Reply-To: <20261010151121.876133-6-titouan.christophe@mind.be>

Hi Titouan,

> The libopenssl and libressl sub-options are currently defined from
> package/{libopenssl,libressl}/Config.in, which are sourced from within
> the "ssl library" choice block, each wrapped in an "if" on its own
> choice entry.

> With the old kconfig, these entries were reparented below the choice
> member they depend on, and so were not considered choice members
> themselves. Since Linux commit 7e3465f63a0a [1], first released in v6.10,
> this is no longer the case: every config entry inside a choice block is
> a member of that choice. Combined with the stricter checks introduced by
> commits 700e7a8d05ea [2] and fde192511bdb [3], parsing now fails with:

>   package/libopenssl/Config.in:5: error: choice member must have a prompt
>   package/libopenssl/Config.in:15: error: choice member must have a prompt
>   package/libopenssl/Config.in:15: error: choice member must be bool

LGTM, but (as I noted earlier)  we need this fix earlier, so that 2nd, 3rd, 4th
commits aren't broken. Can you please do it?

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Kind regards,
Petr
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-10-16 22:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-10 15:11 [Buildroot] [PATCH 0/7] Update kconfig inrastructure to Linux 7.2.9 Titouan Christophe via buildroot
2026-10-10 15:11 ` [Buildroot] [PATCH 1/7] Makefile: always use a base config file for defconfig Titouan Christophe via buildroot
2026-10-16 21:30   ` Petr Vorel
2026-10-10 15:11 ` [Buildroot] [PATCH 2/7] */Config.in: use the new $(VAR) syntax Titouan Christophe via buildroot
2026-10-16 22:17   ` Petr Vorel
2026-10-10 15:11 ` [Buildroot] [PATCH 3/7] */Config.in: replace bool entries with prompt within all choices Titouan Christophe via buildroot
2026-10-16 22:25   ` Petr Vorel
2026-10-10 15:11 ` [Buildroot] [PATCH 5/7] package/openssl: move libopenssl/libressl options out of the choice Titouan Christophe via buildroot
2026-10-16 22:51   ` Petr Vorel [this message]
2026-10-10 15:11 ` [Buildroot] [PATCH 6/7] docs/manual: add migration notes for changes in the kconfig syntax Titouan Christophe via buildroot
2026-10-16 22:53   ` Petr Vorel
2026-10-10 15:11 ` [Buildroot] [PATCH 7/7] Makefile: add new target "yellowconfig" based on kconfiglib Titouan Christophe via buildroot
2026-10-16 21:44   ` Petr Vorel
2026-10-11 19:12 ` [Buildroot] [PATCH 0/7] Update kconfig inrastructure to Linux 7.2.9 Petr Vorel
2026-10-11 19:30   ` Titouan Christophe via buildroot
2026-10-16 21:29     ` Petr Vorel
     [not found] ` <20261010151121.876133-5-titouan.christophe@mind.be>
2026-10-16 22:47   ` [Buildroot] [PATCH 4/7] support/kconfig: update to kconfig from " Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261016225100.GG331129@pevik \
    --to=petr.vorel@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=ps.report@gmx.net \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=titouan.christophe@mind.be \
    --cc=yann.morin@orange.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.