From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Okhuomon Ajayi <okhuomonajayi54@gmail.com>,
outreachy@lists.linux.dev, Johan Hovold <johan@kernel.org>,
Alex Elder <elder@kernel.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: add blank lines after struct definitions in gbphy.h
Date: Fri, 16 Oct 2026 06:55:02 +0200 [thread overview]
Message-ID: <2026101653-repeal-deploy-2aa5@gregkh> (raw)
In-Reply-To: <fcdee571-d94c-a5ae-5ae5-b41977f22073@inria.fr>
On Thu, Oct 15, 2026 at 10:17:35PM -0400, Julia Lawall wrote:
>
>
> On Thu, 15 Oct 2026, Okhuomon Ajayi wrote:
>
> > Add blank lines between the structure definitions and the
> > to_gbphy_dev() and to_gbphy_driver() macros to improve
> > readability. This fixes the following checkpatch warning:
>
> Thanks for the patch. But I suspect that the lack of a newline was
> intentional, to show that the #define is closely associated with the
> previous structure declaration.
That is correct.
thanks,
greg k-h
prev parent reply other threads:[~2026-10-16 4:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 22:27 [PATCH] staging: greybus: add blank lines after struct definitions in gbphy.h Okhuomon Ajayi
2026-10-16 2:17 ` Julia Lawall
2026-10-16 4:55 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026101653-repeal-deploy-2aa5@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=elder@kernel.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=okhuomonajayi54@gmail.com \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.