From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f1.google.com (mail-pj2-f1.google.com [74.125.227.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0953391846 for ; Sat, 17 Oct 2026 11:12:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.129 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792235524; cv=none; b=D2sY2F/2cQlXMOQ+qwtvgSVj9ojkihW+ht+9Di0X/TCF6qRA+oFg+/XjToMgUKU5TTfO+IPmCcIxmpNNlWG1mFuNGDS1ghDkdNRKOiWnRl9KxEt9cvKWUtYCX+dcMcRGpqFxcVTCjKZXK1AwSOyFW2mWSJNrMnk5l5sq+X5zRuE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792235524; c=relaxed/simple; bh=uh9SS2WMqmUt4cpgp+wv9TrfsT1TAr44dlN+wtjyrDk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=u1xkk9fPjmbbnUVv1ymTU25VNZEZMCyUFE0qaLq5rEqE1DnC/dOD/GcFqdJk5//PnHS5t/1nHDrxr9MWCmgfmFRKYDezIlBwXMVNfkD2mE8RiangLQHeUPJhY/U7Jsft8T1UAtEOs526+uRzDOdO0hypVbaJ7j52or/qwWijq+A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RqKXqkfM; arc=none smtp.client-ip=74.125.227.129 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RqKXqkfM" Received: by mail-pj2-f1.google.com with SMTP id 98e67ed59e1d1-3ab37ea4798so242413a91.0 for ; Sat, 17 Oct 2026 04:12:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792235523; x=1792840323; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VkH44/WMax9Nf0vxizpHzIgEQxchbF7m2t+NOJIeX+U=; b=RqKXqkfMYuK9PqL/ckYuiIt9u/yhe2Ba/XfDmm6534ciUbcVjOsBjdOFDl7zV1Um+b rU4TpVAetDUl+IMJksQleLN008FVLZZ/GwRpAWaTitFfRPrkuZtoVZ0fObEECmbSgRGh VZvNEAOVzNYzN7qrIl19F2AJgyS+ihWX7cvwgk/Iwwp61ADyZDBEswwfDDvVoBXJiHLK +GRVI+GJ277QxRcNe36y9qK7drJF8O2NvkHplFwQ5+gRL3CaPa/G+mGTq4BwEvqtOBPN Ol3eGNUO/KSNnVzsIG4QHXODKxCzFfaYM4s61vcvjvHI7xSdIkcNhKVd3+9OObjhEpjr YiYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792235523; x=1792840323; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=VkH44/WMax9Nf0vxizpHzIgEQxchbF7m2t+NOJIeX+U=; b=ZwKv+VM1fCd2ioy3UFt2lbp+SQpBxvw1FQaFktOsiiAQE/58mg3M8QKz7D0K8VN1Qp ePjt9zRFZ0TwYjaFNmUSTRhkV98I0P+/4KiblKsH9EIuCULPv+VSvOiGOccac+EWPgKl fco01djHPkdS94sPfS1/hk8yj2WCIX/VDalP1/smFCvuJgHHN9D3jh3BjDAEzGPeU8Wk YDwJwe6B2sYZ2k1CQRuk9qSR5t8SMY/8rVfNTAuzrKjJfdukAsTjKCXZy/bog9CdmwaQ j+hFk184y1kLrq8upf2jGyjLdiGdOloFElfGIv98Luj21nhti66VtOk47hIjSUFaFs85 kapw== X-Gm-Message-State: AFq9FYIxta8K1SXolc2JBuhhHTUrG3WJOTxKRurpy1wePzcA29nMo232 6I5FZr6CMY3wn3QOTVM+GIYJ2eZ4FqUhbhgTcX4g4LaAvLJJdBAIT7e4UJ5ytBwSz1fcOZ+rkQ= = X-Gm-Gg: AYBFou3gsdhg2Zn+ZF4P/wppoecSuTZrnASeQBTUT90US3/DIua9LCEo0y9K7GtR02H TlqgF7mDlz7zWmcqbQZa2tp1D7nrrgCcUV0lnFj2Omn4DW0pxL8B7Sud3cHQnMfWXvOYCFzNk9V lZSa6foUPzTdF3uBSqcC7eAe6sUHjHcZ8gKgawSj7YXYJKUBVbXct6aYrtYsdMwqI/XEcJ0YVBC CKCKS/qopLIeyhQDiuZsszK1wEbup0hsQ5qhrfZ8EsAKZDFp8ZFYatQye1Tskd4pNW9sw/27xVw V7zsr0RBifjCEO8N2f8wuxiGhnMG+54BVEJTR096bNEWebUk5IniUXbkm6hHFEexb/VskVNK/jV hNasoV7dJ0Zjl8rR5Bfk9RKd1R/RCZizf+sO2Cea+bQMMkdw4Rb4NNEUwRcGr2ZHiCbAoaF218a 3E6EOQTFx18KY94RgttHJrOiavy47JW2Bg6RxwoGweZ2d8SW0jB0lW1NMaLKX0iFki2Xn2D5Ypz VN30V+Xa1lTm0mSQe6ome/WuDuc X-Received: by 2002:a17:90b:1f91:b0:3ac:38dc:6b9e with SMTP id 98e67ed59e1d1-3acef13e57fmr1849616a91.25.1792235523056; Sat, 17 Oct 2026 04:12:03 -0700 (PDT) Received: from WIN-2DEDQG69EF6.localdomain ([2a0c:9a40:9205:1:be24:11ff:fe93:ff0e]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3acd403c212sm2974687a91.4.2026.10.17.04.11.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2026 04:12:01 -0700 (PDT) From: chenhan To: rust-for-linux@vger.kernel.org Cc: a.hindborg@kernel.org, boqun@kernel.org, fujita.tomonori@gmail.com, frederic@kernel.org, lyude@redhat.com, tglx@kernel.org, anna-maria@linutronix.de, jstultz@google.com, sboyd@kernel.org, ojeda@kernel.org, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, aliceryhl@google.com, tmgross@umich.edu, dakr@kernel.org, daniel.almeida@collabora.com, tamird@kernel.org, acourbot@nvidia.com, work@onurozkan.dev, miguel.ojeda.sandonis@gmail.com, tomo@flapping.org, georgeandrout13@gmail.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v3 1/3] rust: time: rename the rem_nanos() divisor Date: Sat, 17 Oct 2026 19:11:32 +0800 Message-Id: <20261017111134.22546-2-chenhan0017.work@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20261017111134.22546-1-chenhan0017.work@gmail.com> References: <20261017111134.22546-1-chenhan0017.work@gmail.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The argument to rem_nanos() is the divisor, while self holds the dividend. Rename the argument and correct the documentation. Drop the architecture-specific implementation explanation from the public API documentation; the argument type already states the divisor's width. This does not change the function's type or behavior. It is a preparation for documenting and checking the invalid divisors in the next patch. Cc: stable@vger.kernel.org # prerequisite for the Delta division/remainder fix Assisted-by: LLM Signed-off-by: chenhan --- rust/kernel/time.rs | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/rust/kernel/time.rs b/rust/kernel/time.rs index 5ae377e70dd8..16b44e82d2ac 100644 --- a/rust/kernel/time.rs +++ b/rust/kernel/time.rs @@ -614,16 +614,13 @@ pub fn to_jiffies_timeout(self) -> Delta { Delta::::from_jiffies(jiffies) } - /// Return `self % dividend` where `dividend` is in nanoseconds. - /// - /// The kernel doesn't have any emulation for `s64 % s64` on 32 bit platforms, so this is - /// limited to 32 bit dividends. + /// Return `self % divisor` where `divisor` is in nanoseconds. #[inline] - pub fn rem_nanos(self, dividend: i32) -> Self { + pub fn rem_nanos(self, divisor: i32) -> Self { #[cfg(CONFIG_64BIT)] { Self { - value: self.as_nanos() % i64::from(dividend), + value: self.as_nanos() % i64::from(divisor), } } @@ -632,7 +629,7 @@ pub fn rem_nanos(self, dividend: i32) -> Self { let mut rem = 0; // SAFETY: `rem` is in the stack, so we can always provide a valid pointer to it. - unsafe { bindings::div_s64_rem(self.as_nanos(), dividend, &mut rem) }; + unsafe { bindings::div_s64_rem(self.as_nanos(), divisor, &mut rem) }; Self { value: i64::from(rem), -- 2.34.1