From: Sasha Levin <sashal@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: "Shuah Khan" <shuah@kernel.org>, "Will Deacon" <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
"Mark Brown" <broonie@kernel.org>,
"Ricardo B. Marlière" <rbm@suse.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] kselftest/arm64: keep building and installing after a subdirectory fails
Date: Sat, 17 Oct 2026 10:37:44 -0400 [thread overview]
Message-ID: <20261017143745.2601801-1-sashal@kernel.org> (raw)
In-Reply-To: <atERXTfz9xsIuv-7@arm.com>
On Thu, Oct 15, 2026 at 06:46:05PM +0100, Catalin Marinas wrote:
>Sashiko had a comment about breakage ARM64_SUBTARGETS is empty. I think
>it's a false positive but I didn't check.
It is a false positive. With ARM64_SUBTARGETS empty the loop expands to
"for DIR in ; do ... done", which POSIX allows: the word list after "in"
may be empty, so the body never runs. The $(if) sets ret to 0 for that
case, so the target succeeds.
I ran the patched Makefile with ARCH=x86_64 for all, install and
emit_tests under bash, dash and busybox sh, with and without
FORCE_TARGETS=1. Every combination exits 0 with no output.
--
Thanks,
Sasha
next prev parent reply other threads:[~2026-10-17 14:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 20:01 [PATCH 0/7] selftests: report per-suite build results without failing the build Sasha Levin
2026-10-14 20:01 ` Sasha Levin
2026-10-14 20:01 ` [PATCH 1/7] selftests: keep the build status from wrapping to success Sasha Levin
2026-10-15 18:00 ` Mark Brown
2026-10-15 19:21 ` Shuah Khan
2026-10-14 20:01 ` [PATCH 2/7] selftests: optionally record per-suite build and install results Sasha Levin
2026-10-15 19:22 ` Shuah Khan
2026-10-14 20:01 ` [PATCH 3/7] selftests/futex: report failures of the functional subdirectory Sasha Levin
2026-10-14 20:01 ` [PATCH 4/7] kselftest/arm64: keep building and installing after a subdirectory fails Sasha Levin
2026-10-15 17:46 ` Catalin Marinas
2026-10-17 14:37 ` Sasha Levin [this message]
2026-10-15 18:16 ` Mark Brown
2026-10-14 20:01 ` [PATCH 5/7] selftests/riscv: " Sasha Levin
2026-10-14 20:01 ` Sasha Levin
2026-10-14 20:01 ` [PATCH 6/7] selftests/powerpc: report the outcome of each subdirectory Sasha Levin
2026-10-14 20:01 ` [PATCH 7/7] selftests/sparc64: report failures of the drivers subdirectory Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261017143745.2601801-1-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rbm@suse.com \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.