From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B06467404E; Sat, 17 Oct 2026 16:33:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792254804; cv=none; b=gA+ySP8X+LPCjnrJTxryWkpd5YyfBgWFQv0zy7JgLQCeOx4n+q9lLhxriFkWqqHZRQ6oguf5L5PG61yaZYmjxnd3BGycu+2sTZAszbDZkf3oHYPrGIE6wqr71OuRpdIJm7kSWobpw6HxQvvl/NQOKVsqpFpD1CRLT0uJvx4u8FE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792254804; c=relaxed/simple; bh=WT6M0egs8iohk6q1W1B6KMIGlgGKzD0KrByRFBKFkc4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hDDTNozHHKWxDKbgNBuQHfCkzyMOM65k7BWPN2Nt1mWAnYloZfA8NmJYJNWcXBUuKqf/atQw50giFJCkVm1gKT64QdGdeiP2bqOuu1S7D0fOgy8r6mVOzF3ZbcEmM+dao8X1TWhlh9GLyufBcKHYZMQBMk2V1Z3jLvaump8ciuk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Qab7j8Me; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Qab7j8Me" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1ADD1F000C4; Sat, 17 Oct 2026 16:33:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1792254803; bh=JnNQYkNMtZvbb+ZnLCH3lap2p0iLu7tvsTq24qA9h7s=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Qab7j8Mes3acreob5PUqa+2TorUflo0w/aJNZcj1WTF9a0y0JRuQDKVzyxGgBXah+ rbB0EJpdjrRUVOYc3iz7vVW5XMy/igrm4uU8ZUfiR9/qN8YK7eeg+oeht16iE+DxOb PCVFdO1Nv60TJl/hQTNEBBS3QAd4bjNLpKmpvB/o= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jan Kara , "Christian Brauner (Amutable)" , Sasha Levin Subject: [PATCH 6.12 568/869] ext2: Fix lost inode updates for IS_SYNC inodes Date: Sat, 17 Oct 2026 17:56:49 +0200 Message-ID: <20261017160051.632860403@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261017160036.979869304@linuxfoundation.org> References: <20261017160036.979869304@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jan Kara [ Upstream commit 356984d1a5c32e94810cbb6c8dc7d8ff2d4d919a ] ext2_setsize() and ext2_xattr_set2() had a construct like: if (IS_SYNC(inode)) { sync_inode_metadata(inode, 1); } else { mark_inode_dirty(inode); } which leads to lost inode updates for IS_SYNC inodes because sync_inode_metadata() does anything only if the inode is already dirty and hence inode updates may be simply lost. Fix the problem by unconditionally marking the inode dirty and *then* call sync_inode_metadata(). CC: stable@vger.kernel.org Signed-off-by: Jan Kara Link: https://patch.msgid.link/20260727104923.3828017-26-jack@suse.cz Signed-off-by: Christian Brauner (Amutable) Signed-off-by: Sasha Levin --- fs/ext2/inode.c | 3 +-- fs/ext2/xattr.c | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index 3fcf8191da42a..f3149022257a4 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c @@ -1300,11 +1300,10 @@ static int ext2_setsize(struct inode *inode, loff_t newsize) filemap_invalidate_unlock(inode->i_mapping); inode_set_mtime_to_ts(inode, inode_set_ctime_current(inode)); + mark_inode_dirty(inode); if (inode_needs_sync(inode)) { sync_mapping_buffers(inode->i_mapping); sync_inode_metadata(inode, 1); - } else { - mark_inode_dirty(inode); } return 0; diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c index c885dcc3bd0d1..5574b601ae09c 100644 --- a/fs/ext2/xattr.c +++ b/fs/ext2/xattr.c @@ -777,6 +777,7 @@ ext2_xattr_set2(struct inode *inode, struct buffer_head *old_bh, /* Update the inode. */ EXT2_I(inode)->i_file_acl = new_bh ? new_bh->b_blocknr : 0; inode_set_ctime_current(inode); + mark_inode_dirty(inode); if (IS_SYNC(inode)) { error = sync_inode_metadata(inode, 1); /* In case sync failed due to ENOSPC the inode was actually @@ -789,8 +790,7 @@ ext2_xattr_set2(struct inode *inode, struct buffer_head *old_bh, } goto cleanup; } - } else - mark_inode_dirty(inode); + } error = 0; if (old_bh && old_bh != new_bh) { -- 2.53.0