From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56E1E3AFB1B; Sat, 17 Oct 2026 16:53:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792256030; cv=none; b=X1yNHUR0u/A4EbB7+3D42XCFMc2OC8Bmf+BzOWZ63mgZ/6vZElAwsLAXCPoK67M4X/paGAe5PvtVXLzVVdeHblnlV48xNlZyOyCDxaL0Kh+LPyme/KvpkpwIMPL/qfPFSEYQLsnMvZiZhV9wmxFzkZFLu37dgHeg7lp96tXqSGM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792256030; c=relaxed/simple; bh=/Z/kyMfCsegVDGul30lh/D0ASUCrj+yU6RKilD5CoiA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YDrejjkDYtW5lC4W3kcJryrcb8C0tvwi1uRf+iTUl3cc0j66eokpsU8fEVtIe7q96MVhK11HEE3WPhbhiIet5HWw5H11BrwdMvNgz70b3QFeF/3qQIyMEurVKjvikEPFXcubyLOklUB+viR6TvNgxi9v/dyhYWLN/SOBEdKLFEI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ui1OSKFB; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ui1OSKFB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7076E1F000C4; Sat, 17 Oct 2026 16:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1792256029; bh=Varfccin+bCmGMBHM8ooK6r06o1ARJ3Nl8TSUX2p8/4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ui1OSKFB8bpx18ZIOo+AOlubPj45A32D9jXAXGKHsYFWy2B/+8D1LW+ZDOjM+Peuv nUD056TAUrFz2XIpq0GVere2my7VpKB4JceJqVHnOF1DpuFGSfDTZDbebKFtgC2Yt3 a24vdjrHwbMlgw2+Y5xls5i0hUpQJGfd9CLj855k= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Thomas Zimmermann , Thierry Reding , Maxime Ripard , Javier Martinez Canillas , Sasha Levin Subject: [PATCH 6.6 0100/1674] drm/sysfb: simpledrm: Improve stride validation Date: Sat, 17 Oct 2026 17:39:32 +0200 Message-ID: <20261017160433.712021416@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261017160431.119607952@linuxfoundation.org> References: <20261017160431.119607952@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thomas Zimmermann [ Upstream commit df6533f11688aa30be3bb883c7637f4ffdbb7cbd ] Validate the computed stride against the maximum value INT_MAX. Signed-off-by: Thomas Zimmermann Reviewed-by: Thierry Reding Reviewed-by: Maxime Ripard Reviewed-by: Javier Martinez Canillas Fixes: 7bfa5c7b28d6 ("drm/simpledrm: Compute linestride with drm_format_info_min_pitch()") Cc: # v6.1+ Link: https://patch.msgid.link/20260625094509.157581-5-tzimmermann@suse.de Signed-off-by: Sasha Levin --- drivers/gpu/drm/tiny/simpledrm.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c index 2abe80eec793b..d10574e630a86 100644 --- a/drivers/gpu/drm/tiny/simpledrm.c +++ b/drivers/gpu/drm/tiny/simpledrm.c @@ -737,9 +737,15 @@ static struct simpledrm_device *simpledrm_device_create(struct drm_driver *drv, return ERR_PTR(-ENODEV); } if (!stride) { - stride = drm_format_info_min_pitch(format, 0, width); - if (drm_WARN_ON(dev, !stride)) + u64 pitch = drm_format_info_min_pitch(format, 0, width); + + if (drm_WARN_ON(dev, !pitch)) { + return ERR_PTR(-EINVAL); /* driver bug */ + } else if (pitch > INT_MAX) { + drm_warn(dev, "stride of %llu exceeds maximum\n", pitch); return ERR_PTR(-EINVAL); + } + stride = pitch; } /* -- 2.53.0