From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61D123AF66D; Sat, 17 Oct 2026 17:01:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792256512; cv=none; b=g7BhZTcrsAop/kKZBdezUizokLBiyyRwHcba3O/tFD1qmt3/MZU2iM5kCKF0NU2lGUIK9Fu4MChVZv8hDhwnS68rZRXYJf6GNa+JIA6LYCVWI72ntitE+XjyWwGqu1sxGnyS64ERZApdm6faP4EmlGjwyowTizMDvVEqO4y+04k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792256512; c=relaxed/simple; bh=p4n6zG5BxLWgziAtcqzq86f3lS/8ZSSIW3jrUyIxrHM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m0zJsvciih4yxxLy5sW/YYxSS+gPOtSUs6w6j/dYpsAJf0IxmIgXGKOiVWqM7I/sAmyOVdK4nqLlvmpLEqzIDOvlIoRtjZf2EpdNk6N+LfPIG4NQaBrsttZLBnZe/mFxqfJlYz34pepydIC5UF6zFwecFg4xSoCCGB0uhtvvcJg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=LKNATrQK; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="LKNATrQK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0AF71F000C4; Sat, 17 Oct 2026 17:01:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1792256511; bh=W2qrZJguynEyxZKWzE0PCPuo1lJoq37+zadJokJ3YKU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=LKNATrQKJE3ea43jviS+aTx4WY4YMqW7tHJ+hJjESsi87hJ4UWaxb1d57IQp9OObo 6Hjm/Z8efqyCv29XzfbnKNjiNErjFtByq+nYNDVPmuSfHWJeIZE0yiZHQjax1/OZt8 NC0xtO/r6Axa5Vdlp9sqdy69xukzh+Hdu0/swAz4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Ijae Kim , Myeonghun Pak , Alan Stern Subject: [PATCH 6.6 0261/1674] usb: ohci-da8xx: disable controller wakeup on cleanup Date: Sat, 17 Oct 2026 17:42:13 +0200 Message-ID: <20261017160437.825413986@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261017160431.119607952@linuxfoundation.org> References: <20261017160431.119607952@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Myeonghun Pak commit 901197dd4c7dcffbf97426487d4c047555c98554 upstream. The OHCI core marks controllers with RemoteWakeupConnected as wakeup-capable. Probe enables wakeup, but neither removal nor a later notifier registration failure disables it, leaving the wakeup source attached. Disable controller wakeup after removing the HCD on both paths. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: a6eeeb9f45b5 ("USB: Update USB default wakeup settings") Cc: stable Assisted-by: LLM Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak Acked-by: Alan Stern Link: https://patch.msgid.link/20260915012011.61874-2-mhun512@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/host/ohci-da8xx.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/usb/host/ohci-da8xx.c +++ b/drivers/usb/host/ohci-da8xx.c @@ -464,6 +464,7 @@ static int ohci_da8xx_probe(struct platf err_remove_hcd: usb_remove_hcd(hcd); + device_wakeup_disable(hcd->self.controller); err: usb_put_hcd(hcd); return error; @@ -474,6 +475,7 @@ static void ohci_da8xx_remove(struct pla struct usb_hcd *hcd = platform_get_drvdata(pdev); usb_remove_hcd(hcd); + device_wakeup_disable(hcd->self.controller); usb_put_hcd(hcd); }