All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Günther Noack" <gnoack3000@gmail.com>
To: Alejandro Colomar <alx@kernel.org>
Cc: linux-man@vger.kernel.org
Subject: Re: [PATCH 01/24] man/man7/unix.7: ERRORS: EINVAL: The address field is sun_family, not sun_type
Date: Sun, 18 Oct 2026 16:57:01 +0200	[thread overview]
Message-ID: <20261018.a9623e61b80a@gnoack.org> (raw)
In-Reply-To: <atSgok2UDdYB3f2P@debian>

Hello Alejandro!

On Sun, Oct 18, 2026 at 12:46:17PM +0200, Alejandro Colomar wrote:
> > Date: 2026-10-16 19:31:16+0200
> > From: Günther Noack <gnoack3000@gmail.com>
> >
> > struct sockaddr_un has no sun_type field; the address family is in
> > sun_family, as described in "Address format" above.  The check is done
> > by unix_validate_addr() in linux.git net/unix/af_unix.c.
> > 
> > Assisted-by: LLM
> > Signed-off-by: Günther Noack <gnoack3000@gmail.com>
> > ---
> 
> I'd like to understand the reason why the bogus documentation existed at
> all.  For that, a 'Fixes:' tag would be necessary.  It'd also be
> interesting to know whether .sun_type was a human hallucination, or it
> existed at some point.
> 
> In this specific case, it seems to be:
> 
> 	Fixes: 9d1fd1157306 (1999-06-15, 2022-12-19; "man-pages 1.24")

Thanks, added the "Fixes:" tag.


> > Notes:
> >     Fixes an obvious typo
> 
> Most likely; still worth having a Fixes:.  Since I don't see any
> occurences of sun_type in glibc's or Linux's source code, let's assume
> it is a typo.

I also don't think sun_type ever existed.  I've read a bunch of old
documentation on BSD sockets, some of it dating back to the 90s, as
part of wrapping my head around Landlock's networking features, and
I've only come across a "family" field.

The best references to this are sockaddr(3type) and
sockaddr_un(3type).  The first and only common field of each of these
structs is the "family" field, which always has a different prefix
depending on the socket's address family (sun_family, sin_family,
etc.).  struct sockaddr_un only has a sun_family and sun_path field.

Another indicator that "family" is right is that it also talks about
AF_UNIX as the proper value for the field.  This is the value that
sun_family needs to have for it to be recognized as an AF_UNIX
address.  The AF stands for "address family".

–Günther

  reply	other threads:[~2026-10-18 14:57 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 17:31 [PATCH 00/24] Documentation fixes in unix(7) Günther Noack
2026-10-16 17:31 ` [PATCH 01/24] man/man7/unix.7: ERRORS: EINVAL: The address field is sun_family, not sun_type Günther Noack
2026-10-18 10:46   ` Alejandro Colomar
2026-10-18 14:57     ` Günther Noack [this message]
2026-10-16 17:31 ` [PATCH 02/24] man/man7/unix.7: Socket options: SOL_SOCKET is a level, not a family Günther Noack
2026-10-18 10:49   ` Alejandro Colomar
2026-10-18 10:55     ` Alejandro Colomar
2026-10-16 17:31 ` [PATCH 03/24] man/man7/unix.7: SO_PASSCRED: ffix Günther Noack
2026-10-18 11:00   ` Alejandro Colomar
2026-10-16 17:31 ` [PATCH 04/24] man/man7/sock_diag.7: Fix member order of struct unix_diag_vfs Günther Noack
2026-10-18 11:07   ` Alejandro Colomar
2026-10-16 17:31 ` [PATCH 05/24] man/man7/sock_diag.7: udiag_wqueue: This is memory in use, not memory available Günther Noack
2026-10-18 11:13   ` Alejandro Colomar
2026-10-16 17:31 ` [PATCH 06/24] man/man7/unix.7: ERRORS: EPROTONOSUPPORT: Protocol 0 is also accepted Günther Noack
2026-10-18 11:19   ` Alejandro Colomar
2026-10-18 12:37     ` Günther Noack
2026-10-18 14:40       ` Günther Noack
2026-10-16 17:31 ` [PATCH 07/24] man/man7/unix.7: ERRORS: ETOOMANYREFS: Fix the conditions Günther Noack
2026-10-16 17:31 ` [PATCH 08/24] man/man7/socket.7: SO_PEEK_OFF: This option is no longer specific to unix(7) Günther Noack
2026-10-16 17:31 ` [PATCH 09/24] man/man7/unix.7: SO_PEERCRED: Also works for SOCK_SEQPACKET Günther Noack
2026-10-16 17:31 ` [PATCH 10/24] man/man7/unix.7: SIOCINQ: Document behavior " Günther Noack
2026-10-16 17:31 ` [PATCH 11/24] man/man7/sock_diag.7: udiag_states: Document TCP_CLOSE Günther Noack
2026-10-16 17:31 ` [PATCH 12/24] man/man7/sock_diag.7: UNIX_DIAG_NAME: The payload is not always a pathname Günther Noack
2026-10-16 17:31 ` [PATCH 13/24] man/man7/sock_diag.7: Document UDIAG_SHOW_UID Günther Noack
2026-10-16 17:31 ` [PATCH 14/24] man/man7/unix.7: Several items of the same type may be sent in one message Günther Noack
2026-10-16 17:31 ` [PATCH 15/24] man/man2/bind.2: ERRORS: EACCES: Write permission on the directory is required Günther Noack
2026-10-16 17:31 ` [PATCH 16/24] man/man7/unix.7: Autobind: Fix when it happens, and mention SO_PASSPIDFD Günther Noack
2026-10-16 17:31 ` [PATCH 17/24] man/man7/unix.7: SOCK_RAW is accepted as an alias for SOCK_DGRAM Günther Noack
2026-10-16 17:31 ` [PATCH 18/24] man/man7/unix.7: SCM_SECURITY: This is not specific to SELinux Günther Noack
2026-10-16 17:31 ` [PATCH 19/24] man/man7/unix.7: SO_PASSSEC: wfix Günther Noack
2026-10-16 17:31 ` [PATCH 20/24] man/man7/unix.7: ERRORS: Document EACCES, EAGAIN, EMSGSIZE, ENOSPC, and EPERM Günther Noack
2026-10-16 17:31 ` [PATCH 21/24] man/man7/unix.7: Abstract sockets are scoped to a network namespace Günther Noack
2026-10-16 17:31 ` [PATCH 22/24] man/man7/unix.7: Remove mentions of unsupported out-of-band messaging Günther Noack
2026-10-16 17:31 ` [PATCH 23/24] man/man7/unix.7: Document SO_PASSPIDFD, SO_PEERPIDFD, and SCM_PIDFD Günther Noack
2026-10-16 17:31 ` [PATCH 24/24] man/man7/unix.7: Document SO_PASSRIGHTS Günther Noack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261018.a9623e61b80a@gnoack.org \
    --to=gnoack3000@gmail.com \
    --cc=alx@kernel.org \
    --cc=linux-man@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.