From: Hung-Chun Tseng <alan.tseng.cs@gmail.com>
To: Kuan-Wei Chiu <visitorckw@gmail.com>
Cc: u-boot@lists.u-boot-project.org, bmeng.cn@gmail.com,
trini@konsulko.com, sjg@chromium.org, xypron.glpk@gmx.de
Subject: Re: [PATCH v3 1/5] virtio: rtc: Add virtio RTC driver
Date: Sun, 18 Oct 2026 09:05:21 +0800 [thread overview]
Message-ID: <20261018010522.1324982-2-alan.tseng.cs@gmail.com> (raw)
In-Reply-To: <atPI5SKH7ZaiytQ3@google.com>
On Sun, Oct 18, 2026 at 03:13:41AM +0800, Kuan-Wei Chiu wrote:
> This is a bit subjective, but my feeling is that this has become
> somewhat too verbose. Ideally, a commit message should explain the
> "why" rather than just stating what was done. What was done can
> basically be seen directly from the code changes themselves.
Agreed. I'll cut it down to the reasons: why the clock lookup happens on
first read, why a smeared clock is preferred with a fallback, and why
the "no UTC clock" result is remembered.
next prev parent reply other threads:[~2026-10-18 1:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-17 18:46 [PATCH v3 0/5] virtio: Add a virtio RTC driver Hung-Chun Tseng
2026-10-17 18:46 ` [PATCH v3 1/5] virtio: rtc: Add " Hung-Chun Tseng
2026-10-17 19:06 ` Kuan-Wei Chiu
2026-10-18 1:05 ` Hung-Chun Tseng
2026-10-17 19:13 ` Kuan-Wei Chiu
2026-10-17 19:32 ` Kuan-Wei Chiu
2026-10-18 1:05 ` Hung-Chun Tseng
2026-10-18 1:05 ` Hung-Chun Tseng [this message]
2026-10-19 13:25 ` Simon Glass
2026-10-17 18:46 ` [PATCH v3 2/5] doc: virtio: List the supported device types Hung-Chun Tseng
2026-10-17 18:46 ` [PATCH v3 3/5] MAINTAINERS: Add entry for virtio RTC Hung-Chun Tseng
2026-10-17 18:46 ` [PATCH v3 4/5] virtio: sandbox: Let tests emulate the device side of a virtqueue Hung-Chun Tseng
2026-10-19 13:25 ` Simon Glass
2026-10-17 18:46 ` [PATCH v3 5/5] test: dm: Add tests for the virtio RTC driver Hung-Chun Tseng
2026-10-19 13:26 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261018010522.1324982-2-alan.tseng.cs@gmail.com \
--to=alan.tseng.cs@gmail.com \
--cc=bmeng.cn@gmail.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.u-boot-project.org \
--cc=visitorckw@gmail.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.