All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Alessandro Santos Hugen <phugen@redhat.com>
To: selinux@vger.kernel.org
Subject: [PATCH] tests: fix format string mismatches on s390x/ppc64le
Date: Sat, 17 Oct 2026 22:29:09 -0300	[thread overview]
Message-ID: <20261018012909.1795176-1-phugen@redhat.com> (raw)

Cast printf arguments to match format specifiers across
filesystem/statfs_test.c, binder/{binder_common,client,manager,
service_provider}.c, and perf_event/perf_event.c. Types like
__fsword_t, binder_uintptr_t, binder_size_t and __s64 differ
in width across architectures, triggering -Wformat under -Werror.

Fixes: cb49040 ("tests: fail on compiler warnings and enable Wextra")
Signed-off-by: Pablo Alessandro Santos Hugen <phugen@redhat.com>
---
 tests/binder/binder_common.c    | 10 +++++-----
 tests/binder/client.c           |  4 ++--
 tests/binder/manager.c          |  2 +-
 tests/binder/service_provider.c |  4 ++--
 tests/filesystem/statfs_test.c  |  2 +-
 tests/perf_event/perf_event.c   |  4 ++--
 6 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/tests/binder/binder_common.c b/tests/binder/binder_common.c
index 7cf6c74..6f7e5b3 100644
--- a/tests/binder/binder_common.c
+++ b/tests/binder/binder_common.c
@@ -65,7 +65,7 @@ void print_trans_data(const struct binder_transaction_data *txn_in)
 	size_t count = txn_in->offsets_size / sizeof(binder_size_t);
 
 	printf("\thandle: %d\n", (uint32_t)txn_in->target.handle);
-	printf("\tcookie: %lld\n", txn_in->cookie);
+	printf("\tcookie: %lld\n", (long long)txn_in->cookie);
 	switch (txn_in->code) {
 	case TEST_SERVICE_ADD:
 		printf("\tcode: TEST_SERVICE_ADD\n");
@@ -101,8 +101,8 @@ void print_trans_data(const struct binder_transaction_data *txn_in)
 	}
 	printf("\tsender pid: %u\n", txn_in->sender_pid);
 	printf("\tsender euid: %u\n", txn_in->sender_euid);
-	printf("\tdata_size: %llu\n", txn_in->data_size);
-	printf("\toffsets_size: %llu\n", txn_in->offsets_size);
+	printf("\tdata_size: %llu\n", (unsigned long long)txn_in->data_size);
+	printf("\toffsets_size: %llu\n", (unsigned long long)txn_in->offsets_size);
 
 	while (count--) {
 		obj = (const struct flat_binder_object *)
@@ -111,7 +111,7 @@ void print_trans_data(const struct binder_transaction_data *txn_in)
 		switch (obj->hdr.type) {
 		case BINDER_TYPE_BINDER:
 			printf("\thdr: BINDER_TYPE_BINDER\n");
-			printf("\tbinder: %llx\n", obj->binder);
+			printf("\tbinder: %llx\n", (unsigned long long)obj->binder);
 			break;
 		case BINDER_TYPE_HANDLE:
 			printf("\thdr: BINDER_TYPE_HANDLE\n");
@@ -135,7 +135,7 @@ void print_trans_data(const struct binder_transaction_data *txn_in)
 		       obj->flags & FLAT_BINDER_FLAG_PRIORITY_MASK,
 		       obj->flags & FLAT_BINDER_FLAG_ACCEPTS_FDS ? "YES" : "NO");
 #endif
-		printf("\tcookie: %llx\n", obj->cookie);
+		printf("\tcookie: %llx\n", (unsigned long long)obj->cookie);
 	}
 	fflush(stdout);
 }
diff --git a/tests/binder/client.c b/tests/binder/client.c
index 220d37a..a35fd7b 100644
--- a/tests/binder/client.c
+++ b/tests/binder/client.c
@@ -111,7 +111,7 @@ static void extract_fd_and_respond(const struct binder_transaction_data *txn_in)
 
 	if (verbose)
 		printf("Client read_consumed: %lld\n",
-		       bwr.read_consumed);
+		       (long long)bwr.read_consumed);
 
 	cmd = binder_parse(obj->fd, (binder_uintptr_t)readbuf,
 			   bwr.read_consumed);
@@ -435,7 +435,7 @@ int main(int argc, char **argv)
 
 		if (verbose)
 			printf("Client read_consumed: %lld\n",
-			       bwr.read_consumed);
+			       (long long)bwr.read_consumed);
 
 		cmd = binder_parse(fd, (binder_uintptr_t)readbuf,
 				   bwr.read_consumed);
diff --git a/tests/binder/manager.c b/tests/binder/manager.c
index f7f1723..14e3e0c 100644
--- a/tests/binder/manager.c
+++ b/tests/binder/manager.c
@@ -349,7 +349,7 @@ int main(int argc, char **argv)
 
 		if (verbose)
 			printf("Manager read_consumed: %lld\n",
-			       bwr.read_consumed);
+			       (long long)bwr.read_consumed);
 
 		binder_parse(fd, (binder_uintptr_t)readbuf, bwr.read_consumed);
 	}
diff --git a/tests/binder/service_provider.c b/tests/binder/service_provider.c
index 1e6b490..40734a2 100644
--- a/tests/binder/service_provider.c
+++ b/tests/binder/service_provider.c
@@ -384,7 +384,7 @@ int main(int argc, char **argv)
 
 	if (verbose)
 		printf("Service Provider read_consumed: %lld\n",
-		       bwr.read_consumed);
+		       (long long)bwr.read_consumed);
 
 	cmd = binder_parse(fd, (binder_uintptr_t)readbuf,
 			   bwr.read_consumed);
@@ -455,7 +455,7 @@ int main(int argc, char **argv)
 
 		if (verbose)
 			printf("Service Provider read_consumed: %lld\n",
-			       bwr.read_consumed);
+			       (long long)bwr.read_consumed);
 
 		cmd = binder_parse(fd, (binder_uintptr_t)readbuf, bwr.read_consumed);
 
diff --git a/tests/filesystem/statfs_test.c b/tests/filesystem/statfs_test.c
index 310b66d..4a318d2 100644
--- a/tests/filesystem/statfs_test.c
+++ b/tests/filesystem/statfs_test.c
@@ -59,7 +59,7 @@ int main(int argc, char *argv[])
 
 	if (verbose)
 		printf("statfs(2) returned magic filesystem: 0x%lx\n",
-		       statfs_t.f_type);
+		       (unsigned long)statfs_t.f_type);
 
 	return 0;
 }
diff --git a/tests/perf_event/perf_event.c b/tests/perf_event/perf_event.c
index 0e8bdce..b8d3dae 100644
--- a/tests/perf_event/perf_event.c
+++ b/tests/perf_event/perf_event.c
@@ -161,7 +161,7 @@ int main(int argc, char **argv)
 		if (verbose) {
 			pe_page = base;
 			printf("perf mmap(2) return value: %lld\n",
-			       pe_page->offset);
+			       (long long)pe_page->offset);
 		}
 
 		munmap(base, mmap_size);
@@ -178,7 +178,7 @@ int main(int argc, char **argv)
 		}
 
 		if (verbose)
-			printf("perf read(2) return value: %lld\n", count);
+			printf("perf read(2) return value: %lld\n", (long long)count);
 
 		close(fd);
 	}
-- 
2.56.0


             reply	other threads:[~2026-10-18  1:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-18  1:29 Pablo Alessandro Santos Hugen [this message]
2026-10-19 17:13 ` [PATCH] tests: fix format string mismatches on s390x/ppc64le Stephen Smalley
2026-10-20  8:57   ` Ondrej Mosnáček
2026-10-20 16:43     ` Pablo Hugen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261018012909.1795176-1-phugen@redhat.com \
    --to=phugen@redhat.com \
    --cc=selinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.