From: Al Viro <viro@zeniv.linux.org.uk>
To: Christian Brauner <brauner@kernel.org>
Cc: linux-fsdevel@vger.kernel.org,
"Paul E. McKenney" <paulmck@kernel.org>,
NeilBrown <neil@brown.name>, Alexander Larsson <alexl@redhat.com>,
Jan Kara <jack@suse.cz>, Jeff Layton <jlayton@kernel.org>,
lkmm@lists.linux.dev
Subject: Re: [PATCH 3/9] fs: drop the caller's umount(2) reference under mount_lock
Date: Sun, 18 Oct 2026 03:20:19 +0100 [thread overview]
Message-ID: <20261018022019.GB3535232@ZenIV> (raw)
In-Reply-To: <20261012-work-mount-gp_on_demand-proposal-v1-3-43f60221a7d0@kernel.org>
On Mon, Oct 12, 2026 at 05:39:16PM +0200, Christian Brauner wrote:
> +DEFINE_FREE(mntput_no_expire, struct mount *, if (_T) mntput_no_expire(_T))
You probably want to make it clear in commit message that this is _not_ the
decrement-under-lock referred to by the subject...
> static int do_umount(struct mount *mnt, int flags)
> {
> + struct mount *ref __free(mntput_no_expire) = mnt;
... since it's outside of guard(mount_writer()) scope, thankfully (it would
obviously break under mount_lock).
next prev parent reply other threads:[~2026-10-18 2:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 15:39 [PATCH 0/9] fs: unmount without a grace period when nothing else holds the mounts Christian Brauner
2026-10-12 15:39 ` [PATCH 1/9] ovl: free the ovl_fs after a grace period Christian Brauner
2026-10-12 15:39 ` [PATCH 2/9] fs: split the final put out of mntput_no_expire_slowpath() Christian Brauner
2026-10-12 15:39 ` [PATCH 3/9] fs: drop the caller's umount(2) reference under mount_lock Christian Brauner
2026-10-18 2:20 ` Al Viro [this message]
2026-10-12 15:39 ` [PATCH 4/9] fs: unmount without a grace period when nothing else holds the mounts Christian Brauner
2026-10-18 4:16 ` Al Viro
2026-10-12 15:39 ` [PATCH 5/9] fs: port kern_unmount{_array}() to mntput_unmounted() Christian Brauner
2026-10-12 15:39 ` [PATCH 6/9] selftests/filesystems: check that unheld mounts are gone after umount Christian Brauner
2026-10-12 15:39 ` [PATCH 7/9] Documentation/litmus-tests: add the mount reference count tests Christian Brauner
2026-10-12 15:39 ` [PATCH 8/9] ipc: free the namespace after a grace period Christian Brauner
2026-10-12 15:39 ` [PATCH 9/9] ipc: unmount the mqueue mount with kern_unmount() Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261018022019.GB3535232@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=alexl@redhat.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=lkmm@lists.linux.dev \
--cc=neil@brown.name \
--cc=paulmck@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.