From: Simon Horman <horms@kernel.org>
To: Jie Luo <jie.luo@oss.qualcomm.com>
Cc: netdev-bot+sashiko@kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, quic_leiwei@quicinc.com,
quic_suruchia@quicinc.com, quic_pavir@quicinc.com,
corbet@lwn.net, skhan@linuxfoundation.org, rdunlap@infradead.org,
netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, quic_kkumarcs@quicinc.com,
quic_linchen@quicinc.com
Subject: Re: [PATCH net-next v2 02/11] net: ethernet: qualcomm: ppe: Fix multicast queue config table access
Date: Sun, 18 Oct 2026 13:38:52 +0100 [thread overview]
Message-ID: <20261018123852.GA503057@horms.kernel.org> (raw)
In-Reply-To: <56401e91-6d8e-4489-ab34-ee25af031a74@oss.qualcomm.com>
On Wed, Oct 14, 2026 at 03:20:53PM +0800, Jie Luo wrote:
>
>
> On 10/12/2026 9:03 PM, netdev-bot+sashiko@kernel.org wrote:
> >> Fix it by converting the queue ID to the index of the multicast queue
> >> configuration table and accessing only the 3 words of the entry.
> >>
> >> Signed-off-by: Luo Jie <jie.luo@oss.qualcomm.com>
> > [Severity: Low]
> > Should this have a Fixes: tag? Commit 806268dc7efd added both the
> > multicast_queue_cfg[5] declaration and the absolute queue_id indexing:
> >
> > Fixes: 806268dc7efd ("net: ethernet: qualcomm: Initialize PPE queue management for IPQ9574")
> >
> > ipq9574_ppe_qm_queue_config[] covers multicast queues 256 to 299. That
> > means kernels which already have the IPQ9574 PPE QM code take the broken
> > else branch in ppe_config_qm() on every probe.
> >
> > Since this fixes code that is already merged, could it be sent on its
> > own to net with the Fixes: tag, rather than as part of the IPQ5424
> > series?
>
> The IPQ5424 QM configuration in this series depends on this fix. The
> issue is only theoretical: it was found by code inspection, and no
> user has reported it. So we would like to keep this patch in this series
> for net-next, without the Fixes: tag.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-10-18 12:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-11 13:02 [PATCH net-next v2 00/11] net: ethernet: qualcomm: ppe: Add support for IPQ5424 SoC Luo Jie
2026-10-11 13:02 ` [PATCH net-next v2 01/11] dt-bindings: net: qcom,ipq9574-ppe: Split EDMA reset into sys and apb Luo Jie
2026-10-11 13:02 ` [PATCH net-next v2 02/11] net: ethernet: qualcomm: ppe: Fix multicast queue config table access Luo Jie
2026-10-12 13:03 ` netdev-bot+sashiko
2026-10-14 7:20 ` Jie Luo
2026-10-18 12:38 ` Simon Horman [this message]
2026-10-11 13:02 ` [PATCH net-next v2 03/11] dt-bindings: net: qcom,ipq9574-ppe: Add IPQ5424 PPE support Luo Jie
2026-10-12 13:03 ` netdev-bot+sashiko
2026-10-14 7:43 ` Jie Luo
2026-10-11 13:02 ` [PATCH net-next v2 04/11] docs: networking: Document IPQ5424 as a supported SoC Luo Jie
2026-10-12 13:03 ` netdev-bot+sashiko
2026-10-18 12:39 ` Simon Horman
2026-10-11 13:02 ` [PATCH net-next v2 05/11] net: ethernet: qualcomm: ppe: Add platform support for IPQ5424 Luo Jie
2026-10-12 13:03 ` netdev-bot+sashiko
2026-10-18 12:39 ` Simon Horman
2026-10-11 13:02 ` [PATCH net-next v2 06/11] net: ethernet: qualcomm: ppe: Add IPQ5424 BM buffer configuration Luo Jie
2026-10-12 13:03 ` netdev-bot+sashiko
2026-10-18 12:40 ` Simon Horman
2026-10-11 13:02 ` [PATCH net-next v2 07/11] net: ethernet: qualcomm: ppe: Add IPQ5424 QM configuration Luo Jie
2026-10-12 13:03 ` netdev-bot+sashiko
2026-10-18 12:40 ` Simon Horman
2026-10-11 13:02 ` [PATCH net-next v2 08/11] net: ethernet: qualcomm: ppe: Add IPQ5424 scheduler resource configuration Luo Jie
2026-10-18 12:40 ` Simon Horman
2026-10-11 13:02 ` [PATCH net-next v2 09/11] net: ethernet: qualcomm: ppe: Add IPQ5424 scheduler configuration Luo Jie
2026-10-18 12:41 ` Simon Horman
2026-10-11 13:02 ` [PATCH net-next v2 10/11] net: ethernet: qualcomm: ppe: Add IPQ5424 service code configuration Luo Jie
2026-10-12 13:03 ` netdev-bot+sashiko
2026-10-18 12:41 ` Simon Horman
2026-10-11 13:02 ` [PATCH net-next v2 11/11] net: ethernet: qualcomm: ppe: Add IPQ5424 counter debugfs support Luo Jie
2026-10-18 12:41 ` Simon Horman
2026-10-11 13:05 ` [PATCH net-next v2 00/11] net: ethernet: qualcomm: ppe: Add support for IPQ5424 SoC netdev-bot+sinfo
2026-10-14 8:48 ` Jie Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261018123852.GA503057@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@kernel.org \
--cc=jie.luo@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_kkumarcs@quicinc.com \
--cc=quic_leiwei@quicinc.com \
--cc=quic_linchen@quicinc.com \
--cc=quic_pavir@quicinc.com \
--cc=quic_suruchia@quicinc.com \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.