From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3229ECCF2C9 for ; Sun, 18 Oct 2026 13:37:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xIR3h-0002Jw-Hd; Sun, 18 Oct 2026 09:36:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xIR3d-0002GE-2I for qemu-devel@nongnu.org; Sun, 18 Oct 2026 09:36:13 -0400 Received: from mail-qv1-xf33.google.com ([2607:f8b0:4864:20::f33]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1xIR3a-0002GI-KD for qemu-devel@nongnu.org; Sun, 18 Oct 2026 09:36:12 -0400 Received: by mail-qv1-xf33.google.com with SMTP id 6a1803df08f44-91b83459526so18019606d6.2 for ; Sun, 18 Oct 2026 06:36:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792330569; x=1792935369; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jvbpzHlx3PhD0w74lwv+VGvPz7R/D0s1maih6e/LH1c=; b=WAW8xYy2hOCP4u9xhlMd1Ai7RxsZrfkaDXKy7XSpF6LesjFHKmucAo3g9KnYsVtnHj ayZCtqDHCqLMBjP/I7YDO3eFO/dc6SLZ181bH1JEn5FPdC7A0ve0SDSuIpg6uuwYt/a5 3rU1cLq1zN9spCQtRZXeBIwHmmphTGErTp9J9DuqyHEOfc7wHp/ABMwiWShMfdRrRDLC QlRbiBKskbAvYiwVW/n6PcGpSd3B+bQEe7LiDUsPv3trjVUmLaEzab5owCfy/SUzn7/w bwJPYfPM0u1YCr3g3xGnmubR8VHQBXeVzbTW9du/ylxIow8rU10L/y5uiV0hk02wTBGm pNYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792330569; x=1792935369; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=jvbpzHlx3PhD0w74lwv+VGvPz7R/D0s1maih6e/LH1c=; b=I8vyY4msnBWdDov8ZSFQKGUYWgHoeMeHLe8NZk6ks4sUS8/vQDIyAWxb0koSb6sI3j SuZE3UEBYfy/6w6pkC9T1UwAFGwSlHyNh/gZiFWhzhTOWZtkxwVGVoY3RLEeA2D0KMYz 44DecD/E6b+sz6gAK0X/LvK0WI0UxWE2eGthWOvXY/0YIGUr2wye8ReVOWG7eHGsanJW HjqZGt36DsAeZIS7bOjiEu1aGdpaHgaTXq+cRQoQGfhmS6A4+8y5qL88DqfkeVUgupBo 51Bk2W3iUkGkkhEJu/UcPNha9pCfh57QvyPhyELhnoseAD5ONPCEyj7C9mcG85RSPXE6 pFBQ== X-Gm-Message-State: AFq9FYIHy2fWEldawuaHUTgDheBvHpLu70n0Xle/w/aMY4slCKZeD2my RGjNRM6RDajCXPQ6yL1+AnBW8qjsSQJMMTSiWm901CPTKDFwsNYrTFtS5mpqTYjT X-Gm-Gg: AYBFou01c3vO45FYc4vnzWJoXKUiMLA8BXqDf9tydHCUCgtVEb/lzdWy8/BqjlIzQWc kSeG3OBMgTGsWLbQlIvMuKWWOFLRPEMEQhQ/nI7vtqHP5Uv2qMhcn59U6SWSTdbrfIxG2yckEEm UNzNVglpwVYWV1YD5sFAZ8Rz7MQ5Os7Qfrk2s6MWQTHiJ8gN+6RhaUJilAofEda/jtLpuH3CVaz Mg4nGxK2/yk8hZC9tKYlimpMK4E+xBVJ1RWwFd/qyPklOxeVVtgArBhcRLriwz9p5b4sNnZECt/ QE4Ov/3D20+io3j5Qe9dWxdmReoc+XSarh4uxK9bj9h0vkgDd2/aPx5d1Jyu8qBEqgMH76KH0af xhQTs7ATkWyeJ6V0tZS9SzUZ9wsJsZHP+4lMGfhX4PuvWngh7OyZMGQc9yDSLHYEctHJIW8wvkV IVQTFMumgC5DJ26vqgnrTT2YWuOR9AwQhOJ4qJTMMPYDpD0m1513zI4Ng4+iPSNdxKmJdrKewos UiwmLc4WeGjaCCuGlwNsH6bxCktuzztUyOUizreeFatuo8Hzp75ess6r/Lez1ZKRAGOAT8= X-Received: by 2002:a05:620a:2943:b0:93c:8544:6ad8 with SMTP id af79cd13be357-93f29c97a9fmr827037685a.28.1792330569566; Sun, 18 Oct 2026 06:36:09 -0700 (PDT) Received: from localhost.localdomain ([2606:6d00:159:2900:ecfc:9d0d:b95b:11bf]) by smtp.gmail.com with ESMTPSA id af79cd13be357-93f2a854bb7sm459056485a.23.2026.10.18.06.36.08 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 18 Oct 2026 06:36:09 -0700 (PDT) From: Marcelo Manzo To: qemu-devel@nongnu.org, qemu-arm@nongnu.org Cc: peter.maydell@linaro.org, philmd@oss.qualcomm.com, Marcelo Manzo , Jason Wang Subject: [PATCH v4 04/17] hw/net/bcm2838_genet: add GENET stub device Date: Sun, 18 Oct 2026 09:35:50 -0400 Message-ID: <20261018133603.64323-5-marcelomanzo@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261018133603.64323-1-marcelomanzo@gmail.com> References: <20261018133603.64323-1-marcelomanzo@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::f33; envelope-from=marcelomanzo@gmail.com; helo=mail-qv1-xf33.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Add a bare-bones BCM2838 GENET (Gigabit Ethernet) sysbus device: MMIO region registration, an out-of-range read/write handler that just logs, and a reset callback. No register-level behavior yet; that comes in the following patches. Adapted from patch 19/41 of Sergey Kambalin's Raspberry Pi 4B series (patchwork series 829638) against current QEMU master. The reset callback and class_init() use the current Resettable-phases API (ResettableClass / resettable_class_set_parent_phases()) rather than the plain DeviceClass::reset hook the original patch used, and headers moved under hw/core/, both API changes since the series was originally posted. Signed-off-by: Marcelo Manzo Reviewed-by: Peter Maydell --- hw/net/bcm2838_genet.c | 103 +++++++++++++++++++++++++++ hw/net/meson.build | 2 + hw/net/trace-events | 16 +++++ include/hw/arm/bcm2838_peripherals.h | 2 + include/hw/net/bcm2838_genet.h | 40 +++++++++++ 5 files changed, 163 insertions(+) create mode 100644 hw/net/bcm2838_genet.c create mode 100644 include/hw/net/bcm2838_genet.h diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c new file mode 100644 index 0000000000..a20a9e7c72 --- /dev/null +++ b/hw/net/bcm2838_genet.c @@ -0,0 +1,103 @@ +/* + * BCM2838 Gigabit Ethernet emulation + * + * Copyright (C) 2022 Ovchinnikov Vitalii + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "qemu/osdep.h" +#include "qemu/module.h" +#include "qemu/log.h" +#include "qemu/error-report.h" +#include "net/eth.h" +#include "qapi/error.h" +#include "hw/core/irq.h" +#include "net/checksum.h" +#include "system/dma.h" +#include "hw/core/resettable.h" +#include "hw/net/bcm2838_genet.h" +#include "trace.h" + + +static uint64_t bcm2838_genet_read(void *opaque, hwaddr offset, unsigned size) +{ + uint64_t value = ~0; + + qemu_log_mask( + LOG_GUEST_ERROR, + "%s: out-of-range access, %u bytes @ offset 0x%04" PRIx64 "\n", + __func__, size, offset); + + trace_bcm2838_genet_read(size, offset, value); + return value; +} + +static void bcm2838_genet_write(void *opaque, hwaddr offset, uint64_t value, + unsigned size) { + qemu_log_mask( + LOG_GUEST_ERROR, + "%s: out-of-range access, %u bytes @ offset 0x%04" PRIx64 "\n", + __func__, size, offset); +} + +static const MemoryRegionOps bcm2838_genet_ops = { + .read = bcm2838_genet_read, + .write = bcm2838_genet_write, + .endianness = DEVICE_LITTLE_ENDIAN, + .impl = {.min_access_size = 4, .max_access_size = 4}, + .valid = {.min_access_size = 4, .max_access_size = 4}, +}; + + +static void bcm2838_genet_realize(DeviceState *dev, Error **errp) +{ + BCM2838GenetState *s = BCM2838_GENET(dev); + SysBusDevice *sbd = SYS_BUS_DEVICE(dev); + + /* Controller registers */ + memory_region_init_io(&s->regs_mr, OBJECT(s), &bcm2838_genet_ops, s, + "bcm2838_genet_regs", sizeof(s->regs)); + sysbus_init_mmio(sbd, &s->regs_mr); +} + +static void bcm2838_genet_phy_reset(BCM2838GenetState *s) +{ + trace_bcm2838_genet_phy_reset("done"); +} + +static void bcm2838_genet_reset(Object *obj, ResetType type) +{ + BCM2838GenetState *s = BCM2838_GENET(obj); + + memset(&s->regs, 0x00, sizeof(s->regs)); + + trace_bcm2838_genet_reset("done"); + + bcm2838_genet_phy_reset(s); +} + +static void bcm2838_genet_class_init(ObjectClass *class, const void *data) +{ + static ResettablePhases unused_parent_phases; + DeviceClass *dc = DEVICE_CLASS(class); + ResettableClass *rc = RESETTABLE_CLASS(class); + + dc->realize = bcm2838_genet_realize; + resettable_class_set_parent_phases(rc, NULL, bcm2838_genet_reset, NULL, + &unused_parent_phases); +} + +static const TypeInfo bcm2838_genet_info = { + .name = TYPE_BCM2838_GENET, + .parent = TYPE_SYS_BUS_DEVICE, + .instance_size = sizeof(BCM2838GenetState), + .class_init = bcm2838_genet_class_init, +}; + +static void bcm2838_genet_register(void) +{ + type_register_static(&bcm2838_genet_info); +} + +type_init(bcm2838_genet_register) diff --git a/hw/net/meson.build b/hw/net/meson.build index 63b0e96245..ef85b85adf 100644 --- a/hw/net/meson.build +++ b/hw/net/meson.build @@ -70,4 +70,6 @@ if have_hmp system_ss.add(files('rocker/rocker-hmp-cmds.c')) endif +system_ss.add(when: 'CONFIG_RASPI', if_true: files('bcm2838_genet.c')) + subdir('can') diff --git a/hw/net/trace-events b/hw/net/trace-events index 001a20b0e2..2dde33e892 100644 --- a/hw/net/trace-events +++ b/hw/net/trace-events @@ -528,3 +528,19 @@ xen_netdev_rx(int dev, int idx, int status, int flags) "vif%u idx %d status %d f ethlite_pkt_lost(uint32_t rx_ctrl) "rx_ctrl:0x%" PRIx32 ethlite_pkt_size_too_big(uint64_t size) "size:0x%" PRIx64 ethlite_pkt_tx_size_too_big(uint64_t size) "size:0x%" PRIx64 +# bcm2838_genet.c +bcm2838_genet_read(unsigned int size, uint64_t offset, uint64_t value) "%u bytes @ 0x%04" PRIx64 ": 0x%016" PRIx64 +bcm2838_genet_write(unsigned int size, uint64_t offset, uint64_t value) "%u bytes @ 0x%04" PRIx64 ": 0x%016" PRIx64 +bcm2838_genet_can_receive(const char *state) "receive is %s" +bcm2838_genet_receive(ssize_t bytes_received) "%zd bytes received" +bcm2838_genet_phy_update_link(const char *link_state) "link is %s" +bcm2838_genet_phy_reset(const char *status) "PHY reset %s" +bcm2838_genet_reset(const char *status) "MAC reset %s" +bcm2838_genet_mac_address(const char *info) "%s" +bcm2838_genet_tx_dma(const char *dma_state) "TX DMA %s" +bcm2838_genet_tx_dma_ring(uint32_t ring_en) "TX DMA enabled rings: 0x%05x" +bcm2838_genet_tx_dma_ring_buf(uint32_t ring_buf_en) "TX DMA enabled ring buffers: 0x%05x" +bcm2838_genet_tx_dma_ring_active(unsigned int ring, const char *ring_state) "ring %u is %s" +bcm2838_genet_tx_request(unsigned int ring_idx, uint32_t prod_idx, uint32_t cons_idx) "ring %u, PROD_INDEX %u, CONS_INDEX %u" +bcm2838_genet_tx(unsigned int ring_idx, uint64_t desc_idx, uint32_t desc_status, uint64_t data_addr) "ring %u, descriptor %" PRIu64 ": 0x%08x, data @ 0x%08" PRIx64 +bcm2838_genet_rx_dma_ring_active(unsigned int ring, const char *ring_state) "ring %u is %s" diff --git a/include/hw/arm/bcm2838_peripherals.h b/include/hw/arm/bcm2838_peripherals.h index 7fe92789e8..2a4307bed7 100644 --- a/include/hw/arm/bcm2838_peripherals.h +++ b/include/hw/arm/bcm2838_peripherals.h @@ -52,6 +52,8 @@ #define BCM2838_MPHI_OFFSET 0xb200 #define BCM2838_MPHI_SIZE 0x200 +#define GENET_OFFSET 0x1580000 + #define TYPE_BCM2838_PERIPHERALS "bcm2838-peripherals" OBJECT_DECLARE_TYPE(BCM2838PeripheralState, BCM2838PeripheralClass, BCM2838_PERIPHERALS) diff --git a/include/hw/net/bcm2838_genet.h b/include/hw/net/bcm2838_genet.h new file mode 100644 index 0000000000..91cf1773d5 --- /dev/null +++ b/include/hw/net/bcm2838_genet.h @@ -0,0 +1,40 @@ +/* + * BCM2838 Gigabit Ethernet emulation + * + * Copyright (C) 2022 Ovchinnikov Vitalii + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#ifndef BCM2838_GENET_H +#define BCM2838_GENET_H + +#include "net/net.h" +#include "hw/core/sysbus.h" + +#define TYPE_BCM2838_GENET "bcm2838-genet" +OBJECT_DECLARE_SIMPLE_TYPE(BCM2838GenetState, BCM2838_GENET) + +#define BCM2838_GENET_REV_MAJOR 6 +#define BCM2838_GENET_REV_MINOR 0 + +typedef struct { + uint8_t stub_area[0x10000]; /* temporary stub */ +} BCM2838GenetRegs; + +struct BCM2838GenetState { + /*< private >*/ + SysBusDevice parent_obj; + + /*< public >*/ + + MemoryRegion regs_mr; + AddressSpace dma_as; + + BCM2838GenetRegs regs; + + qemu_irq irq_default; + qemu_irq irq_prio; +}; + +#endif /* BCM2838_GENET_H */ -- 2.55.0