From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A78ACCF2C4 for ; Sun, 18 Oct 2026 13:36:25 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xIR3i-0002L7-MH; Sun, 18 Oct 2026 09:36:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xIR3d-0002IS-RA for qemu-arm@nongnu.org; Sun, 18 Oct 2026 09:36:15 -0400 Received: from mail-qk1-x736.google.com ([2607:f8b0:4864:20::736]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1xIR3b-0002Gl-O6 for qemu-arm@nongnu.org; Sun, 18 Oct 2026 09:36:13 -0400 Received: by mail-qk1-x736.google.com with SMTP id af79cd13be357-93c5b7f5bfaso259939485a.1 for ; Sun, 18 Oct 2026 06:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792330571; x=1792935371; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dyICs8KtURhLh9ERtJL2tsMninZADpeVl6DJ8BnR9IM=; b=EfdEqSLNsOJ2a/My0vbif81ay0ue99yawp3g7eJlGT9qq7Fqf8R2xxq9k5P9KjGOXi nQsqD3r/tQvzGo5YMdpvN8Ig9LMn1cFRZ3xg9vblyl5oS/b5f9VCrih0FRSmUjXHvYuz wrCxazTsdIuRFXWCFLWe2VqgOswyMHqDQI3v896zEMx0EBnJMzKfOmxAAE+bMjQdJzi/ Y/JZAbDMyeu9W8ySHL8mo+DR5sC/URhH27ybe4yXq1XhLlG5ZwARVIJFoV7gLl8rYK3D ZWZI3w23VQ5y8ULkQPKs63bUx7m/7QEPoKeIOZJplILBsTRpBFX6ejEyHLNw0gtRjL1j z2hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792330571; x=1792935371; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=dyICs8KtURhLh9ERtJL2tsMninZADpeVl6DJ8BnR9IM=; b=AacW2bJffxaKvu7kS6mWu19ZIEIPeiAdJMti6fuPQxI453+cWdAhK1cg/OMLArViA1 ZL0yiWX3GPqLjAfyVdIaVicYLAJQ/Bbo91cCI8IS9RC8u1yvxDn2oUzxHu/mAxT/9LUW D9f8fZRuRuIzvMr7bIhy5rxE3EJOAli9hDjsCcrShCW2TAJh/5UQjRF/+1+0RbF5lM/P cRaXrincplUpVkHnAIFbZMyf0k2Su8jkWYXADUwT6j/rBuwuewJisVJ5MmG2dc8Zk9vk H6Zh7r8MoebVOLnrZiPADHKwnCi41fEH9KTE5WfMYYv6k0tWsevx5b26ZW3g05d+tz8z rwUA== X-Forwarded-Encrypted: i=1; AKwUvBwSxvIAHv08Banx5Uy6oQmZPcSXdEF912m94t7AkENwyhIsB2/7lsF1K4d188O579kMSWtDVBjgzQ==@nongnu.org X-Gm-Message-State: AFq9FYJoN9TBnEkZOYng0d/Q4p85Tm8nYojxaytdsBYKSWUwMtvlCbQs NBPNZwy6eBXkyQBfTIsGWvJzF1QVse/ZG61DZYM0KHNkaAg5B3RfD5mTxMTHxLo+ X-Gm-Gg: AYBFou2aqgz233Ikr2pWzZQiL/718zQM5hM/fTVSt7ILNDT7D7AzSBhNpPPMNhwZ6lC wvCoJV6Q8dSME0fnNBQhpogNCp/6O3LxHdPil26DDfzMKujqsTER7htatkqPXxwkh+eRi/aafoV gheDT4MqvM6Zg6RptEKF2SXc2IzHqa0fPpd1uASQvr/1V07K1+04RH//MJ7CLc4FyWeyITxiOVR e59QLY0H3nCf3Ve61yb24gF3V0B09Z5Hd6x8Vm0f+763j57AoR/im1Dou1BFdK8FHHNtaMoDifj ouIOFY07uzIdWPgEZUqY4Z/RxwrZSvBrpCIGZ/HOtVsTAeqPTS2CS732AaVQ7bBu7WzMYadNozj +usAn+DzfdyBOBRpmjh7ju5HO8ZNMJoevlJ5el7OMQmnCtbhRgVe1LWKGl8T5SdHAdda4Xv/grp 5YZ3F2QLaP8lNcuGG43aQZXYHHW7RmZECm/7IiaLOHqh3nPZl+GrYPWED9wkujJ0ErTYf7vjvI5 xnV/B54LO3k6Qc523+mYhKaFA9kiQ8Vm4xZQiqtwmqf8C+P2lmliuFGbxDhsLbsyM8UbZl9DOon IRwXaQ== X-Received: by 2002:a05:620a:4546:b0:93f:22b2:87f3 with SMTP id af79cd13be357-93f29cdf55fmr820089885a.17.1792330570684; Sun, 18 Oct 2026 06:36:10 -0700 (PDT) Received: from localhost.localdomain ([2606:6d00:159:2900:ecfc:9d0d:b95b:11bf]) by smtp.gmail.com with ESMTPSA id af79cd13be357-93f2a854bb7sm459056485a.23.2026.10.18.06.36.09 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 18 Oct 2026 06:36:10 -0700 (PDT) From: Marcelo Manzo To: qemu-devel@nongnu.org, qemu-arm@nongnu.org Cc: peter.maydell@linaro.org, philmd@oss.qualcomm.com, Sergey Kambalin , Sergey Kambalin , Marcelo Manzo , Jason Wang Subject: [PATCH v4 05/17] hw/net/bcm2838_genet: add GENET register structs, part 1/4 Date: Sun, 18 Oct 2026 09:35:51 -0400 Message-ID: <20261018133603.64323-6-marcelomanzo@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261018133603.64323-1-marcelomanzo@gmail.com> References: <20261018133603.64323-1-marcelomanzo@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::736; envelope-from=marcelomanzo@gmail.com; helo=mail-qk1-x736.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org From: Sergey Kambalin Add the SYS, GR_BRIDGE, EXT, INTRL0, and INTRL1 register block layouts and the top-level BCM2838GenetRegs/BCM2838GenetState structs, plus REG32/FIELD accessors for the revision-control and interrupt-status registers. Part of Sergey Kambalin's original Raspberry Pi 4B PCIe/GENET networking series (patchwork series 829638, posted to qemu-devel in 2024, never merged). Carried forward and completed by Marcelo Manzo. Signed-off-by: Sergey Kambalin Signed-off-by: Marcelo Manzo Reviewed-by: Peter Maydell --- hw/net/bcm2838_genet.c | 37 ++++++++++++++++ include/hw/net/bcm2838_genet.h | 77 +++++++++++++++++++++++++++++++++- 2 files changed, 113 insertions(+), 1 deletion(-) diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c index a20a9e7c72..7c4b036224 100644 --- a/hw/net/bcm2838_genet.c +++ b/hw/net/bcm2838_genet.c @@ -15,10 +15,47 @@ #include "hw/core/irq.h" #include "net/checksum.h" #include "system/dma.h" +#include "hw/core/registerfields.h" #include "hw/core/resettable.h" #include "hw/net/bcm2838_genet.h" #include "trace.h" +REG32(GENET_SYS_REV_CTRL, 0) +FIELD(GENET_SYS_REV_CTRL, GPHY_REV, 0, 16) +FIELD(GENET_SYS_REV_CTRL, MINOR_REV, 16, 4) +FIELD(GENET_SYS_REV_CTRL, RSVD_20_23, 20, 4) +FIELD(GENET_SYS_REV_CTRL, MAJOR_REV, 24, 4) +FIELD(GENET_SYS_REV_CTRL, RSVD_28_31, 28, 4) + +REG32(GENET_INTRL_0, 0) +FIELD(GENET_INTRL_0, SCB, 0, 1) +FIELD(GENET_INTRL_0, EPHY, 1, 1) +FIELD(GENET_INTRL_0, PHY_DET_R, 2, 1) +FIELD(GENET_INTRL_0, PHY_DET_F, 3, 1) +FIELD(GENET_INTRL_0, LINK_UP, 4, 1) +FIELD(GENET_INTRL_0, LINK_DOWN, 5, 1) +FIELD(GENET_INTRL_0, UMAC, 6, 1) +FIELD(GENET_INTRL_0, UMAC_TSV, 7, 1) +FIELD(GENET_INTRL_0, TBUF_UNDERRUN, 8, 1) +FIELD(GENET_INTRL_0, RBUF_OVERFLOW, 9, 1) +FIELD(GENET_INTRL_0, HFB_SM, 10, 1) +FIELD(GENET_INTRL_0, HFB_MM, 11, 1) +FIELD(GENET_INTRL_0, MPD_R, 12, 1) +FIELD(GENET_INTRL_0, RXDMA_MBDONE, 13, 1) +FIELD(GENET_INTRL_0, RXDMA_PDONE, 14, 1) +FIELD(GENET_INTRL_0, RXDMA_BDONE, 15, 1) +FIELD(GENET_INTRL_0, TXDMA_MBDONE, 16, 1) +FIELD(GENET_INTRL_0, TXDMA_PDONE, 17, 1) +FIELD(GENET_INTRL_0, TXDMA_BDONE, 18, 1) +FIELD(GENET_INTRL_0, RSVD_19_22, 19, 4) +FIELD(GENET_INTRL_0, MDIO_DONE, 23, 1) +FIELD(GENET_INTRL_0, MDIO_ERROR, 24, 1) +FIELD(GENET_INTRL_0, RSVD_25_31, 25, 4) + +REG32(GENET_INTRL_1, 0) +FIELD(GENET_INTRL_1, TX_INTRS, 0, 16) +FIELD(GENET_INTRL_1, RX_INTRS, 16, 16) + static uint64_t bcm2838_genet_read(void *opaque, hwaddr offset, unsigned size) { diff --git a/include/hw/net/bcm2838_genet.h b/include/hw/net/bcm2838_genet.h index 91cf1773d5..af5e8abd2e 100644 --- a/include/hw/net/bcm2838_genet.h +++ b/include/hw/net/bcm2838_genet.h @@ -19,7 +19,82 @@ OBJECT_DECLARE_SIMPLE_TYPE(BCM2838GenetState, BCM2838_GENET) #define BCM2838_GENET_REV_MINOR 0 typedef struct { - uint8_t stub_area[0x10000]; /* temporary stub */ + uint32_t rev_ctrl; + uint32_t port_ctrl; + uint32_t rbuf_flush_ctrl; + uint32_t tbuf_flush_ctrl; + uint32_t reserved_0x10[12]; +} BCM2838GenetRegsSys; + +typedef struct { + uint32_t reserved_0x0[16]; +} BCM2838GenetRegsGrBridge; + +typedef struct { + uint32_t pwr_mgmt; + uint32_t reserved_0x4[2]; + uint32_t rgmii_oob_ctrl; + uint32_t reserved_0x10[3]; + uint32_t gphy_ctrl; + uint32_t reserved_0x20[24]; +} BCM2838GenetRegsExt; + +typedef struct { + uint32_t stat; + uint32_t set; + uint32_t clear; + uint32_t mask_status; + uint32_t mask_set; + uint32_t mask_clear; + uint32_t reserved_0x18[10]; +} BCM2838GenetRegsIntrl0; + +typedef struct { + uint32_t stat; + uint32_t set; + uint32_t clear; + uint32_t mask_status; + uint32_t mask_set; + uint32_t mask_clear; + uint32_t reserved_0x18[10]; +} BCM2838GenetRegsIntrl1; + +typedef struct { + uint32_t ctrl; + uint32_t reserved_0x4[2]; + uint32_t status; + uint32_t reserved_0x10; + uint32_t chk_ctrl; + uint32_t reserved_0x18[31]; + uint32_t ovfl_cnt; + uint32_t err_cnt; + uint32_t energy_ctrl; + uint32_t reserved_0xA0[5]; + uint32_t size_ctrl; + uint32_t reserved_0xB8[18]; +} BCM2838GenetRegsRbuf; + +typedef struct { + uint32_t ctrl; + uint32_t reserved_0x4[2]; + uint32_t bp_mc; + uint32_t reserved_0x10; + uint32_t energy_ctrl; + uint32_t reserved_0x18[58]; +} BCM2838GenetRegsTbuf; + +typedef struct { + BCM2838GenetRegsSys sys; + BCM2838GenetRegsGrBridge gr_bridge; + BCM2838GenetRegsExt ext; + uint32_t reserved_0x100[64]; + BCM2838GenetRegsIntrl0 intrl0; + BCM2838GenetRegsIntrl1 intrl1; + uint32_t reserved_0x280[32]; + BCM2838GenetRegsRbuf rbuf; + uint32_t reserved_0x400[128]; + BCM2838GenetRegsTbuf tbuf; + uint32_t reserved_0x700[64]; } BCM2838GenetRegs; struct BCM2838GenetState { -- 2.55.0