From: Simon Horman <horms@kernel.org>
To: Alexandre Cassen <acassen@corp.free.fr>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>, Mark Bloch <mbloch@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Moshe Shemesh <moshe@nvidia.com>,
Yevgeny Kliteynik <kliteyn@nvidia.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH net v2 2/2] net/mlx5: HWS, fix modify header pool creation race
Date: Sun, 18 Oct 2026 15:18:23 +0100 [thread overview]
Message-ID: <20261018141823.GL503057@horms.kernel.org> (raw)
In-Reply-To: <20261012100555.1317878-3-acassen@corp.free.fr>
On Mon, Oct 12, 2026 at 12:05:54PM +0200, Alexandre Cassen wrote:
> mlx5_cmd_hws_modify_header_alloc() creates a pool at the index after
> the last one if no pool matches the pattern. TC and CT allocate modify
> headers concurrently, meaning two callers can take the same index and
> the second call fails with -EBUSY.
>
> Its error path also destroys the pool it just created although another
> caller may already use it. Keep such a pool since cleanup releases it.
>
> Pools now live until cleanup so the lookup needs no lock. A miss looks
> again under a mutex before creating the pool.
>
> Tested for regressions on ConnectX-7 with firmware 28.48.1000.
>
> Fixes: b36315ca69cb ("net/mlx5: fs, add HWS modify header API function")
> Signed-off-by: Alexandre Cassen <acassen@corp.free.fr>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-10-18 14:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 10:05 [PATCH net v2 0/2] net/mlx5: HWS, fix pool creation races Alexandre Cassen
2026-10-12 10:05 ` [PATCH net v2 1/2] net/mlx5: HWS, fix reformat pool creation race Alexandre Cassen
2026-10-13 10:08 ` sashiko-bot
2026-10-13 10:25 ` netdev-bot+sashiko
2026-10-18 14:18 ` Simon Horman
2026-10-12 10:05 ` [PATCH net v2 2/2] net/mlx5: HWS, fix modify header " Alexandre Cassen
2026-10-12 18:03 ` Moshe Shemesh
2026-10-13 10:08 ` sashiko-bot
2026-10-18 14:18 ` Simon Horman [this message]
2026-10-19 11:25 ` [PATCH net v2 0/2] net/mlx5: HWS, fix pool creation races Tariq Toukan
2026-10-20 1:51 ` Jakub Kicinski
2026-10-20 10:10 ` Moshe Shemesh
2026-10-20 11:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261018141823.GL503057@horms.kernel.org \
--to=horms@kernel.org \
--cc=acassen@corp.free.fr \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kliteyn@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.