From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FC091E1A3D for ; Sun, 18 Oct 2026 15:07:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792336041; cv=none; b=haf57YZm5r15xsg7opLKQDg1+9LY/ngYjt5PFpAzsPJkRx0rx7xgQKslMTGDEx9UN5ubcU9fLA5nNqk52nSlM8ehbeiw4k1OycHioQCQ0MpH5ieHGm7aa5+9kVhxyWbXQYm4im8WVzv8f66+ZqaC4vtZNXtn3FDVTHsvY0b7uRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792336041; c=relaxed/simple; bh=902SZeHqIk4uqWWFN2876VASEIaoUx9j/UXow1kCSUU=; h=Date:From:To:Cc:Subject:Message-ID; b=jaVfRIMGr4AY8HybJA1C2dWf3xjSz3RjVQU9Jgg7qEdDzx4gxsiAvU7m3Kwsnyg/6LRBaIt8NRjGjJViUyOexyFV5ojpO3DeisseBPpP9GOhR01rKATFPTEkHhTMaheY6Qx9gPg3WGBgKZUhDzVBYVTNCZ8Vy73JU1/Xqbo6Sy0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=f5YTIPXD; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="f5YTIPXD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1792336040; x=1823872040; h=date:from:to:cc:subject:message-id; bh=902SZeHqIk4uqWWFN2876VASEIaoUx9j/UXow1kCSUU=; b=f5YTIPXDRf21DblH6BeiyFLEPM+cJkXAfomDRoXo6wmPWXD7y9PgzF3n LDfaD7VWzEQWE/VPLbW43lbvdU2Vh4gBgmTjYVSCzAVtMILS/PfeRPXQM wJyZJh1xbadnyFwaelKnIlm2Aau44ALF7/Zcbrfk4GGE5xmkbRyElEakr 4+FKE9ms6/eRpuKbengqNXAneGMvPWuCWHw3I5HV1KCxb+xoxqkcQDpPm CEwGCB2DKJ81t3EIzkHRWp3UMZmPeHoFpuwo1iHTRwaGMem2XFYjXhoAS WNFHMWRlTxePKJ5OLFCwh2jHmC2Ois4RoxNKlKSyxAPRv/KxepEJJwjyK Q==; X-CSE-ConnectionGUID: p0n3zXCHRAm4jQdrFCkDYw== X-CSE-MsgGUID: HdT7MohMTPyaoYE4RbvsxQ== X-IronPort-AV: E=McAfee;i="6800,10657,11939"; a="908794" X-IronPort-AV: E=Sophos;i="6.27,165,1787036400"; d="scan'208";a="908794" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2026 08:07:19 -0700 X-CSE-ConnectionGUID: PMnV4g5yR1mGXgXaINZSkw== X-CSE-MsgGUID: JAlVElZwQ/WowZ4GEbdLWQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,165,1787036400"; d="scan'208";a="2331375" Received: from igk-lkp-server01.igk.intel.com (HELO 3c253b998be3) ([10.211.93.152]) by orviesa002.jf.intel.com with ESMTP; 18 Oct 2026 08:07:18 -0700 Received: from kbuild by 3c253b998be3 with local (Exim 4.98.2) (envelope-from ) id 1xISTj-00000000591-3v42; Sun, 18 Oct 2026 15:07:15 +0000 Date: Sun, 18 Oct 2026 17:06:30 +0200 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Dan Carpenter Subject: [akpm-mm:mm-unstable 118/227] drivers/hid/hid-steam.c:557 steam_send_report_id() warn: check sign expansion for '__UNIQUE_ID_x__509' Message-ID: <202610181614.ldIUaaiL-lkp@intel.com> User-Agent: s-nail v14.9.25 Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Unfiltered warning: this smatch report is sent as-is and has not been reviewed for false positives, so please treat it with due skepticism. BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev CC: David Hildenbrand CC: Andrew Morton CC: Linux Memory Management List CC: mm-commits@vger.kernel.org TO: "Lorenzo Stoakes (ARM)" CC: Andrew Morton CC: Linux Memory Management List tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable head: b306deee4cba9b6965a31b7d644f2a92574cd322 commit: d4bc7c1bb882127a525969418018577c807e617e [118/227] mm: add mmap action for discontiguous kernel page mapping :::::: branch date: 35 hours ago :::::: commit date: 35 hours ago config: x86_64-randconfig-2200-20261018 (https://download.01.org/0day-ci/archive/20261018/202610181614.ldIUaaiL-lkp@intel.com/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 smatch: v0.5.0-9187-g5189e3fb If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202610181614.ldIUaaiL-lkp@intel.com/ smatch warnings: drivers/hid/hid-steam.c:557 steam_send_report_id() warn: check sign expansion for '__UNIQUE_ID_x__509' vim +/__UNIQUE_ID_x__509 +557 drivers/hid/hid-steam.c c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 516 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 517 static int steam_send_report_id(struct steam_device *steam, 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 518 u8 *cmd, int size, u8 report_id) c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 519 { c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 520 struct hid_report *r; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 521 u8 *buf; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 522 unsigned int retries = 50; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 523 int ret; 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 524 u32 len; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 525 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 526 r = steam->hdev->report_enum[HID_FEATURE_REPORT].report_id_hash[report_id]; cd11d1a6114bd4 Lee Jones 2022-07-08 527 if (!r) { 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 528 hid_err(steam->hdev, "No HID_FEATURE_REPORT present for ID %u\n", report_id); cd11d1a6114bd4 Lee Jones 2022-07-08 529 return -EINVAL; cd11d1a6114bd4 Lee Jones 2022-07-08 530 } cd11d1a6114bd4 Lee Jones 2022-07-08 531 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 532 len = hid_report_len(r); 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 533 if (len < 64) c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 534 return -EINVAL; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 535 c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 536 buf = hid_alloc_report_buf(r, GFP_KERNEL); c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 537 if (!buf) c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 538 return -ENOMEM; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 539 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 540 /* The report ID is always consistent */ 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 541 buf[0] = report_id; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 542 memcpy(buf + 1, cmd, size); c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 543 de435b770cd949 Vicki Pfau 2026-07-29 544 hid_dbg(steam->hdev, "Sending report %*ph\n", size, cmd); de435b770cd949 Vicki Pfau 2026-07-29 545 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 546 if (!(steam->quirks & STEAM_QUIRK_IBEX)) 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 547 len += 1; 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 548 c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 549 /* c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 550 * Sometimes the wireless controller fails with EPIPE c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 551 * when sending a feature report. 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 552 * Doing a HID_REQ_SET_REPORT and waiting for a while c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 553 * seems to fix that. c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 554 */ c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 555 do { 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 556 ret = hid_hw_raw_request(steam->hdev, report_id, 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 @557 buf, max(size + 1, len), c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 558 HID_FEATURE_REPORT, HID_REQ_SET_REPORT); c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 559 if (ret != -EPIPE) c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 560 break; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 561 msleep(20); c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 562 } while (--retries); c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 563 c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 564 kfree(buf); cfa66cba6d02ff Vicki Pfau 2026-08-11 565 /* cfa66cba6d02ff Vicki Pfau 2026-08-11 566 * Don't log if the failure is -ENODEV, as this cfa66cba6d02ff Vicki Pfau 2026-08-11 567 * can happen normally on disconnect. cfa66cba6d02ff Vicki Pfau 2026-08-11 568 */ cfa66cba6d02ff Vicki Pfau 2026-08-11 569 if (ret < 0 && ret != -ENODEV) c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 570 hid_err(steam->hdev, "%s: error %d (%*ph)\n", __func__, c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 571 ret, size, cmd); c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 572 return ret; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 573 } c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 574 :::::: The code at line 557 was first introduced by commit :::::: 0a80b4e8ec6a6e40937c7abdf8fb2ebe6cc7c1e5 HID: steam: Initial 2026 Steam Controller support :::::: TO: Vicki Pfau :::::: CC: Jiri Kosina -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki