All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Günther Noack" <gnoack3000@gmail.com>
To: Alejandro Colomar <alx@kernel.org>
Cc: linux-man@vger.kernel.org, "Günther Noack" <gnoack3000@gmail.com>,
	"Dmitry V. Levin" <ldv@strace.io>,
	"Pavel Emelyanov" <xemul@virtuozzo.com>,
	"Michael Kerrisk" <mtk.manpages@gmail.com>
Subject: [PATCH v2 04/24] man/man7/sock_diag.7: Fix member order of struct unix_diag_vfs
Date: Sun, 18 Oct 2026 19:36:52 +0200	[thread overview]
Message-ID: <20261018173712.27670-5-gnoack3000@gmail.com> (raw)
In-Reply-To: <20261018173712.27670-1-gnoack3000@gmail.com>

In the kernel's <linux/unix_diag.h>, udiag_vfs_ino comes before
udiag_vfs_dev, and it has been that way since the structure was added
in linux.git 5f7b0569460b (2011-12-16; "unix_diag: Unix inode info
NLA").  Both members are __u32, so code written after the manual page
would silently mix up the inode and the device number.

Also reorder the member descriptions to match.

Fixes: 4f6a0a4a909e (2016-12-07; "sock_diag.7: New page documenting NETLINK_SOCK_DIAG interface")
Cc: Dmitry V. Levin <ldv@strace.io>
Cc: Pavel Emelyanov <xemul@virtuozzo.com>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>
Assisted-by: LLM
Signed-off-by: Günther Noack <gnoack3000@gmail.com>
Reviewed-by: Alejandro Colomar <alx@kernel.org>
---

Notes:
    Compared against unix_diag.h header,
    where the struct field order is different.

 man/man7/sock_diag.7 | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/man/man7/sock_diag.7 b/man/man7/sock_diag.7
index d4e78c46cc8d..35a6d5a80ffc 100644
--- a/man/man7/sock_diag.7
+++ b/man/man7/sock_diag.7
@@ -180,8 +180,8 @@ structure:
 .in +4n
 .EX
 struct unix_diag_vfs {
-    __u32 udiag_vfs_dev;
     __u32 udiag_vfs_ino;
+    __u32 udiag_vfs_dev;
 };
 .EE
 .in
@@ -189,11 +189,11 @@ struct unix_diag_vfs {
 The fields of this structure are as follows:
 .RS
 .TP
-.I udiag_vfs_dev
-The device number of the corresponding on-disk socket inode.
-.TP
 .I udiag_vfs_ino
 The inode number of the corresponding on-disk socket inode.
+.TP
+.I udiag_vfs_dev
+The device number of the corresponding on-disk socket inode.
 .RE
 .TP
 .B UDIAG_SHOW_PEER
-- 
2.56.0


  parent reply	other threads:[~2026-10-18 17:37 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-18 17:36 [PATCH v2 00/24] Documentation fixes in unix(7) Günther Noack
2026-10-18 17:36 ` [PATCH v2 01/24] man/man7/unix.7: ERRORS: EINVAL: The address field is sun_family, not sun_type Günther Noack
2026-10-18 17:36 ` [PATCH v2 02/24] man/man7/unix.7: Socket options: SOL_SOCKET is a level, not a family Günther Noack
2026-10-18 17:36 ` [PATCH v2 03/24] man/man7/unix.7: SO_PASSCRED: ffix Günther Noack
2026-10-18 17:36 ` Günther Noack [this message]
2026-10-18 17:36 ` [PATCH v2 05/24] man/man7/sock_diag.7: udiag_wqueue: This is memory in use, not memory available Günther Noack
2026-10-18 17:36 ` [PATCH v2 06/24] man/man7/unix.7: ERRORS: EPROTONOSUPPORT: Protocol 0 is also accepted Günther Noack
2026-10-18 17:36 ` [PATCH v2 07/24] man/man7/unix.7: ERRORS: ETOOMANYREFS: Fix the conditions Günther Noack
2026-10-18 17:36 ` [PATCH v2 08/24] man/man7/socket.7: SO_PEEK_OFF: This option is no longer specific to unix(7) Günther Noack
2026-10-18 17:36 ` [PATCH v2 09/24] man/man7/unix.7: SO_PEERCRED: Also works for SOCK_SEQPACKET Günther Noack
2026-10-18 17:36 ` [PATCH v2 10/24] man/man7/unix.7: SIOCINQ: Document behavior " Günther Noack
2026-10-18 17:36 ` [PATCH v2 11/24] man/man7/sock_diag.7: udiag_states: Document TCP_CLOSE Günther Noack
2026-10-18 17:37 ` [PATCH v2 12/24] man/man7/sock_diag.7: UNIX_DIAG_NAME: The payload is not always a pathname Günther Noack
2026-10-18 17:37 ` [PATCH v2 13/24] man/man7/sock_diag.7: Document UDIAG_SHOW_UID Günther Noack
2026-10-18 17:37 ` [PATCH v2 14/24] man/man7/unix.7: Several items of the same type may be sent in one message Günther Noack
2026-10-18 17:37 ` [PATCH v2 15/24] man/man2/bind.2: ERRORS: EACCES: Write permission on the directory is required Günther Noack
2026-10-18 17:37 ` [PATCH v2 16/24] man/man7/unix.7: Autobind: Fix when it happens, and mention SO_PASSPIDFD Günther Noack
2026-10-18 17:37 ` [PATCH v2 17/24] man/man7/unix.7: SOCK_RAW is accepted as an alias for SOCK_DGRAM Günther Noack
2026-10-18 17:37 ` [PATCH v2 18/24] man/man7/unix.7: SCM_SECURITY: This is not specific to SELinux Günther Noack
2026-10-18 17:37 ` [PATCH v2 19/24] man/man7/unix.7: SO_PASSSEC: wfix Günther Noack
2026-10-18 17:37 ` [PATCH v2 20/24] man/man7/unix.7: ERRORS: Document EACCES, EAGAIN, EMSGSIZE, ENOSPC, and EPERM Günther Noack
2026-10-18 17:37 ` [PATCH v2 21/24] man/man7/unix.7: Abstract sockets are scoped to a network namespace Günther Noack
2026-10-18 17:37 ` [PATCH v2 22/24] man/man7/unix.7: Remove mentions of unsupported out-of-band messaging Günther Noack
2026-10-18 17:37 ` [PATCH v2 23/24] man/man7/unix.7: Document SO_PASSPIDFD, SO_PEERPIDFD, and SCM_PIDFD Günther Noack
2026-10-18 17:37 ` [PATCH v2 24/24] man/man7/unix.7: Document SO_PASSRIGHTS Günther Noack
2026-10-18 18:37 ` [PATCH v2 00/24] Documentation fixes in unix(7) Kuniyuki Iwashima
2026-10-19  7:05   ` Alejandro Colomar
2026-10-19  8:48     ` Günther Noack
2026-10-19 12:07     ` the meaning of "ffix" (was: [PATCH v2 00/24] Documentation fixes in unix(7)) G. Branden Robinson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261018173712.27670-5-gnoack3000@gmail.com \
    --to=gnoack3000@gmail.com \
    --cc=alx@kernel.org \
    --cc=ldv@strace.io \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=xemul@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.