Re: [PATCH char-misc-next v2 4/4] issei: add driver to driver interface

[kernel test robot <lkp@intel.com>]

Hi Alexander,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 79e5797d243a466138f641932f81dc69f796060c]

url:    https://github.com/intel-lab-lkp/linux/commits/Alexander-Usyskin/issei-save-power_down-flag-while-processing-event/20261018-123052
base:   79e5797d243a466138f641932f81dc69f796060c
patch link:    https://lore.kernel.org/r/20261018-issei_pm_and_itf-v2-4-7a07452e3606%40intel.com
patch subject: [PATCH char-misc-next v2 4/4] issei: add driver to driver interface
config: i386-randconfig-1002-20261019 (https://download.01.org/0day-ci/archive/20261019/202610191253.F5L34Ggm-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261019/202610191253.F5L34Ggm-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610191253.F5L34Ggm-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from include/linux/device.h:15,
                    from drivers/misc/issei/issei_device.c:4:
   drivers/misc/issei/issei_device.c: In function 'issei_device_write':
>> drivers/misc/issei/issei_device.c:163:45: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'ssize_t' {aka 'int'} [-Wformat=]
     163 |                         dev_dbg(&idev->dev, "Failed writing data ret = %ld\n", ret);
         |                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:139:49: note: in definition of macro 'dev_no_printk'
     139 |                         _dev_printk(level, dev, fmt, ##__VA_ARGS__);    \
         |                                                 ^~~
   include/linux/dev_printk.h:171:40: note: in expansion of macro 'dev_fmt'
     171 |         dev_no_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                                        ^~~~~~~
   drivers/misc/issei/issei_device.c:163:25: note: in expansion of macro 'dev_dbg'
     163 |                         dev_dbg(&idev->dev, "Failed writing data ret = %ld\n", ret);
         |                         ^~~~~~~
   drivers/misc/issei/issei_device.c:163:74: note: format string is defined here
     163 |                         dev_dbg(&idev->dev, "Failed writing data ret = %ld\n", ret);
         |                                                                        ~~^
         |                                                                          |
         |                                                                          long int
         |                                                                        %d


vim +163 drivers/misc/issei/issei_device.c

   113	
   114	/**
   115	 * issei_device_write - send data to the firmware client.
   116	 * @ctx: opaque context
   117	 * @ubuf: data to send
   118	 * @length: data length
   119	 * @timeout: operation timeout in milliseconds
   120	 *
   121	 * Return: >=0 data length on success, <0 on error
   122	 */
   123	ssize_t issei_device_write(void *ctx, const u8 *ubuf, size_t length, unsigned long timeout)
   124	{
   125		struct issei_host_client *cl = ctx;
   126		struct issei_device *idev = cl->idev;
   127		ssize_t ret;
   128		long wret;
   129	
   130		if (idev->rst_state != ISSEI_RST_STATE_DONE) {
   131			dev_dbg(&idev->dev, "Device is in transition\n");
   132			return -EBUSY;
   133		}
   134	
   135		if (!length)
   136			return 0;
   137	
   138		/* sanity check */
   139		if (length > idev->dma.length.h2f) {
   140			dev_dbg(&idev->dev, "Write is too big %zu > %zu\n", length,
   141				idev->dma.length.h2f);
   142			return -EFBIG;
   143		}
   144	
   145		u8 *buf __free(kfree) = kmemdup(ubuf, length, GFP_KERNEL);
   146		if (!buf)
   147			return -ENOMEM;
   148	
   149		do {
   150			ret = issei_cl_write(cl, buf, length);
   151			if (ret < 0 && ret != -EAGAIN)
   152				return ret;
   153			/* buf is consumed by issei_cl_write on success */
   154			if (ret >= 0)
   155				retain_and_null_ptr(buf);
   156			wret = wait_event_interruptible_timeout(cl->write_wait,
   157								issei_cl_check_write(cl) != 1,
   158								msecs_to_jiffies(timeout));
   159			if (wret == 0) /* timeout */
   160				wret = -ETIMEDOUT;
   161			if (wret < 0) {
   162				issei_cl_clean_all_wbuf(cl);
 > 163				dev_dbg(&idev->dev, "Failed writing data ret = %ld\n", ret);
   164				return wret;
   165			}
   166		} while (ret == -EAGAIN);
   167	
   168		return ret;
   169	}
   170	EXPORT_SYMBOL_GPL(issei_device_write);
   171	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki