From: Al Viro <viro@zeniv.linux.org.uk>
To: Avi Weiss <thnkslprpt@gmail.com>
Cc: Trond Myklebust <trondmy@kernel.org>,
Anna Schumaker <anna@kernel.org>, Chuck Lever <cel@kernel.org>,
Jeff Layton <jlayton@kernel.org>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sunrpc: instantiate rpc_pipefs dentry before publishing it
Date: Mon, 19 Oct 2026 15:05:19 +0100 [thread overview]
Message-ID: <20261019140519.GJ989762@ZenIV> (raw)
In-Reply-To: <20261019101117.54038-1-thnkslprpt@gmail.com>
On Mon, Oct 19, 2026 at 01:11:17PM +0300, Avi Weiss wrote:
> rpc_mkpipe_dentry() publishes pipe->dentry before
> d_make_persistent() attaches its inode. A concurrent
> rpc_queue_upcall() or rpc_timeout_upcall_queue() can
> conceivably dereference the dentry while d_inode() is NULL.
Details, please... I have no objections against the reordering
per se, but I would like to understand the scenario leading to
such a concurrent call.
next prev parent reply other threads:[~2026-10-19 14:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 10:11 [PATCH] sunrpc: instantiate rpc_pipefs dentry before publishing it Avi Weiss
2026-10-19 14:05 ` Al Viro [this message]
2026-10-19 17:50 ` Avi Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261019140519.GJ989762@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=Dai.Ngo@oracle.com \
--cc=anna@kernel.org \
--cc=cel@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=thnkslprpt@gmail.com \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.