Re: [PATCH] gpiolib: cdev: don't record a line direction the driver refused

[Kent Gibson <warthog618@gmail.com>]

On Mon, Oct 19, 2026 at 10:11:06AM -0400, Bartosz Golaszewski wrote:
> On Sun, 18 Oct 2026 06:25:46 +0200, Kent Gibson <warthog618@gmail.com> said:
> > On Fri, Oct 16, 2026 at 05:14:20PM +0800, Kent Gibson wrote:
> >> On Fri, Oct 16, 2026 at 03:23:24AM -0500, Bartosz Golaszewski wrote:
> >> > On Thu, 15 Oct 2026 17:37:14 +0200, Kent Gibson <warthog618@gmail.com> said:
> >
> > Not sure how kosher this is from a kernel perspective, but that is what I was
> > thinking.
> >
> 
> There are some instances of casting an int to atomic_t but given the "aligned"
> attribute in its type definition, I'm not sure if this is fine either. There
> are roughly 100 places where desc->flags is dereferenced under drivers/gpio/.
> All of them would require inspection and rework.
> 

I did try changing the flags to atomic_long_t, but that made all the existing
atomic bitops complain about the type. :(.
Could we add an alignment attribute to the desc flags to match the atcomic_t
so the cast will be robust?

Alternatively if bitops could be made to work seemlessly with atomic_t...

Cheers,
Kent.