Re: [PATCH wireless-next v2 1/2] wifi: mwifiex: append hotfix number to firmware version string

[Francesco Dolcini <francesco@dolcini.it>]

On Mon, Oct 19, 2026 at 04:16:01PM +0200, Johannes Berg wrote:
> On Mon, 2026-10-19 at 16:13 +0200, Francesco Dolcini wrote:
> > 
> > > +				case FW_HOTFIX_VER_ID: {
> > > +					struct hw_spec_fw_hotfix_ver *hf;
> 
> > > +
> > > +					hf = (void *)tlv;
> > 
> > I would not abuse the void*, you know the type you want
> 
> FWIW, I tend to disagree, spelling out the type again for no real reason
> is just noise. As far as I'm concerned you can do whatever you like in
> the driver though :)

I would say that your opinion trumps mine on this regard.

And it changes nothing on the generated binary, in any way.

The reason I prefer it is that (void*) will silently cast to everything,
and having an explicit type might help in case of mistake introduced
with some future refactoring.

Jeff, up to you, we can take the patch as it is.

And I'd like to have this in the driver, it's something we are missing
and it's valuable.

Francesco