All of lore.kernel.org
 help / color / mirror / Atom feed
From: linuxtestproject.agent@gmail.com
To: Jan Stancek <jstancek@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] float_trigo: Fix acos/asin/atan input generation
Date: Mon, 19 Oct 2026 19:05:25 +0000	[thread overview]
Message-ID: <20261019190525.3963-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <dc45087f4a5dd1700aae6df3a8181ae349f2bdfe.1792413269.git.jstancek@redhat.com>

Hi Jan,

On Mon, 19 Oct 2026, Jan Stancek via ltp wrote:
> float_trigo: Fix acos/asin/atan input generation

Verdict - Reviewed

Pre-existing issue (low severity; separate follow-up):

In genacos.c, genasin.c and genatan.c, both create_*_file() functions
test open() with if (!fp) and ignore write() failures. An output path
that is a directory therefore makes either mode report success and exit
0 without producing data, both before and after this patch. Check
fp < 0, handle write() failures and propagate failure from main().

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-10-19 19:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19 12:34 [LTP] [PATCH] float_trigo: Fix acos/asin/atan input generation Jan Stancek via ltp
2026-10-19 19:05 ` linuxtestproject.agent [this message]
2026-10-19 19:56 ` Avinesh Kumar via ltp
2026-10-21  9:33 ` Andrea Cervesato via ltp
2026-10-21 15:42   ` Jan Stancek via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261019190525.3963-1-linuxtestproject.agent@gmail.com \
    --to=linuxtestproject.agent@gmail.com \
    --cc=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.