Re: [PATCH 1/8] dt-bindings: interconnect: add Qualcomm MSM8998 NoC

[Krzysztof Kozlowski <krzk@kernel.org>]

On Mon, Oct 19, 2026 at 05:12:39PM +0300, Dmitry Baryshkov wrote:
> +properties:
> +  compatible:
> +    enum:
> +      - qcom,msm8998-a1noc
> +      - qcom,msm8998-a2noc
> +      - qcom,msm8998-bimc
> +      - qcom,msm8998-cnoc
> +      - qcom,msm8998-gnoc
> +      - qcom,msm8998-mnoc
> +      - qcom,msm8998-mnoc-ahb
> +      - qcom,msm8998-snoc
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    minItems: 1
> +    maxItems: 4
> +
> +  clock-names:
> +    minItems: 1
> +    maxItems: 4

...


> +  - if:
> +      properties:
> +        compatible:
> +          const: qcom,msm8998-mnoc-ahb
> +
> +    then:
> +      description:
> +        The MMSS AHB NoC shares its register space with the MMSS NoC, so it is
> +        described as a child of the latter and has no register range of its own.
> +
> +      properties:

reg: false

> +        clocks:
> +          items:
> +            - description: MMSS AHB Clock
> +
> +        clock-names:
> +          const: bus
> +
> +      required:
> +        - clocks
> +        - clock-names
> +
> +    else:
> +      required:
> +        - reg
> +
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - qcom,msm8998-bimc
> +            - qcom,msm8998-gnoc
> +
> +    then:
> +      properties:
> +        clocks: false
> +        clock-names: false
> +

unevaluatedProperties should go here, just before the example

> +examples:
> +  - |
> +    #include <dt-bindings/clock/qcom,gcc-msm8998.h>
> +    #include <dt-bindings/clock/qcom,mmcc-msm8998.h>
> +
> +    interconnect@1008300 {
> +        compatible = "qcom,msm8998-bimc";
> +        reg = <0x01008300 0x77d00>;
> +        #interconnect-cells = <2>;
> +    };
> +
> +    interconnect@1740000 {
> +        compatible = "qcom,msm8998-mnoc";
> +        reg = <0x01740000 0x10000>;
> +        clocks = <&mmcc MNOC_AHB_CLK>, <&mmcc MNOC_MAXI_CLK>;
> +        clock-names = "iface", "mnoc_bus";
> +        #interconnect-cells = <2>;
> +
> +        interconnect-mnoc-ahb {

I do not see how this can validate. You do not allow any children in
your binding. Your tpo-level properties should define all possible
properties and nodes.

also, name should be just "interconnect"


Best regards,
Krzysztof