All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrea Cervesato <andrea.cervesato@suse.de>
To: Linux Test Project <ltp@lists.linux.it>
Subject: [LTP] [PATCH v5 14/14] fchroot13: test failfs entry when chrooted
Date: Tue, 20 Oct 2026 12:16:43 +0200	[thread overview]
Message-ID: <20261020-fchroot-v5-14-63aa6faff503@suse.com> (raw)
In-Reply-To: <20261020-fchroot-v5-0-63aa6faff503@suse.com>

From: Andrea Cervesato <andrea.cervesato@suse.com>

Verify that unprivileged fchroot() into failfs is refused when the
process is already chrooted: moving the root of a chrooted task into
failfs would allow it to escape its chroot via openat(fd, "..") with
a pre-opened directory fd, so the kernel refuses the syscall with
EPERM.

Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
---
 runtest/syscalls                              |  1 +
 testcases/kernel/syscalls/fchroot/.gitignore  |  1 +
 testcases/kernel/syscalls/fchroot/fchroot13.c | 61 +++++++++++++++++++++++++++
 3 files changed, 63 insertions(+)

diff --git a/runtest/syscalls b/runtest/syscalls
index bd3bbff4a..2bdb4a9a2 100644
--- a/runtest/syscalls
+++ b/runtest/syscalls
@@ -328,6 +328,7 @@ fchroot09 fchroot09
 fchroot10 fchroot10
 fchroot11 fchroot11
 fchroot12 fchroot12
+fchroot13 fchroot13
 
 fcntl01 fcntl01
 fcntl01_64 fcntl01_64
diff --git a/testcases/kernel/syscalls/fchroot/.gitignore b/testcases/kernel/syscalls/fchroot/.gitignore
index e8a6730ee..3e77e3762 100644
--- a/testcases/kernel/syscalls/fchroot/.gitignore
+++ b/testcases/kernel/syscalls/fchroot/.gitignore
@@ -11,3 +11,4 @@ fchroot09
 fchroot10
 fchroot11
 fchroot12
+fchroot13
diff --git a/testcases/kernel/syscalls/fchroot/fchroot13.c b/testcases/kernel/syscalls/fchroot/fchroot13.c
new file mode 100644
index 000000000..ea361ff6a
--- /dev/null
+++ b/testcases/kernel/syscalls/fchroot/fchroot13.c
@@ -0,0 +1,61 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (C) 2026 SUSE LLC Andrea Cervesato <andrea.cervesato@suse.com>
+ */
+
+/*\
+ * Test that unprivileged :manpage:`fchroot(2)` into failfs is refused
+ * when the process is already chrooted.
+ *
+ * The root directory is what confines ".." resolution and the failfs root
+ * can never be reached by walking up a real mount tree. Moving the root
+ * of a chrooted task into failfs would allow it to escape its chroot via
+ * :manpage:`openat(2)` with ".." and a pre-opened directory file descriptor,
+ * so the kernel refuses the syscall with ``EPERM``.
+ *
+ * Root is required to create the chroot jail before dropping to an
+ * unprivileged user in the forked child.
+ */
+
+#define _GNU_SOURCE
+#include <pwd.h>
+#include <unistd.h>
+#include "tst_test.h"
+#include "lapi/fcntl.h"
+#include "lapi/prctl.h"
+#include "lapi/syscalls.h"
+
+#define JAILDIR "jail"
+
+static struct passwd *ltpuser;
+
+static void run(void)
+{
+	if (SAFE_FORK())
+		return;
+
+	SAFE_CHROOT(JAILDIR);
+	SAFE_CHDIR("/");
+
+	SAFE_SETRESUID(ltpuser->pw_uid, ltpuser->pw_uid,
+		ltpuser->pw_uid);
+
+	SAFE_PRCTL(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
+
+	TST_EXP_FAIL(tst_syscall(__NR_fchroot, FD_FAILFS_ROOT, 0),
+		EPERM, "fchroot() from a chrooted process");
+}
+
+static void setup(void)
+{
+	ltpuser = SAFE_GETPWNAM("nobody");
+	SAFE_MKDIR(JAILDIR, 0755);
+}
+
+static struct tst_test test = {
+	.setup = setup,
+	.test_all = run,
+	.needs_root = 1,
+	.needs_tmpdir = 1,
+	.forks_child = 1,
+};

-- 
2.51.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2026-10-20 10:20 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20 10:16 [LTP] [PATCH v5 00/14] fchroot: add fchroot() testing suite Andrea Cervesato
2026-10-20 10:16 ` [LTP] [PATCH v5 01/14] lapi: fallback fchroot() parameters Andrea Cervesato
2026-10-20 12:39   ` Cyril Hrubis
2026-10-20 14:53   ` [LTP] " linuxtestproject.agent
2026-10-20 15:57     ` Andrea Cervesato via ltp
2026-10-20 10:16 ` [LTP] [PATCH v5 02/14] fchroot01: test fchroot() with a directory fd Andrea Cervesato
2026-10-20 10:16 ` [LTP] [PATCH v5 03/14] fchroot02: test fchroot() invalid arguments Andrea Cervesato
2026-10-20 10:16 ` [LTP] [PATCH v5 04/14] fchroot03: test fchroot() permission checks Andrea Cervesato
2026-10-20 10:16 ` [LTP] [PATCH v5 05/14] fchroot04: test fchroot() into failfs as root Andrea Cervesato
2026-10-20 10:16 ` [LTP] [PATCH v5 06/14] fchroot05: test failfs root can not be referenced Andrea Cervesato
2026-10-20 10:16 ` [LTP] [PATCH v5 07/14] fchroot06: test path walks under failfs root Andrea Cervesato
2026-10-20 13:02   ` Cyril Hrubis
2026-10-20 10:16 ` [LTP] [PATCH v5 08/14] fchroot07: test execve blocked by " Andrea Cervesato
2026-10-20 10:16 ` [LTP] [PATCH v5 09/14] fchroot08: test failfs root fork inheritance Andrea Cervesato
2026-10-20 13:05   ` Cyril Hrubis
2026-10-20 10:16 ` [LTP] [PATCH v5 10/14] fchroot09: test setns escape from failfs root Andrea Cervesato
2026-10-20 15:26   ` Cyril Hrubis
2026-10-20 10:16 ` [LTP] [PATCH v5 11/14] fchroot10: test failfs entry without no_new_privs Andrea Cervesato
2026-10-20 10:16 ` [LTP] [PATCH v5 12/14] fchroot11: test failfs entry with no_new_privs Andrea Cervesato
2026-10-20 15:41   ` Cyril Hrubis
2026-10-20 10:16 ` [LTP] [PATCH v5 13/14] fchroot12: test failfs entry with shared fs_struct Andrea Cervesato
2026-10-20 10:16 ` Andrea Cervesato [this message]
2026-10-20 15:44   ` [LTP] [PATCH v5 14/14] fchroot13: test failfs entry when chrooted Cyril Hrubis
2026-10-20 16:13 ` [LTP] [PATCH v5 00/14] fchroot: add fchroot() testing suite Andrea Cervesato via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261020-fchroot-v5-14-63aa6faff503@suse.com \
    --to=andrea.cervesato@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.