Re: [PATCH] kbuild: improve sanity check for ARCH variable on x86

[Nathan Chancellor <nathan@kernel.org>]

On Mon, Oct 19, 2026 at 05:17:38PM -0700, Cao Jin wrote:
> When building for x86, ARCH=i{4,5,6}86 and x86_32 will fail the build.

Thanks for the patch. Where is it documented that these other options
are valid? It seems like this is just expected behavior because these
are not valid values for setting ARCH for x86. At the very least, I
think something like this needs to be acked by the x86 folks.

> Make it catch all name variants.

You are missing a sign off.

> ---
>  Makefile | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 7c855e6fe544..cd397027891a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -409,12 +409,10 @@ ARCH		?= $(SUBARCH)
>  UTS_MACHINE 	:= $(ARCH)
>  SRCARCH 	:= $(ARCH)
>  
> -# Additional ARCH settings for x86
> -ifeq ($(ARCH),i386)
> -        SRCARCH := x86
> -endif
> -ifeq ($(ARCH),x86_64)
> -        SRCARCH := x86
> +# Additional sanity check for cmdline ARCH settings for x86. This catch
> +# more name variants than "i386" and "x86_64".
> +ifneq ($(findstring 86,$(ARCH)),)
> +    SRCARCH := x86
>  endif
>  
>  # Additional ARCH settings for sparc
> -- 
> 2.55.0
> 

-- 
Cheers,
Nathan