All of lore.kernel.org
 help / color / mirror / Atom feed
From: Raag Jadav <raag.jadav@intel.com>
To: dri-devel@lists.freedesktop.org
Cc: riana.tauro@intel.com, mallesh.koujalagi@intel.com,
	matthew.brost@intel.com, rodrigo.vivi@intel.com,
	christian.koenig@amd.com, andrealmeid@igalia.com,
	Raag Jadav <raag.jadav@intel.com>
Subject: [PATCH v2] drm: Log recovery method with wedged event
Date: Tue, 20 Oct 2026 07:51:17 +0530	[thread overview]
Message-ID: <20261020022117.199831-1-raag.jadav@intel.com> (raw)

Currently, drm_dev_wedged_event() logs a basic message of device being
wedged, but doesn't print the recovery method used by the caller. Log it
for easier bug report analysis.

While at it, as device wedging is a catastrophic event for the cases that
do need recovery, distinguish them and raise their log level to drm_warn().

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
v2: Distinguish between recovery and no recovery cases (Christian, Rodrigo)
---
 drivers/gpu/drm/drm_drv.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
index cb53baa70995..7f8abb72f548 100644
--- a/drivers/gpu/drm/drm_drv.c
+++ b/drivers/gpu/drm/drm_drv.c
@@ -598,8 +598,10 @@ int drm_dev_wedged_event(struct drm_device *dev, unsigned long method,
 		/* Caller is unsure about recovery, do the best we can at this point. */
 		snprintf(event_string, sizeof(event_string), "%s", "WEDGED=unknown");
 
-	drm_info(dev, "device wedged, %s\n", method == DRM_WEDGE_RECOVERY_NONE ?
-		 "but no recovery needed" : "needs recovery");
+	if (method == DRM_WEDGE_RECOVERY_NONE)
+		drm_info(dev, "device wedged, but no recovery needed\n");
+	else
+		drm_warn(dev, "device wedged with method %#lx, needs recovery\n", method);
 
 	if (info && (info->comm[0] != '\0') && (info->pid >= 0)) {
 		snprintf(pid_string, sizeof(pid_string), "PID=%u", info->pid);
-- 
2.43.0


             reply	other threads:[~2026-10-20  2:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20  2:21 Raag Jadav [this message]
2026-10-20 11:13 ` [PATCH v2] drm: Log recovery method with wedged event Christian König
2026-10-20 13:33   ` Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261020022117.199831-1-raag.jadav@intel.com \
    --to=raag.jadav@intel.com \
    --cc=andrealmeid@igalia.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=mallesh.koujalagi@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=riana.tauro@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.