All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Bradley Morgan <brads@mainlining.org>
Cc: broonie@kernel.org, corbet@lwn.net, error27@gmail.com,
	geert@linux-m68k.org, gregkh@linuxfoundation.org,
	kees@kernel.org, konstantin@linuxfoundation.org,
	ksummit@lists.linux.dev, laurent.pinchart@ideasonboard.com,
	leon@kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux@leemhuis.info,
	mst@redhat.com, ojeda@kernel.org, rdunlap@infradead.org,
	skhan@linuxfoundation.org, tytso@mit.edu,
	workflows@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v3 3/7] docs: stable-kernel-rules: drop rules the stable trees do not apply
Date: Tue, 20 Oct 2026 09:29:27 -0400	[thread overview]
Message-ID: <20261020132927.3149027-1-sashal@kernel.org> (raw)
In-Reply-To: <DF061D87-D1A3-42F6-AA3C-C288D3CB6BF3@mainlining.org>

On Fri, Oct 16, 2026 at 05:01:54PM +0100, Bradley Morgan wrote:
>On 16 October 2026 16:28:23 BST, Sasha Levin <sashal@kernel.org> wrote:
>>-- It must be obviously correct and tested.
>>-- It cannot be bigger than 100 lines, with context.
>>+- It must be correct and tested.
>
>s/tested/fully tested ?
>
>'Tested" to agents would be just a basic compile test, maybe we could
>define here what you want the agent to do?
>
>E.g: a W1? A QEMU repro? And others.

This rule applies to every stable patch, and the right testing differs a
lot between, say, a driver fix and an mm change, so I'd rather not pin it
down here. For agents, coding-assistants.rst already covers it: the fix
has to be checked with the reproducer or a full re-analysis, and the
agent has to say explicitly when it could not be built or tested.

>>   - No "trivial" fixes without benefit for users (spelling changes, whitespace
>>     cleanups, etc).
>
>What I tend to do when I use AI on my own projects to find bugs are to get
>it to "verify" what it finds to be a good enough bug. Could you refer to
>the security document here? That could help very well for AI agents to
>find proper bugs.

stable-kernel-rules.rst already points security fixes at
security-bugs.rst, and coding-assistants.rst has agents read
threat-model.rst to decide whether a bug is a vulnerability.

>Id also suggest that perhaps you *could* make a new patch saying that
>
>"When finding bugs, you need to verify that this bug is severe enough to
>need stable backporting or a CVE, if you reckon it is not severe enough
>for them, if it's not reproducible, eliminate the bug from the results"

I'd rather not. A bug that doesn't qualify for stable still needs a fix
in mainline, and many real bugs, races in particular, are hard to
reproduce; that is why this patch drops the "theoretical race" rule. CVEs
are assigned by the CVE team once a fix is in a stable tree, so the
finder doesn't need to decide that.

Confirming that a bug is real before reporting it is the part that
matters, and coding-assistants.rst already asks for a reproducer.

-- 
Thanks,
Sasha

  reply	other threads:[~2026-10-20 13:29 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 15:28 [PATCH v3 0/7] agents: add skills for Fixes tags, stable tags, similar bugs, and commit messages Sasha Levin
2026-10-16 15:28 ` [PATCH v3 1/7] agents: add infrastructure for agent resources Sasha Levin
2026-10-16 16:02   ` Bradley Morgan
2026-10-20 13:29     ` Sasha Levin
2026-10-16 15:28 ` [PATCH v3 2/7] docs: submitting-patches: say which commit a Fixes tag names Sasha Levin
2026-10-16 16:03   ` Bradley Morgan
2026-10-17  8:07   ` Thorsten Leemhuis
2026-10-20 13:54     ` Sasha Levin
2026-10-20 14:26       ` Thorsten Leemhuis
2026-10-16 15:28 ` [PATCH v3 3/7] docs: stable-kernel-rules: drop rules the stable trees do not apply Sasha Levin
2026-10-16 15:59   ` Greg Kroah-Hartman
2026-10-16 16:01   ` Bradley Morgan
2026-10-20 13:29     ` Sasha Levin [this message]
2026-10-17 16:44   ` SJ Park
2026-10-16 15:28 ` [PATCH v3 4/7] agents: add a skill to determine Fixes tags Sasha Levin
2026-10-16 16:04   ` Bradley Morgan
2026-10-16 15:28 ` [PATCH v3 5/7] agents: add a skill to determine stable tags Sasha Levin
2026-10-16 16:04   ` Bradley Morgan
2026-10-16 15:28 ` [PATCH v3 6/7] agents: add a skill to find other instances of a fixed bug Sasha Levin
2026-10-16 16:05   ` Bradley Morgan
2026-10-16 18:00   ` Julia Lawall
2026-10-16 18:09     ` Sasha Levin
2026-10-16 18:17       ` Julia Lawall
2026-10-16 18:32         ` Sasha Levin
2026-10-16 15:28 ` [PATCH v3 7/7] agents: add a skill to write commit messages Sasha Levin
2026-10-16 16:05   ` Bradley Morgan
2026-10-20 13:29     ` Sasha Levin
2026-10-16 16:00 ` [PATCH v3 0/7] agents: add skills for Fixes tags, stable tags, similar bugs, and " Miguel Ojeda
2026-10-20 13:31   ` Sasha Levin
2026-10-20 16:23     ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261020132927.3149027-1-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=brads@mainlining.org \
    --cc=broonie@kernel.org \
    --cc=corbet@lwn.net \
    --cc=error27@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kees@kernel.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=ksummit@lists.linux.dev \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=leon@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@leemhuis.info \
    --cc=mst@redhat.com \
    --cc=ojeda@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.