From: Ido Schimmel <idosch@nvidia.com>
To: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, David Ahern <dsahern@kernel.org>,
William Tu <u9012063@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] erspan: skip the platform specific sub-header of ERSPAN type III
Date: Tue, 20 Oct 2026 20:16:23 +0300 [thread overview]
Message-ID: <20261020171623.GB3236673@shredder> (raw)
In-Reply-To: <20261018090236.2487997-3-yanhaishuang@cmss.chinamobile.com>
On Sun, Oct 18, 2026 at 05:02:36PM +0800, Haishuang Yan wrote:
> The ERSPAN type III header has an O flag, which tells whether an
> optional platform specific sub-header of 8 octets follows it. The
> ERSPAN payload starts after that sub-header when the flag is set [1].
>
> Linux never sets the flag on transmit, but it ignores it on receive
> too. When a peer sends the sub-header, its 8 bytes are passed up as the
> start of the mirrored Ethernet frame, so the frame is corrupted.
>
> Pull the sub-header as well when the O flag is set. The collect_md
> metadata still only carries the fixed part of the type III header.
>
> [1] https://datatracker.ietf.org/doc/html/draft-foschiano-erspan-03
>
> Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
The cover letter says this was tested with hand-built packets. Do you
have a device that actually sends the sub-header? If not, then I don't
see a reason to add more dead code to this driver which nobody seems to
care about given the lack of reviews.
next prev parent reply other threads:[~2026-10-20 17:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 9:02 [PATCH net-next 0/2] erspan: fix two header parsing issues on receive Haishuang Yan
2026-10-18 9:02 ` [PATCH net-next 1/2] erspan: drop packets with an unknown ERSPAN version Haishuang Yan
2026-10-20 17:15 ` Ido Schimmel
2026-10-21 6:00 ` Haishuang Yan
2026-10-18 9:02 ` [PATCH net-next 2/2] erspan: skip the platform specific sub-header of ERSPAN type III Haishuang Yan
2026-10-20 17:16 ` Ido Schimmel [this message]
2026-10-21 6:01 ` Haishuang Yan
2026-10-18 9:09 ` [PATCH net-next 0/2] erspan: fix two header parsing issues on receive netdev-bot+sinfo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261020171623.GB3236673@shredder \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=u9012063@gmail.com \
--cc=yanhaishuang@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.