From: Jakub Kicinski <kuba@kernel.org>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: netdev@vger.kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
Michal Schmidt <mschmidt@redhat.com>,
edumazet@kernel.org, horms@kernel.org, pabeni@redhat.com,
davem@davemloft.net, Jiri Pirko <jiri@resnulli.us>,
Jonathan Corbet <corbet@lwn.net>,
skhan@linuxfoundation.org, rdunlap@infradead.org,
andrew+netdev@lunn.ch, saeedm@nvidia.com, tariqt@nvidia.com,
leon@kernel.org, mbloch@nvidia.com, jacob.e.keller@intel.com,
jedrzej.jagielski@intel.com, anzaki@gmail.com,
brett.creeley@amd.com, jtornosm@redhat.com, ohartoov@nvidia.com
Subject: Re: [PATCH net-next v3 12/15] devlink: give user option to allocate resources
Date: Tue, 20 Oct 2026 20:20:39 -0700 [thread overview]
Message-ID: <20261020202039.7f4b8abb@kernel.org> (raw)
In-Reply-To: <20261015185454.6332-13-przemyslaw.kitszel@intel.com>
On Thu, 15 Oct 2026 20:51:23 +0200 Przemek Kitszel wrote:
> + if (resource->occ_get &&
> + devlink_nl_put_u64(skb, DEVLINK_ATTR_RESOURCE_OCC,
> + resource->occ_get(resource->occ_priv)))
> + goto err;
> +
> + return 0;
> +err:
> + return -EMSGSIZE;
Why the goto? It's pretty idiomatic to return EMSGSIZE in place
for put failures
next prev parent reply other threads:[~2026-10-21 3:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 18:51 [PATCH net-next v3 00/15] devlink, mlx5, iavf, ice: XLVF for iavf Przemek Kitszel
2026-10-15 18:51 ` [PATCH net-next v3 01/15] devlink, mlx5: add init/fini ops for shared devlink Przemek Kitszel
2026-10-19 18:50 ` Tariq Toukan
2026-10-15 18:51 ` [PATCH net-next v3 02/15] ice: use shared devlink to store ice_adapters instead of custom xarray Przemek Kitszel
2026-10-15 18:51 ` [PATCH net-next v3 03/15] ice: add VF queue ena/dis helper functions Przemek Kitszel
2026-10-15 18:51 ` [PATCH net-next v3 04/15] ice: add helpers for Global RSS LUT alloc, free, vsi_update Przemek Kitszel
2026-10-15 18:51 ` [PATCH net-next v3 05/15] ice: rename ICE_MAX_RSS_QS_PER_VF to ICE_MAX_QS_PER_VF_VCV1 Przemek Kitszel
2026-10-15 18:51 ` [PATCH net-next v3 06/15] ice: bump to 256qs for VF Przemek Kitszel
2026-10-15 18:51 ` [PATCH net-next v3 07/15] iavf: extend iavf_configure_queues() to support more queues Przemek Kitszel
2026-10-15 18:51 ` [PATCH net-next v3 08/15] iavf: temporary rename of IAVF_MAX_REQ_QUEUES to IAVF_MAX_REQ_QUEUES_VCV1 Przemek Kitszel
2026-10-15 18:51 ` [PATCH net-next v3 09/15] iavf: increase max number of queues to 256 Przemek Kitszel
2026-10-15 18:51 ` [PATCH net-next v3 10/15] iavf: use new opcodes to request more than 16 queues Przemek Kitszel
2026-10-15 18:51 ` [PATCH net-next v3 11/15] ice: introduce handling of virtchnl LARGE VF opcodes Przemek Kitszel
2026-10-15 18:51 ` [PATCH net-next v3 12/15] devlink: give user option to allocate resources Przemek Kitszel
2026-10-21 3:20 ` Jakub Kicinski [this message]
2026-10-15 18:51 ` [PATCH net-next v3 13/15] ice: represent RSS LUTs as devlink resources Przemek Kitszel
2026-10-21 3:20 ` Jakub Kicinski
2026-10-15 18:51 ` [PATCH net-next v3 14/15] devlink: add devlink_alloc_drv() Przemek Kitszel
2026-10-15 18:51 ` [PATCH net-next v3 15/15] ice: support up to 256 VF queues Przemek Kitszel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261020202039.7f4b8abb@kernel.org \
--to=kuba@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=anzaki@gmail.com \
--cc=brett.creeley@amd.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jedrzej.jagielski@intel.com \
--cc=jiri@resnulli.us \
--cc=jtornosm@redhat.com \
--cc=leon@kernel.org \
--cc=mbloch@nvidia.com \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=ohartoov@nvidia.com \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rdunlap@infradead.org \
--cc=saeedm@nvidia.com \
--cc=skhan@linuxfoundation.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.