diff for duplicates of <202610202334.hwrqtbb4-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 46403cb..0ce9f12 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,16 +1,6 @@ -Unfiltered warning: this smatch report is sent as-is and has not been -reviewed for false positives, so please treat it with due skepticism. - -BCC: lkp@intel.com -CC: oe-kbuild-all@lists.linux.dev -TO: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> -CC: Takashi Iwai <tiwai@suse.de> - tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 8f7df005a7564bd7ffa75da9c3085d5b996f1e16 commit: fbc74ca9fbf7e0b8f6872ccac62f9f4a1f3b5e53 [18830/19064] ALSA: compress: fix buffer leak on failed SET_PARAMS -:::::: branch date: 7 hours ago -:::::: commit date: 12 hours ago config: i386-randconfig-2200-20261020 (https://download.01.org/0day-ci/archive/20261020/202610202334.hwrqtbb4-lkp@intel.com/config) compiler: gcc-12 (Debian 12.4.0-5) 12.4.0 smatch: v0.5.0-9187-g5189e3fb @@ -26,7 +16,6 @@ sound/core/compress_offload.c:716 snd_compr_set_params() warn: missing error cod vim +/retval +716 sound/core/compress_offload.c -4dc040a0b34890 Vinod Koul 2012-09-17 679 b21c60a4edd22e Vinod Koul 2011-12-23 680 static int b21c60a4edd22e Vinod Koul 2011-12-23 681 snd_compr_set_params(struct snd_compr_stream *stream, unsigned long arg) b21c60a4edd22e Vinod Koul 2011-12-23 682 { @@ -64,9 +53,16 @@ fbc74ca9fbf7e0 Peter Ujfalusi 2026-10-19 713 } 49bb6402f1aa1e Charles Keepax 2013-04-18 714 7ea9ee0064281e Srinivas Kandagatla 2023-06-19 715 if (stream->next_track) 9b02221422a55e Takashi Iwai 2024-02-22 @716 return retval; + +This should either be "return -ESOMETHING;" or "return 0;". The current +code returns zero but in an obfuscated way. + 7ea9ee0064281e Srinivas Kandagatla 2023-06-19 717 9727b490e543de Jeeja KP 2013-02-14 718 stream->metadata_set = false; 9727b490e543de Jeeja KP 2013-02-14 719 stream->next_track = false; + +This could be deleted because of the above check. + 49bb6402f1aa1e Charles Keepax 2013-04-18 720 49bb6402f1aa1e Charles Keepax 2013-04-18 721 stream->runtime->state = SNDRV_PCM_STATE_SETUP; 769fab2a41da4b Jesper Juhl 2012-01-23 722 } else { @@ -74,13 +70,6 @@ b21c60a4edd22e Vinod Koul 2011-12-23 723 return -EPERM; 769fab2a41da4b Jesper Juhl 2012-01-23 724 } b21c60a4edd22e Vinod Koul 2011-12-23 725 return retval; b21c60a4edd22e Vinod Koul 2011-12-23 726 } -b21c60a4edd22e Vinod Koul 2011-12-23 727 - -:::::: The code at line 716 was first introduced by commit -:::::: 9b02221422a55e834469fdc91dc4d5147f5a1fb9 ALSA: compress_offload: Use automatic cleanup of kfree() - -:::::: TO: Takashi Iwai <tiwai@suse.de> -:::::: CC: Takashi Iwai <tiwai@suse.de> -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index 7593482..4d8e734 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,24 +1,16 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <error27@gmail.com>\0" "Subject\0[linux-next:master 18830/19064] sound/core/compress_offload.c:716 snd_compr_set_params() warn: missing error code? 'retval'\0" - "Date\0Tue, 20 Oct 2026 23:08:33 +0200\0" - "To\0oe-kbuild@lists.linux.dev\0" + "Date\0Wed, 21 Oct 2026 08:54:46 +0300\0" + "To\0oe-kbuild@lists.linux.dev" + " Peter Ujfalusi <peter.ujfalusi@linux.intel.com>\0" "Cc\0lkp@intel.com" - " Dan Carpenter <error27@gmail.com>\0" + oe-kbuild-all@lists.linux.dev + " Takashi Iwai <tiwai@suse.de>\0" "\00:1\0" "b\0" - "Unfiltered warning: this smatch report is sent as-is and has not been\n" - "reviewed for false positives, so please treat it with due skepticism.\n" - "\n" - "BCC: lkp@intel.com\n" - "CC: oe-kbuild-all@lists.linux.dev\n" - "TO: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>\n" - "CC: Takashi Iwai <tiwai@suse.de>\n" - "\n" "tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master\n" "head: 8f7df005a7564bd7ffa75da9c3085d5b996f1e16\n" "commit: fbc74ca9fbf7e0b8f6872ccac62f9f4a1f3b5e53 [18830/19064] ALSA: compress: fix buffer leak on failed SET_PARAMS\n" - ":::::: branch date: 7 hours ago\n" - ":::::: commit date: 12 hours ago\n" "config: i386-randconfig-2200-20261020 (https://download.01.org/0day-ci/archive/20261020/202610202334.hwrqtbb4-lkp@intel.com/config)\n" "compiler: gcc-12 (Debian 12.4.0-5) 12.4.0\n" "smatch: v0.5.0-9187-g5189e3fb\n" @@ -34,7 +26,6 @@ "\n" "vim +/retval +716 sound/core/compress_offload.c\n" "\n" - "4dc040a0b34890 Vinod Koul 2012-09-17 679 \n" "b21c60a4edd22e Vinod Koul 2011-12-23 680 static int\n" "b21c60a4edd22e Vinod Koul 2011-12-23 681 snd_compr_set_params(struct snd_compr_stream *stream, unsigned long arg)\n" "b21c60a4edd22e Vinod Koul 2011-12-23 682 {\n" @@ -72,9 +63,16 @@ "49bb6402f1aa1e Charles Keepax 2013-04-18 714 \n" "7ea9ee0064281e Srinivas Kandagatla 2023-06-19 715 \t\tif (stream->next_track)\n" "9b02221422a55e Takashi Iwai 2024-02-22 @716 \t\t\treturn retval;\n" + "\n" + "This should either be \"return -ESOMETHING;\" or \"return 0;\". The current\n" + "code returns zero but in an obfuscated way.\n" + "\n" "7ea9ee0064281e Srinivas Kandagatla 2023-06-19 717 \n" "9727b490e543de Jeeja KP 2013-02-14 718 \t\tstream->metadata_set = false;\n" "9727b490e543de Jeeja KP 2013-02-14 719 \t\tstream->next_track = false;\n" + "\n" + "This could be deleted because of the above check.\n" + "\n" "49bb6402f1aa1e Charles Keepax 2013-04-18 720 \n" "49bb6402f1aa1e Charles Keepax 2013-04-18 721 \t\tstream->runtime->state = SNDRV_PCM_STATE_SETUP;\n" "769fab2a41da4b Jesper Juhl 2012-01-23 722 \t} else {\n" @@ -82,16 +80,9 @@ "769fab2a41da4b Jesper Juhl 2012-01-23 724 \t}\n" "b21c60a4edd22e Vinod Koul 2011-12-23 725 \treturn retval;\n" "b21c60a4edd22e Vinod Koul 2011-12-23 726 }\n" - "b21c60a4edd22e Vinod Koul 2011-12-23 727 \n" - "\n" - ":::::: The code at line 716 was first introduced by commit\n" - ":::::: 9b02221422a55e834469fdc91dc4d5147f5a1fb9 ALSA: compress_offload: Use automatic cleanup of kfree()\n" - "\n" - ":::::: TO: Takashi Iwai <tiwai@suse.de>\n" - ":::::: CC: Takashi Iwai <tiwai@suse.de>\n" "\n" "--\n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -9589d71eb87f87226f0f92ddfc680feaa3a289516d5d9e22d338fa8bd77aa641 +733120d2d26c72b1ef7e50b49b3bacdd91aa4bf1f88ca4caf6b5c00ea07a78da
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.