From: Stanley Jhu <stanleyjhu@google.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K . Petersen" <mkp@kernel.org>,
linux-scsi@vger.kernel.org,
"James E . J . Bottomley"
<James.Bottomley@HansenPartnership.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Bean Huo <beanhuo@micron.com>,
Peter Wang <peter.wang@mediatek.com>,
Can Guo <can.guo@oss.qualcomm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 6/7] scsi: ufs: core: Fix double release in ufshcd_abort()
Date: Wed, 21 Oct 2026 11:54:47 +0800 [thread overview]
Message-ID: <20261021035447.3488381-1-stanleyjhu@google.com> (raw)
In-Reply-To: <04957492-ed95-426c-a5e1-5491ec749c16@acm.org>
On 10/20/26 1:13 PM, Bart Van Assche wrote:
> This change is incomplete. "err = SUCCESS" is missing above "goto
> release". Without this change, the SCSI error handler will escalate
> error handling unnecessarily to the next level.
Fixed in v4 by setting err = SUCCESS when
ufshcd_clear_outstanding_reqs() claims the tag. If the claim fails, a
concurrent ufshcd_poll() may still be completing the command, so the
handler keeps returning FAILED.
next prev parent reply other threads:[~2026-10-21 3:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 8:21 [PATCH v3 0/7] scsi: ufs: core: Factor hba->outstanding_reqs helper and fix double completions Stanley Jhu
2026-10-20 8:21 ` [PATCH v3 1/7] scsi: ufs: core: Remove an always-false WARN_ONCE() Stanley Jhu
2026-10-20 16:53 ` Bart Van Assche
2026-10-20 8:21 ` [PATCH v3 2/7] scsi: ufs: core: Add a helper for clearing hba->outstanding_reqs Stanley Jhu
2026-10-20 16:58 ` Bart Van Assche
2026-10-20 8:21 ` [PATCH v3 3/7] scsi: ufs: core: Fix double completion in ufshcd_clear_lu_cmds() Stanley Jhu
2026-10-20 19:57 ` Bart Van Assche
2026-10-20 8:21 ` [PATCH v3 4/7] scsi: ufs: core: Use ufshcd_clear_outstanding_reqs() in ufshcd_eh_timed_out() Stanley Jhu
2026-10-20 8:21 ` [PATCH v3 5/7] scsi: ufs: core: Fix double release " Stanley Jhu
2026-10-20 17:11 ` Bart Van Assche
2026-10-20 8:21 ` [PATCH v3 6/7] scsi: ufs: core: Fix double release in ufshcd_abort() Stanley Jhu
2026-10-20 20:13 ` Bart Van Assche
2026-10-21 3:54 ` Stanley Jhu [this message]
2026-10-20 8:21 ` [PATCH v3 7/7] scsi: ufs: core: Do not release a reserved request " Stanley Jhu
2026-10-20 20:16 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261021035447.3488381-1-stanleyjhu@google.com \
--to=stanleyjhu@google.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=can.guo@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkp@kernel.org \
--cc=peter.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.