From: phucduc.bui@gmail.com
To: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>, bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH v3 2/2] leds: lm3532: Avoid duplicate error messages
Date: Wed, 21 Oct 2026 11:58:32 +0700 [thread overview]
Message-ID: <20261021045832.16356-2-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20261021045832.16356-1-phucduc.bui@gmail.com>
From: bui duc phuc <phucduc.bui@gmail.com>
Most error paths in lm3532_parse_node() already log errors. Remove
the redundant error message from lm3532_probe() to avoid duplicate
logs.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
Link v1 :
https://lore.kernel.org/all/20261007104915.507801-1-phucduc.bui@gmail.com/
Link v2 :
https://lore.kernel.org/all/20261009091059.25729-1-phucduc.bui@gmail.com/
Changes in v3:
- Remove the error message for devm_add_action() failures.
drivers/leds/leds-lm3532.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/leds/leds-lm3532.c b/drivers/leds/leds-lm3532.c
index a3bc9680dc4c..a050e4350bdb 100644
--- a/drivers/leds/leds-lm3532.c
+++ b/drivers/leds/leds-lm3532.c
@@ -708,10 +708,8 @@ static int lm3532_probe(struct i2c_client *client)
i2c_set_clientdata(client, drvdata);
ret = lm3532_parse_node(drvdata);
- if (ret) {
- dev_err(&client->dev, "Failed to parse node\n");
+ if (ret)
return ret;
- }
return ret;
}
--
2.43.0
next prev parent reply other threads:[~2026-10-21 4:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 4:58 [PATCH v3 1/2] leds: lm3532: Propagate enable GPIO errors phucduc.bui
2026-10-21 4:58 ` phucduc.bui [this message]
2026-10-21 5:01 ` [PATCH v3 2/2] leds: lm3532: Avoid duplicate error messages sashiko-bot
2026-10-21 5:01 ` [PATCH v3 1/2] leds: lm3532: Propagate enable GPIO errors sashiko-bot
2026-10-30 12:59 ` Griffin Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261021045832.16356-2-phucduc.bui@gmail.com \
--to=phucduc.bui@gmail.com \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.