All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mehmet Fide <mehmet.fide@gmail.com>
To: Marek Vasut <marek.vasut+usb@mailbox.org>
Cc: Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>,
	Fabio Estevam <festevam@gmail.com>,
	Stefan Agner <stefan@agner.ch>,
	Francesco Dolcini <francesco@dolcini.it>,
	u-boot@lists.u-boot-project.org, mehmet.fide@screeningeagle.com
Subject: Re: [PATCH v7 6/9] usb: ehci-vf: use usb_get_dr_mode()
Date: Wed, 21 Oct 2026 14:21:34 +0200	[thread overview]
Message-ID: <20261021122134.4139945-1-mehmet.fide@gmail.com> (raw)
In-Reply-To: <477ecb2a-3738-44ce-a563-4b029f5e6d39@mailbox.org>

Hi Marek,

On 2026-10-21, Marek Vasut wrote:
> You probably don't need the ofnode_read_string(...) above, it is part of
> the usb_get_dr_mode(dev_ofnode(dev)) already.

Then a missing dr_mode fails the probe like an unknown one, where the
old code took it as host. Both USB nodes in vfxxx.dtsi set dr_mode, so
no in-tree board changes. Fine with you for v8?

Thanks,
Mehmet

  reply	other threads:[~2026-10-21 12:21 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20 10:15 [PATCH v7 0/9] usb: ehci-vf: make the USB host port usable Mehmet Fide
2026-10-20 10:16 ` [PATCH v7 1/9] fdtdec: match an alias to its stem only when the number follows it Mehmet Fide
2026-10-20 10:16 ` [PATCH v7 2/9] usb: ehci-vf: take the controller index from the device tree Mehmet Fide
2026-10-20 10:16 ` [PATCH v7 3/9] usb: ehci-vf: remove the code path for a build without DM_USB Mehmet Fide
2026-10-20 10:16 ` [PATCH v7 4/9] usb: ehci-vf: drop the empty bind hook Mehmet Fide
2026-10-20 10:16 ` [PATCH v7 5/9] dm: core: add ofnode_get_alias_seq() Mehmet Fide
2026-10-20 10:16 ` [PATCH v7 6/9] usb: ehci-vf: use usb_get_dr_mode() Mehmet Fide
2026-10-21  0:09   ` Marek Vasut
2026-10-21 11:59     ` Mehmet Fide
2026-10-21 12:07       ` Marek Vasut
2026-10-21 12:21         ` Mehmet Fide [this message]
2026-10-21 13:17           ` Marek Vasut
2026-10-21 18:41             ` Mehmet Fide
2026-10-21 18:56               ` Marek Vasut
2026-10-20 10:16 ` [PATCH v7 7/9] usb: ehci-vf: request the ID detect gpio through the device Mehmet Fide
2026-10-21  0:10   ` Marek Vasut
2026-10-20 10:16 ` [PATCH v7 8/9] usb: ehci-vf: take the register bases from the device tree Mehmet Fide
2026-10-21  0:13   ` Marek Vasut
2026-10-20 10:16 ` [PATCH v7 9/9] usb: ehci-vf: enable the vbus supply of the port Mehmet Fide
2026-10-21  0:13   ` Marek Vasut
2026-10-21 11:59     ` Mehmet Fide

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261021122134.4139945-1-mehmet.fide@gmail.com \
    --to=mehmet.fide@gmail.com \
    --cc=festevam@gmail.com \
    --cc=francesco@dolcini.it \
    --cc=marek.vasut+usb@mailbox.org \
    --cc=mehmet.fide@screeningeagle.com \
    --cc=sjg@chromium.org \
    --cc=stefan@agner.ch \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.u-boot-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.