From: Azuama Odinaka Maximus <azuama69@gmail.com>
To: git@vger.kernel.org
Cc: Azuama Odinaka Maximus <azuama69@gmail.com>
Subject: [PATCH] rev-list: skip --grep argument in early scan
Date: Wed, 21 Oct 2026 16:12:53 +0100 [thread overview]
Message-ID: <20261021151253.3689-1-azuama69@gmail.com> (raw)
Signed-off-by: Azuama Odinaka Maximus <azuama69@gmail.com>
---
builtin/rev-list.c | 2 ++
t/t6022-rev-list-missing.sh | 6 ++++++
2 files changed, 8 insertions(+)
diff --git a/builtin/rev-list.c b/builtin/rev-list.c
index 0faa833fac..453d82d25c 100644
--- a/builtin/rev-list.c
+++ b/builtin/rev-list.c
@@ -771,6 +771,8 @@ int cmd_rev_list(int argc,
revs.exclude_promisor_objects = 1;
} else if (skip_prefix(arg, "--missing=", &arg)) {
parse_missing_action_value(repo, arg);
+ } else if (!strcmp(arg, "--grep")) {
+ i++;
} else if (!strcmp(arg, "--missing-only")) {
arg_missing_only = 1;
} else if (!strcmp(arg, "-z")) {
diff --git a/t/t6022-rev-list-missing.sh b/t/t6022-rev-list-missing.sh
index 1bd2c3bc4f..e87678e468 100755
--- a/t/t6022-rev-list-missing.sh
+++ b/t/t6022-rev-list-missing.sh
@@ -215,6 +215,12 @@ do
'
done
+test_expect_success "--grep accepts a pattern beginning with --" '
+ git rev-list --grep=--missing-only --max-count=1 HEAD >expect &&
+ git rev-list --grep --missing-only --max-count=1 HEAD >actual &&
+ test_cmp expect actual
+'
+
test_expect_success "--missing-only requires --missing=print or --missing=print-info" '
test_must_fail git rev-list --missing-only --objects HEAD 2>err &&
test_grep "requires --missing=print" err
--
2.53.0
next reply other threads:[~2026-10-21 15:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 15:12 Azuama Odinaka Maximus [this message]
2026-10-21 15:42 ` [PATCH] rev-list: skip --grep argument in early scan Pushkar Singh
2026-10-21 17:24 ` [PATCH v2] " Azuama Odinaka Maximus
2026-10-22 13:45 ` Pushkar Singh
2026-10-23 18:14 ` Junio C Hamano
2026-10-26 8:30 ` [PATCH v3] " Azuama Odinaka Maximus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261021151253.3689-1-azuama69@gmail.com \
--to=azuama69@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.