All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mohamed Khalfella <mkhalfella@purestorage.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Justin Tee <justin.tee@broadcom.com>,
	Naresh Gottumukkala <nareshgottumukkala83@gmail.com>,
	Paul Ely <paul.ely@broadcom.com>,
	Hannes Reinecke <hare@kernel.org>,
	Chaitanya Kulkarni <kch@nvidia.com>,
	James Smart <jsmart833426@gmail.com>,
	Randy Jennings <randyj@purestorage.com>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v6 02/18] nvmet/debugfs: Export controller CIU and CIRN via debugfs
Date: Wed, 21 Oct 2026 11:38:59 -0700	[thread overview]
Message-ID: <20261021183859.GY2931-mkhalfella@purestorage.com> (raw)
In-Reply-To: <a3852ed1-4b6d-44e7-b4de-bc1c6a3b635b@flourine.local>

On Tue 2026-10-20 14:59:04 +0200, Daniel Wagner wrote:
> On Mon, Oct 19, 2026 at 12:01:06PM -0700, Mohamed Khalfella wrote:
> > On Mon 2026-10-19 14:01:13 +0200, Daniel Wagner wrote:
> > > On 2026-09-20 11:28 -0700, Mohamed Khalfella wrote:
> > > > Export ctrl->ciu and ctrl->cirn as debugfs files under controller
> > > > debugfs directory.
> > > 
> > > Could you add the 'why' part to the commit message?
> > 
> > target# grep . /sys/kernel/debug/nvmet/mysubsystem/ctrl1/{ciu,cirn}
> > /sys/kernel/debug/nvmet/mysubsystem/ctrl1/ciu:57
> > /sys/kernel/debug/nvmet/mysubsystem/ctrl1/cirn:42541d24813bb536
> > target#
> > 
> > host# grep . /sys/class/nvme/nvme0/{cntlid,cirn,ciu}
> > /sys/class/nvme/nvme0/cntlid:1
> > /sys/class/nvme/nvme0/cirn:42541d24813bb536
> > /sys/class/nvme/nvme0/ciu:57
> > host# nvme admin-passthru \
> >   --opcode 0x38 \
> >   --cdw10=$(( 0x1 | 0x57<<16 )) \
> >   --cdw12=$(( 0x42541d24813bb536 & 0xffffffff )) \
> >   --cdw13=$(( ( 0x42541d24813bb536 >> 32 ) & 0xffffffff )) \
> >   /dev/nvme1
> > Admin Command Vendor Specific is Success and result: 0x00000000
> > host#
> 
> In the meantime, nvme-cli learned to dump those values as well. I'm not
> sure if it's worth adding these just for this use case.
> 
> 

Good to know that nvme-cli now parses these fields. That is said, the
sysfs and debugfs attributes are useful to have. Say the controller is
stuck in a state that it can not process an identify command.


  reply	other threads:[~2026-10-21 18:39 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-20 18:27 [PATCH v6 00/18] TP8028 Rapid Path Failure Recovery Mohamed Khalfella
2026-09-20 18:27 ` [PATCH v6 01/18] nvmet: Rapid Path Failure Recovery set controller identify fields Mohamed Khalfella
2026-10-15 12:58   ` Daniel Wagner
2026-10-19 18:06     ` Mohamed Khalfella
2026-09-20 18:28 ` [PATCH v6 02/18] nvmet/debugfs: Export controller CIU and CIRN via debugfs Mohamed Khalfella
2026-10-19 12:01   ` Daniel Wagner
2026-10-19 19:01     ` Mohamed Khalfella
2026-10-20 12:59       ` Daniel Wagner
2026-10-21 18:38         ` Mohamed Khalfella [this message]
2026-09-20 18:28 ` [PATCH v6 03/18] nvmet: Implement CCR nvme command Mohamed Khalfella
2026-10-19 16:00   ` Daniel Wagner
2026-10-19 20:21     ` Mohamed Khalfella
2026-09-20 18:28 ` [PATCH v6 04/18] nvmet: Implement CCR logpage Mohamed Khalfella
2026-10-19 16:18   ` Daniel Wagner
2026-09-20 18:28 ` [PATCH v6 05/18] nvmet: Send an AEN on CCR completion Mohamed Khalfella
2026-10-19 16:31   ` Daniel Wagner
2026-09-20 18:28 ` [PATCH v6 06/18] nvme: Rapid Path Failure Recovery read controller identify fields Mohamed Khalfella
2026-10-19 16:56   ` Daniel Wagner
2026-10-19 21:18     ` Mohamed Khalfella
2026-09-20 18:28 ` [PATCH v6 07/18] nvme: Introduce FENCING and FENCED controller states Mohamed Khalfella
2026-10-19 17:01   ` Daniel Wagner
2026-10-19 17:18     ` Daniel Wagner
2026-10-19 21:40       ` Mohamed Khalfella
2026-10-20 13:15         ` Daniel Wagner
2026-10-19 21:26     ` Mohamed Khalfella
2026-10-20 13:10       ` Daniel Wagner
2026-10-21 18:33         ` Mohamed Khalfella
2026-09-20 18:28 ` [PATCH v6 08/18] nvme: Implement cross-controller reset recovery Mohamed Khalfella
2026-10-20  8:55   ` Daniel Wagner
2026-10-20 23:56     ` Mohamed Khalfella
2026-10-21  8:29       ` Daniel Wagner
2026-10-21 18:22         ` Mohamed Khalfella
2026-09-20 18:28 ` [PATCH v6 09/18] nvme: Implement cross-controller reset completion Mohamed Khalfella
2026-10-20  9:18   ` Daniel Wagner
2026-10-21  1:04     ` Mohamed Khalfella
2026-10-21  8:43       ` Daniel Wagner
2026-10-21 18:16         ` Mohamed Khalfella
2026-09-20 18:28 ` [PATCH v6 10/18] nvme-tcp: Use CCR to recover controller that hits an error Mohamed Khalfella
2026-10-20  9:36   ` Daniel Wagner
2026-10-21  1:20     ` Mohamed Khalfella
2026-09-20 18:28 ` [PATCH v6 11/18] nvme-rdma: " Mohamed Khalfella
2026-10-20  9:36   ` Daniel Wagner
2026-10-21  1:25     ` Mohamed Khalfella
2026-09-20 18:28 ` [PATCH v6 12/18] nvme-fc: start error recovery instead of aborting timed out IOs Mohamed Khalfella
2026-10-20  9:55   ` Daniel Wagner
2026-09-20 18:28 ` [PATCH v6 13/18] nvme-fc: perform error recovery directly from ioerr_work Mohamed Khalfella
2026-10-20 10:20   ` Daniel Wagner
2026-09-20 18:28 ` [PATCH v6 14/18] nvme-fc: Use CCR to recover controller that hits an error Mohamed Khalfella
2026-10-20 11:56   ` Daniel Wagner
2026-10-21  1:31     ` Mohamed Khalfella
2026-09-20 18:28 ` [PATCH v6 15/18] nvme-fc: Hold inflight requests while in FENCING state Mohamed Khalfella
2026-10-20 12:21   ` Daniel Wagner
2026-10-21 21:23     ` Mohamed Khalfella
2026-09-20 18:28 ` [PATCH v6 16/18] nvmet: Add support for CQT to nvme target Mohamed Khalfella
2026-10-20 12:40   ` Daniel Wagner
2026-09-20 18:28 ` [PATCH v6 17/18] nvme: Add support for CQT to nvme host Mohamed Khalfella
2026-10-20 12:46   ` Daniel Wagner
2026-09-20 18:28 ` [PATCH v6 18/18] nvme: let controller deletion wait out a fencing window Mohamed Khalfella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261021183859.GY2931-mkhalfella@purestorage.com \
    --to=mkhalfella@purestorage.com \
    --cc=axboe@kernel.dk \
    --cc=dwagner@suse.de \
    --cc=hare@kernel.org \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jsmart833426@gmail.com \
    --cc=justin.tee@broadcom.com \
    --cc=kbusch@kernel.org \
    --cc=kch@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=nareshgottumukkala83@gmail.com \
    --cc=paul.ely@broadcom.com \
    --cc=randyj@purestorage.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.