From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.71 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792622353; b=dLjZmycIiGUjdOm9m3m3o3+pg+H3wPnGs8Jv4lnQwtZvRXnjo4Vm4Wbu8QoFYqDMNqHl NXI7WC27Eqh6s+bsJpTuKfEr2VVVDCCBHh36iaAXa1hfc5hxmoe46Chdcd+04s249+gTM 5zKxwq50u261yWTiam2wDvfp0dy60LkhmHwumgZrq5wMNN6ed4Qh9nQMsU1R9WyTmERxt /wK6srUAeEyyQkBIszuDDvcI/5eXECoTFtjK3u2hXoeyHCE2KT2RT20YQMESmeEbvYI5b zk5y0X6DPuwedANMwjQznQihlT5nC6Rm74h2ymRLcYkqPz2hPmLAZK63lm0u4dIG5uw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792622353; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=YP/JfyOYWmz90m2NwbazrCLMBQ4ptjaQHMjiASdFN+Q=; b=AaRT2kaXF1rAnaxDeGgfBLvbScoyYBgjN38fvxHU+VIKh1pMVnooGc3jhIOOLPjdyALi yemEd+kzUy8d3ihPF0C/3xtzm4/tMm3+u/cDauH9RczVdw4j7EqjYkboZNN6pblc/w4NQ dIOKQw1GXhh4869bRzn6u/ZRhYu4dHUWLzuT/QZT7xLdRus+xn7M2nBFQ4Cbk4RFcj3ue 2kG1FYmZXr+AWDwdo7ebXP4xKDALLCwp6Tfc4RLlmyxsHV0wD8fpOMF9sLUljv8ogN06o 57M5crjZG+2sCInQrJ2PRTpdWRzq9a0JVV9onSLIxsymN0mV1TsBCFJxk+zk+nWUXlg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=pg53IUHL; arc=none smtp.remote-ip=74.125.82.71 Received: from mail-dl1-f71.google.com (mail-dl1-f71.google.com [74.125.82.71]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85A16606A319 for ; Wed, 21 Oct 2026 22:39:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 85A16606A319 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=pg53IUHL Received: by mail-dl1-f71.google.com with SMTP id a92af1059eb24-1663fb7e005so1789715c88.0 for ; Wed, 21 Oct 2026 15:39:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1792622351; x=1793227151; darn=lists.linux.dev; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YP/JfyOYWmz90m2NwbazrCLMBQ4ptjaQHMjiASdFN+Q=; b=pg53IUHLYWFXBStoQruMiif9om7Otwu0EvfncjvfFheINv0C+Su45ZvbyBpaGRstFV lnumx02+I+OFEb0K23trR8IhxLUi6ALEVjhCXHk5EIJtMwpfZJneZWbl/UEC4XPGpwQN /49RxLDNuIR2CKehWzAVMtCSlix7cyGTIMelwQ34oGGw9NjbldxSmBo6yoE9ZtsmvhGh slBsmYab4RhGwdBjljv0XYXR+EMp4/QKqZVUrdX1gNMFxLzswh7QF3bTAesTCcLCvgev VcrxbIwqiSDU7gmFTKS0RbUciCGAnnkqA3tGJspkDHrp3DGcLPb9UoPFy6MbCSMm9u6Z cXCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792622351; x=1793227151; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YP/JfyOYWmz90m2NwbazrCLMBQ4ptjaQHMjiASdFN+Q=; b=a44i7m0Yz3gmOGvCvQu0eCrNJFQPO7AAOMboCvbypAUfmuL9XVal3+wqKnqwWxxaou /y1Xhc4qceCkc4JQlp8437xf3GbdwwpSiKcSuZSxHw+agpLHW/rXH5ZUWo+eMIwXpiC2 I1uwUSNcLT3/knfgkC+bsANspaAToUYNJ89IIBMsqaNoZ0V1R71zHUSrtJ/rJNh4PAya 4vkqxJssjxVdmlPx6KAuuc0YuoNYwzIr9OpewARkTM6hX4IT9i2N9uzhXtqnmpbW09xO D8n8SXS1YHV6+GmgIGc+ZdiSbJNSO0JNTTBkz1jf8oRvU6fAXjw8YMoU3Q//oyofq78H HVwQ== X-Forwarded-Encrypted: i=1; AKwUvBz0BORsk6X0+FTNoeqxdV395YyM4cgXKhGMQxG2Qjr6o6AxM1drUv1e6vzTCuQRD37To5JZ@lists.linux.dev X-Gm-Message-State: AFq9FYIiplGvlEACstMRCVaCgQH8QkoYyZB+SrhYGKG/lWVtBU7YzKbH 8stuxdvyhD1PsIiGfu9uYb3VWroJJvmjf9wNPY1si9RDe+d1KHkmC4aFqBd76Ng4Zwi4aXrr/u2 6YQ32W2LxEA== X-Received: from dled6-n2.prod.google.com ([2002:a05:701b:42c6:20b0:191:8b40:a632]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:701b:21db:b0:153:3c50:ab85 with SMTP id a92af1059eb24-190a456636fmr3329466c88.12.1792622350969; Wed, 21 Oct 2026 15:39:10 -0700 (PDT) Date: Wed, 21 Oct 2026 15:38:48 -0700 In-Reply-To: <20261021171044.155240-1-irogers@google.com> X-Mailing-List: llvm@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261021171044.155240-1-irogers@google.com> X-Mailer: git-send-email 2.56.0.218.g1ec904b173-goog Message-ID: <20261021223905.715051-1-irogers@google.com> Subject: [PATCH v7 00/17] tools/perf: Adopt kernel compiler-context-analysis.h annotations From: Ian Rogers To: irogers@google.com, acme@kernel.org, elver@google.com, namhyung@kernel.org Cc: adrian.hunter@intel.com, james.clark@linaro.org, jolsa@kernel.org, justinstitt@google.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, ljs@kernel.org, llvm@lists.linux.dev, mingo@redhat.com, morbo@google.com, nathan@kernel.org, ndesaulniers@google.com, peterz@infradead.org Content-Type: text/plain; charset="UTF-8" The perf tool previously added Clang thread-safety annotations in tools/perf/util/mutex.h (GUARDED_BY, LOCKABLE, EXCLUSIVE_LOCK_FUNCTION, UNLOCK_FUNCTION, etc.). Since then, the Linux kernel has adopted a unified set of static context analysis macros and attributes in include/linux/compiler-context-analysis.h (context_lock_struct, __guarded_by, __acquires, __releases, __must_hold, etc.). This series makes tools/include/linux/compiler-context-analysis.h functional by synchronizing it and the required compiler_types.h helpers with the kernel headers, converts tools/perf from its custom mutex.h macros to the kernel-style compiler-context-analysis.h annotations, and expands context analysis coverage across comm, dso/dsos, thread/threads, config, intel-tpebs, env, and maps. Along the way, separate preparatory patches fix an unlocked __dsos__add() call and TOCTOU race in __machine__addnew_vdso(), avoid dropping _dso__data_open_lock in dso__list_del() under REFCNT_CHECKING, switch dso__data_open_lock and tpebs_mtx to DEFINE_MUTEX(), add a read-lock fast path to dsos__findnew_id(), fix an unlocked read of tpebs_reader_thread and double-close of tpebs_cmd.out in intel-tpebs, and avoid a potential read-to-write deadlock in maps__load_first() and out-of-bounds access in __maps__remove(). This series was developed and reviewed with assistance from an AI coding agent (Gemini 3.1 Pro) and reviewed with Sashiko. v7: - Add newly created DSOs in machine__process_ksymbol_register() and dso__split_kallsyms() to machine->dsos so assert(dso__dsos(dso)) in dso__list_add() always holds (patch 8). - Add __guarded_by(&config_mutex) to function-local static parser buffers in parse_value() and perf_parse_file() (patch 15). - Remove from maps_by_name before calling map__put(maps_by_address[address_idx]) in __maps__remove() so callers such as maps__remove_maps() that pass maps_by_address[i] as map do not use a freed handle in maps__by_name_index() under REFCNT_CHECKING (patch 16). v6: - Rebase onto perf-tools-next. v5: - Hold machine->dsos.lock in write mode across machine->vdso_info initialization and temporary file creation in machine__findnew_vdso() and __machine__findnew_compat(), and annotate __machine__addnew_vdso() with __must_hold(&machine->dsos.lock) (patches 7, 11). - Reset tpebs_cmd.pid = 0 and return early without setting t->started = true if start_command() fails in evsel__tpebs_start_perf_record() (patch 13). v4: - Place the DSO loaded in addr_filter__resolve_syms() into a dsos collection so dso__dsos(dso) is populated (patch 8). - Join tpebs_reader_thread on error in evsel__tpebs_open(), document why tpebs_cmd.pid is cleared before pthread_join() in tpebs_stop(), and include and in util/intel-tpebs.c (patch 13). - Include in util/maps.c (patch 16). v3: - Rebase onto perf-tools-next (converting the newly added dso__find_binary_type() lock annotations in util/dso.c). - Separate bug fixes, DEFINE_MUTEX() cleanups, and improvements (vdso, dso_data, dso__data_open_lock, dsos__findnew_id, intel-tpebs, tpebs_mtx, maps) from the annotation patches. - Move AI coding assistant attribution to the cover letter and drop per-commit Assisted-by tags per linux-next Documentation/process/coding-assistants.rst. - Add Marco Elver's Reviewed-by to patch 1. - Define __diag_clang_23() and Clang ASM_INPUT_G/ASM_INPUT_RM/ ASM_OUTPUT_RM overrides in tools/include/linux/compiler-gcc.h (patch 2). - Probe for -Wthread-safety-pointer/-Wthread-safety-beta in Makefile.config (patch 5). - Pass write_locked to __dsos__find() (patch 7). - Pass struct dso_data * to close_data_fd() and dso__list_del() to remove the REFCNT_CHECKING dso pointer from struct dso_data and avoid dropping dso__data_open_lock in dso__list_del(), and include in util/dso.c (patch 8). - Re-validate DSO lookup under the write lock in dsos__findnew_id() via __dsos__findnew_id(), and handle NULL dso_id in dso__needs_improve_id(), __dso__improve_id(), and dso_id__cmp() (patch 10). - Reset tpebs_cmd.out = -1 if start_command() fails and include , , , and in util/intel-tpebs.c (patch 13). - Bounds-check the index in __maps__remove() (freeing maps_by_name if out of bounds) (patch 16). v2: - Use -c rather than -E when probing for -fexperimental-late-parse-attributes in Makefile.config to avoid -Werror,-Wunused-command-line-argument. - Acquire machine->dsos.lock in write mode across duplicate checking, dso__set_long_name(), and __dsos__add() in __machine__addnew_vdso(). - Avoid dropping dso__data_open_lock in dso__list_del() under REFCNT_CHECKING. - Pass tpebs_cmd.out directly to __sample_reader() and set tpebs_cmd.out = -1 in evsel__tpebs_open() to avoid a double-close in tpebs_stop(), and clarify the config_set_mutex comment. - Drop maps__lock before calling map__load() in maps__load_first() to avoid a read-to-write self-deadlock when loading kernel maps inserts additional trampoline maps. Ian Rogers (17): compiler-context-analysis: Avoid unused parameter warning in _context_unsafe_alias() tools headers compiler: Synchronize compiler_types.h with the kernel sources tools headers: Synchronize linux/compiler-context-analysis.h with the kernel sources perf mutex: Use kernel style compiler-context-analysis.h annotations perf build: Enable additional Clang thread-safety flags perf comm: Add __guarded_by annotations to struct comm_strs perf vdso: Fix unlocked __dsos__add() and race in __machine__addnew_vdso() perf dso: Pass dso_data to close_data_fd() and dso__list_del() perf dso: Use DEFINE_MUTEX for dso__data_open_lock perf dsos: Use read lock fast path in dsos__findnew_id() perf dso: Expand context analysis annotations perf thread: Expand context analysis annotations to threads and namespaces_lock perf intel-tpebs: Fix race in tpebs_stop() and tpebs_cmd.out fd handling perf intel-tpebs: Use DEFINE_MUTEX for tpebs_mtx perf config, intel-tpebs, env: Add __guarded_by and __must_hold annotations perf maps: Fix lock inversion in maps__load_first() and bounds check in __maps__remove() perf maps: Add context analysis annotations include/linux/compiler-context-analysis.h | 2 +- .../include/linux/compiler-context-analysis.h | 518 ++++++++++++++++-- tools/include/linux/compiler-gcc.h | 72 ++- tools/include/linux/compiler.h | 50 +- tools/include/linux/compiler_types.h | 206 ++++++- tools/perf/Makefile.config | 8 +- tools/perf/builtin-sched.c | 16 +- tools/perf/builtin-top.c | 4 +- tools/perf/check-headers.sh | 1 + tools/perf/tests/dso-data.c | 4 + tools/perf/util/annotate.c | 4 +- tools/perf/util/annotate.h | 8 +- tools/perf/util/auxtrace.c | 16 +- tools/perf/util/bpf-event.h | 5 +- tools/perf/util/comm.c | 10 +- tools/perf/util/config.c | 47 +- tools/perf/util/dso.c | 140 +++-- tools/perf/util/dso.h | 15 +- tools/perf/util/dsos.c | 31 +- tools/perf/util/dsos.h | 12 +- tools/perf/util/env.c | 1 + tools/perf/util/env.h | 19 +- tools/perf/util/intel-tpebs.c | 133 +++-- tools/perf/util/libbfd.c | 4 +- tools/perf/util/machine.c | 14 +- tools/perf/util/maps.c | 157 ++++-- tools/perf/util/mutex.c | 4 +- tools/perf/util/mutex.h | 90 +-- tools/perf/util/rwsem.c | 8 +- tools/perf/util/rwsem.h | 10 +- tools/perf/util/symbol.c | 4 + tools/perf/util/thread.c | 10 +- tools/perf/util/thread.h | 30 +- tools/perf/util/threads.c | 4 + tools/perf/util/threads.h | 6 +- tools/perf/util/vdso.c | 53 +- 36 files changed, 1224 insertions(+), 492 deletions(-) -- 2.56.0.218.g1ec904b173-goog