All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wang Yibo <szwyb123@gmail.com>
To: bpf@vger.kernel.org
Cc: Andrii Nakryiko <andrii@kernel.org>,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>
Subject: [PATCH bpf-next 3/3] selftests/bpf: say how to fix the missing LLVM skip for jited checks
Date: Thu, 22 Oct 2026 08:07:09 +0800	[thread overview]
Message-ID: <20261022080500.100-4-szwyb123@gmail.com> (raw)
In-Reply-To: <20261022080500.100-1-szwyb123@gmail.com>

When test_progs is built without LLVM development libraries, every
subtest that checks jited output is skipped with only "tests are built
w/o LLVM development libs" visible under -v. The message does not say
that installing the libraries and rebuilding is all that is needed, and
the verbose-only message in jit_disasm_helpers.c is missing a trailing
newline, so it runs together with the following output.

Mention the fix in the skip message and add the newline.

Signed-off-by: Wang Yibo <szwyb123@gmail.com>
---
 tools/testing/selftests/bpf/jit_disasm_helpers.c | 2 +-
 tools/testing/selftests/bpf/test_loader.c        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/bpf/jit_disasm_helpers.c b/tools/testing/selftests/bpf/jit_disasm_helpers.c
index 3558fe10e..6162a06b8 100644
--- a/tools/testing/selftests/bpf/jit_disasm_helpers.c
+++ b/tools/testing/selftests/bpf/jit_disasm_helpers.c
@@ -247,7 +247,7 @@ int get_jited_program_text(int fd, char *text, size_t text_sz)
 int get_jited_program_text(int fd, char *text, size_t text_sz)
 {
 	if (env.verbosity >= VERBOSE_VERY)
-		printf("compiled w/o llvm development libraries, can't dis-assembly binary code");
+		printf("compiled w/o llvm development libraries, can't disassemble binary code\n");
 	return -EOPNOTSUPP;
 }
 
diff --git a/tools/testing/selftests/bpf/test_loader.c b/tools/testing/selftests/bpf/test_loader.c
index 824e5912e..a45e6c820 100644
--- a/tools/testing/selftests/bpf/test_loader.c
+++ b/tools/testing/selftests/bpf/test_loader.c
@@ -1506,7 +1506,7 @@ void run_subtest(struct test_loader *tester,
 					     tester->log_buf, tester->log_buf_sz);
 		if (err == -EOPNOTSUPP) {
 			printf("%s:SKIP: jited programs disassembly is not supported,\n", __func__);
-			printf("%s:SKIP: tests are built w/o LLVM development libs\n", __func__);
+			printf("%s:SKIP: rebuild with LLVM development libs installed\n", __func__);
 			test__skip();
 			goto tobj_cleanup;
 		}
-- 
2.51.0

  parent reply	other threads:[~2026-10-22  0:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22  0:06 [PATCH bpf-next 0/3] Add diagnostics for kfunc registration failures and jit subtest skips Wang Yibo
2026-10-22  0:07 ` [PATCH bpf-next 1/3] bpf: report kfunc sets that fail BTF sanity check Wang Yibo
2026-10-22  0:28   ` bot+bpf-ci
2026-10-22  0:07 ` [PATCH bpf-next 2/3] selftests/bpf: name the failing registration in bpf_testmod_init Wang Yibo
2026-10-25  1:24   ` Alexei Starovoitov
2026-10-22  0:07 ` Wang Yibo [this message]
2026-10-22  0:28   ` [PATCH bpf-next 3/3] selftests/bpf: say how to fix the missing LLVM skip for jited checks bot+bpf-ci

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261022080500.100-4-szwyb123@gmail.com \
    --to=szwyb123@gmail.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.