All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Temitope obabi <obabitemitope765@gmail.com>
Cc: Vaibhav Agarwal <vaibhav.sr@gmail.com>,
	Mark Greer <mgreer@animalcreek.com>,
	Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
	greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: audio_manager_module: add newline to sysfs output
Date: Thu, 22 Oct 2026 06:39:27 +0200	[thread overview]
Message-ID: <2026102210-kitty-freckles-0428@gregkh> (raw)
In-Reply-To: <20261021233845.15295-1-obabitemitope765@gmail.com>

On Thu, Oct 22, 2026 at 02:38:42AM +0300, Temitope obabi wrote:
> sysfs attribute output is expected to end with a newline. The show
> functions in this file return values without a trailing newline,
> which checkpatch reports as a warning.
> 
> Add the missing "\n" to the sysfs_emit() format strings of the
> name, vid, pid, intf_id, ip_devices and op_devices attributes.
> 
> Compile-tested only.
> 
> Signed-off-by: Temitope obabi <obabitemitope765@gmail.com>
> ---
>  drivers/staging/greybus/audio_manager_module.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Please read the archives for why this keeps getting rejected.

thanks,

greg k-h

  reply	other threads:[~2026-10-22  4:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21 23:38 [PATCH] staging: greybus: audio_manager_module: add newline to sysfs output Temitope obabi
2026-10-22  4:39 ` Greg Kroah-Hartman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-11-09  7:52 [PATCH] staging: greybus: audio_manager_module: Add " Shivani Patel
2026-11-09  7:56 ` Dan Carpenter
2026-11-09 10:13 ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026102210-kitty-freckles-0428@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=elder@kernel.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mgreer@animalcreek.com \
    --cc=obabitemitope765@gmail.com \
    --cc=vaibhav.sr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.