All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tzu-Ching Yang <shingekinocore@gmail.com>
To: David Laight <david.laight.linux@gmail.com>
Cc: Alexander Lobakin <aleksander.lobakin@intel.com>,
	Eric Biggers <ebiggers@kernel.org>,
	"Jason A. Donenfeld" <Jason@zx2c4.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	"Jose E. Marchesi" <jose.marchesi@oracle.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Simon Horman <horms@kernel.org>,
	Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] unroll: Make unrolled, unrolled_full and unrolled_none function-like
Date: Thu, 22 Oct 2026 19:09:59 +0800	[thread overview]
Message-ID: <20261022110959.1173447-1-shingekinocore@gmail.com> (raw)
In-Reply-To: <20261022100140.101ddf52@pumpkin>

On Thu, Oct 22, 2026 at 10:01:40AM +0100, David Laight wrote:
> Is it possible to make the syntax:
> 	unrolled_for(....)
>
> Or is that made 'all hard and difficult' because he setting is sticky?

The pragma binds only to the loop that follows it, so it can go inside
the macro:

#define unrolled_full_for(...) \
	__pick_unrolled(clang loop unroll(full), GCC unroll 65534) \
	for (__VA_ARGS__)

	unrolled_full_for (int i = 0, j = 7; i < 8; i++, j--)
		s += a[i] * b[j];

GCC 8 to 16 and Clang 17 to 23 unroll this fully, and the same works
with break and continue in the body, nested loops and a loop inside
another macro. The count form has the same shape:

	unrolled_count_for (4, int i = 0; i < n; i++)
		s += a[i];

As a fourth option, the _for forms would replace the four unrolled*
macros: no clash with identifiers, and the loop reads like
for_each_*(); the cost is a new loop spelling at every user. Olek,
Eric, would you prefer this over options 1 to 3 from my earlier reply?

Thanks,
Tzu-Ching

  reply	other threads:[~2026-10-22 11:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16  2:56 [PATCH] unroll: Make unrolled, unrolled_full and unrolled_none function-like Tzu-Ching Yang
2026-10-20 15:54 ` Eric Biggers
2026-10-21 15:02 ` Alexander Lobakin
2026-10-21 23:16   ` Tzu-Ching Yang
2026-10-22  9:01   ` David Laight
2026-10-22 11:09     ` Tzu-Ching Yang [this message]
2026-10-23 13:42       ` Alexander Lobakin
2026-10-23 16:38         ` David Laight
2026-10-26 15:53           ` Alexander Lobakin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261022110959.1173447-1-shingekinocore@gmail.com \
    --to=shingekinocore@gmail.com \
    --cc=Jason@zx2c4.com \
    --cc=akpm@linux-foundation.org \
    --cc=aleksander.lobakin@intel.com \
    --cc=ardb@kernel.org \
    --cc=david.laight.linux@gmail.com \
    --cc=ebiggers@kernel.org \
    --cc=horms@kernel.org \
    --cc=jose.marchesi@oracle.com \
    --cc=kuba@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.fijalkowski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.