From: Kees Cook <kees@kernel.org>
To: Richard Biener <rguenther@suse.de>
Cc: Richard Biener <richard.guenther@gmail.com>,
Jan Hubicka <hubicka@ucw.cz>, Martin Jambor <mjambor@suse.cz>,
gcc-patches@gcc.gnu.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] ipa-icf: Compare access path type sizes without TBAA [PR105438]
Date: Thu, 22 Oct 2026 12:21:24 -0700 [thread overview]
Message-ID: <202610221219.BECB805C6D@keescook> (raw)
In-Reply-To: <o3sqnnq2-0osr-p0oq-0544-o8npp92808n4@fhfr.qr>
On Mon, Oct 19, 2026 at 02:17:47PM +0200, Richard Biener wrote:
> ## 3. Recommended Structural Solutions
>
> Rather than maintaining deferred state across five intermediate IPA passes, PR ipa/105438 should be solved through one of the following architectural approaches:
>
> ### Approach A: Differentiate Incompatible Layouts at ICF Time
> If inlining a merged function will cause invalid memory references, diagnostic warnings, or TBAA violations due to mismatched pointer types or array bounds, ICF's equivalence checks (`func_checker::compatible_types_p` and `func_checker::compare_operand`) should not declare the functions identical when:
> - Parameter types differ in array bounds or struct sizes.
> - Memory access offsets or base types are not strictly identical across types.
Heh. I think this is describing the original patch I sent that started
this thread? :P
-Kees
--
Kees Cook
prev parent reply other threads:[~2026-10-22 19:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 5:05 [PATCH] ipa-icf: Compare access path type sizes without TBAA [PR105438] Kees Cook
2026-10-11 14:50 ` Richard Biener
2026-10-15 5:24 ` Kees Cook
2026-10-15 7:33 ` Richard Biener
2026-10-15 8:58 ` Richard Biener
2026-10-15 12:04 ` Richard Biener
2026-10-15 21:53 ` Kees Cook
2026-10-19 12:17 ` Richard Biener
2026-10-22 19:21 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202610221219.BECB805C6D@keescook \
--to=kees@kernel.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=linux-hardening@vger.kernel.org \
--cc=mjambor@suse.cz \
--cc=rguenther@suse.de \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.