From: Kees Cook <kees@kernel.org>
To: Martin Jambor <mjambor@suse.cz>
Cc: Jan Hubicka <hubicka@ucw.cz>,
gcc-patches@gcc.gnu.org, linux-hardening@vger.kernel.org,
Richard Biener <rguenther@suse.de>
Subject: Re: [PATCH] ipa-icf: Step to the next caller past a thunk in redirect_all_callers
Date: Thu, 22 Oct 2026 12:24:50 -0700 [thread overview]
Message-ID: <202610221224.60CF7CE4B@keescook> (raw)
In-Reply-To: <ri68q3sl7zi.fsf@virgil.suse.cz>
On Tue, Oct 20, 2026 at 05:14:25PM +0200, Martin Jambor wrote:
> Hi,
>
> On Mon, Oct 19 2026, Richard Biener wrote:
> > On Thu, 15 Oct 2026, Kees Cook wrote:
> >
> >> redirect_all_callers walks the callers of N, but steps past a thunk
> >> caller with next_callee, the next call the thunk makes. A thunk makes
> >> only that one call, so the walk ends there, and so the callers after
> >> the thunk in the list would not be redirected. This came with the thunk
> >> check in commit 17d1bf760f8 ("re PR target/65263").
> >
> > Huh. This looks obvious to me, thus OK unless Jan or Martin object
> > soon.
>
> This is fairly obviously OK.
>
> Thanks for catching this!
I don't have commit access, so if someone can do that bit for me, I'd
appreciate it. :)
Thanks!
--
Kees Cook
prev parent reply other threads:[~2026-10-22 19:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 19:45 [PATCH] ipa-icf: Step to the next caller past a thunk in redirect_all_callers Kees Cook
2026-10-19 11:39 ` Richard Biener
2026-10-20 15:14 ` Martin Jambor
2026-10-22 19:24 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202610221224.60CF7CE4B@keescook \
--to=kees@kernel.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=linux-hardening@vger.kernel.org \
--cc=mjambor@suse.cz \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.