From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792677579; b=EiudmVo446zgYLqckquU8yatC+SiH/4mwr0iVitdd4NvycXVukdgr42AqgsYmR4XvhLw WnjjWxsFRimUpup4dzml8V8h39b3KqZ/RYiiWgP1DnFedfCVj04g4evbUaAzYFmTsyXGk v0BU59NKlln56RZPf5r/dX0UDn4w9zB+80f9U3ZNzK0LTjyMWi1SgxwgoKtkJaRNV/I3Y Sju55eQ2xJkIZ0PWPC+57qathUThzUCAdpr3GOJdF3pKQx7U5h5AuW/oGHZvAQwtAV+V3 9/rIZBc2X0V/S/nkSQtI04wamVjMa7yjG7SqPhZBlaT1h/uzQTSMf1O2RMz8dPg6f9A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792677579; h=Received:DKIM-Signature:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=IqlNBP/wAtbwQo7xZ/xZDUvg+Bkn2sMCJfu/91I8hOI=; b=DaBj8sWM/KLXuQp6sfdqdzY+SOP9e5EHMRYkVWIL7Qx2RZOt0REoT3rAoZVPIdNpt4Qv z0FmXvxYinht2xc/WQJfTbWbQke23ExzAjOnwIWHpKfTJFj4x5HHv/ynecv+2RLvHKRNZ NTr+DKqvxiTynEPPpm15S9Dye88JR09oIujrG4vhw8bD2elLUYMg1/nfe82vEZr2hgWmB QoGxDYAfkxPev/2ffvd33ZERCREO4dk7BcUDvP8T6inm59SeIvzfX1/euKpz4NCrNlDkG I3n0PmDZlWuBVlbe1ka61ii/3uL3SQ9OzzzzI9iaL+TrFShEMBaZFVjiqKYT/sTfI4A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=dkZiZWN1; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97B4B606A31E; Thu, 22 Oct 2026 13:59:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=dkZiZWN1 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A05F1F000C1; Thu, 22 Oct 2026 13:59:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792677579; bh=IqlNBP/wAtbwQo7xZ/xZDUvg+Bkn2sMCJfu/91I8hOI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=dkZiZWN174XKTJXmy04vdO2XBnj0gggZ+RNBo3FHzwU8y9s8xOkuqq2W5NSF1zVRs aMEL1XCQtBfa8ZheObeswL8hxM5xkjEPVFS8+juXJQvHNA4+2I9eXqhruWTYaEy0Il PX1cUtufE+/NSScwArr480UhLPZs9XjBqSmVzpAXQ/iN9fYTo+rq6K7GCZaIBCCJWa PfA9GEYmXISsV/NEyhYuA5zQOF8bY0Zo766j3ZtE+XrYHxXJZ+mwzhmheVKo1bK+rl wXkuD8t9ooFA3TMgUqlN5Gn8ZzYQ7tKFsz9WBuRBt6GLu7XWpTgNsueF2Y9DmHZ4uw T277/UaWky2gg== Date: Thu, 22 Oct 2026 08:59:38 -0500 From: Rob Herring To: Sasha Levin Cc: Thierry Reding , Jonathan Hunter , Lyude Paul , Danilo Krummrich , Krzysztof Kozlowski , Conor Dooley , Alexandre Courbot , Mikko Perttunen , Aaron Kling , Diogo Ivo , Svyatoslav Ryhel , Dmitry Osipenko , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/6] dt-bindings: gpu: nvidia,gk20a: Require the fuse clock Message-ID: <20261022135938.GA937780-robh@kernel.org> References: <20261016160700.3831336-1-sashal@kernel.org> <20261016160700.3831336-2-sashal@kernel.org> X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261016160700.3831336-2-sashal@kernel.org> On Fri, Oct 16, 2026 at 12:06:54PM -0400, Sasha Levin wrote: > The GM20B on Tegra210 often fails to initialize unless the fuse clock > is running while the GPU is powered, and the GPUs on the other Tegra > generations are expected to have the same requirement. Tegra194 already > describes the fuse clock for its GV11B. > > Make the fuse clock required for all of them, and list the exact clocks > for each GPU instead of allowing either the reference or the fuse clock > as the third one: GM20B takes the fuse clock after its reference clock, > the others take it after the GPU and power clocks. > > The nouveau driver keeps treating the fuse clock as optional, so device > trees that lack it continue to work as before. > > Assisted-by: LLM > Signed-off-by: Sasha Levin > --- > .../devicetree/bindings/gpu/nvidia,gk20a.yaml | 52 ++++++++++++++----- > 1 file changed, 40 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml b/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml > index 4d856a8b674c5..af0ada6e02557 100644 > --- a/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml > +++ b/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml > @@ -39,18 +39,12 @@ properties: > Regulator for GPU supply voltage > > clocks: > - minItems: 2 > - items: > - - description: GPU clock > - - description: Power clock > - - description: Reference or fuse clock > + minItems: 3 > + maxItems: 4 > > clock-names: > - minItems: 2 > - items: > - - const: gpu > - - const: pwr > - - enum: [ ref, fuse ] > + minItems: 3 > + maxItems: 4 See my reply on v1. We want to keep the names defined at the top-level (to avoid ever variant making up their own names). Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CA52606A31A for ; Thu, 22 Oct 2026 13:59:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=dkZiZWN1 Received: from kara.freedesktop.org (unknown [131.252.210.166]) by gabe.freedesktop.org (Postfix) with ESMTPS id 04870112685; Thu, 22 Oct 2026 13:59:47 +0000 (UTC) Received: from kara.freedesktop.org (localhost [127.0.0.1]) by kara.freedesktop.org (Postfix) with ESMTP id 4AB1D4712E; Thu, 22 Oct 2026 13:40:52 +0000 (UTC) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=lists.freedesktop.org; s=20240201; t=1792676452; b=Hv0jLJF/11iufcPgwNFi6Ml4P5MiytptevFnzcDVZLDnT2m8etnNAK8XYGILvIXFbXxJe aHIR8Pcxu+C6PWVoREMbQjKojTYf5KfFLstfA0h2nOom+68mYSPS6calbDlodMB10lkHuMC 8lpvOIKf2hAT3o01Edl8RLHuhVFkz81oKN+HTgVYQvC3M7CB1rpo9qpMyHbfCyvoPko6Zlw TsClLMkmVbntPtYDq6QyOA9eboLfjCmP/8zKOYdoBtqSABYFNpnagmTZZ83X3hLQkbm3JuV J1ncAMIyvBHMewgfUWZrBxrI800NIi8HUZRNAgeRQ+XfhGaEO4GCjSSBDjWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.freedesktop.org; s=20240201; t=1792676452; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=IqlNBP/wAtbwQo7xZ/xZDUvg+Bkn2sMCJfu/91I8hOI=; b=X6pjGABWWU5ajdTHrskv2V49vfiszWLTJgXgd4SklF3ZEECm33tNGfeYNH6NDya6rIjzQ H5nsotDAFhtTG4aHMbcmMKoV5xoHTYnsIR9Wgj8mushAue0W1PXhFwuObjbB6Kc6F3b3wd5 IpLlq/w02dzA/i6FnHV0+RnejuPnBd4RuQAi5OoFNoQG/teKdOIFfeRjHDlYAQCmrNAgF4J ECvO9/kuqpbRU3g59SkfLLQj7zgPQFEIFUE8YjILb/2RCXE/dXD9Ve/fJyu/+RQmuWXEpaj elAjrzWMLAwdad4D0Zd1NLuyTBEbJ8qoTDM0B0l3qnP7gwp/50Ao4LgvKPDQ== ARC-Authentication-Results: i=1; mail.freedesktop.org; dkim=pass header.d=kernel.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=kernel.org policy.dmarc=quarantine Authentication-Results: mail.freedesktop.org; dkim=pass header.d=kernel.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=kernel.org policy.dmarc=quarantine Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by kara.freedesktop.org (Postfix) with ESMTPS id 4F69D41398 for ; Thu, 22 Oct 2026 13:40:50 +0000 (UTC) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id D29BE112674; Thu, 22 Oct 2026 13:59:39 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 8C47740998; Thu, 22 Oct 2026 13:59:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A05F1F000C1; Thu, 22 Oct 2026 13:59:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792677579; bh=IqlNBP/wAtbwQo7xZ/xZDUvg+Bkn2sMCJfu/91I8hOI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=dkZiZWN174XKTJXmy04vdO2XBnj0gggZ+RNBo3FHzwU8y9s8xOkuqq2W5NSF1zVRs aMEL1XCQtBfa8ZheObeswL8hxM5xkjEPVFS8+juXJQvHNA4+2I9eXqhruWTYaEy0Il PX1cUtufE+/NSScwArr480UhLPZs9XjBqSmVzpAXQ/iN9fYTo+rq6K7GCZaIBCCJWa PfA9GEYmXISsV/NEyhYuA5zQOF8bY0Zo766j3ZtE+XrYHxXJZ+mwzhmheVKo1bK+rl wXkuD8t9ooFA3TMgUqlN5Gn8ZzYQ7tKFsz9WBuRBt6GLu7XWpTgNsueF2Y9DmHZ4uw T277/UaWky2gg== Date: Thu, 22 Oct 2026 08:59:38 -0500 From: Rob Herring To: Sasha Levin Subject: Re: [PATCH v2 1/6] dt-bindings: gpu: nvidia,gk20a: Require the fuse clock Message-ID: <20261022135938.GA937780-robh@kernel.org> References: <20261016160700.3831336-1-sashal@kernel.org> <20261016160700.3831336-2-sashal@kernel.org> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261016160700.3831336-2-sashal@kernel.org> Message-ID-Hash: GKSE6I7RNMXZEVQ4EYYLVTKHNCEUJA3N X-Message-ID-Hash: GKSE6I7RNMXZEVQ4EYYLVTKHNCEUJA3N X-MailFrom: robh@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Thierry Reding , Danilo Krummrich , Krzysztof Kozlowski , Conor Dooley , Alexandre Courbot , Mikko Perttunen , Aaron Kling , Diogo Ivo , Svyatoslav Ryhel , Dmitry Osipenko , Simona Vetter , Maarten Lankhorst , Maxime Ripard , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: Nouveau development list Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Fri, Oct 16, 2026 at 12:06:54PM -0400, Sasha Levin wrote: > The GM20B on Tegra210 often fails to initialize unless the fuse clock > is running while the GPU is powered, and the GPUs on the other Tegra > generations are expected to have the same requirement. Tegra194 already > describes the fuse clock for its GV11B. > > Make the fuse clock required for all of them, and list the exact clocks > for each GPU instead of allowing either the reference or the fuse clock > as the third one: GM20B takes the fuse clock after its reference clock, > the others take it after the GPU and power clocks. > > The nouveau driver keeps treating the fuse clock as optional, so device > trees that lack it continue to work as before. > > Assisted-by: LLM > Signed-off-by: Sasha Levin > --- > .../devicetree/bindings/gpu/nvidia,gk20a.yaml | 52 ++++++++++++++----- > 1 file changed, 40 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml b/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml > index 4d856a8b674c5..af0ada6e02557 100644 > --- a/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml > +++ b/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml > @@ -39,18 +39,12 @@ properties: > Regulator for GPU supply voltage > > clocks: > - minItems: 2 > - items: > - - description: GPU clock > - - description: Power clock > - - description: Reference or fuse clock > + minItems: 3 > + maxItems: 4 > > clock-names: > - minItems: 2 > - items: > - - const: gpu > - - const: pwr > - - enum: [ ref, fuse ] > + minItems: 3 > + maxItems: 4 See my reply on v1. We want to keep the names defined at the top-level (to avoid ever variant making up their own names). Rob