From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84004606A31A for ; Fri, 23 Oct 2026 01:19:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Uc/rGAGZ Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D5B7B10E4D9; Fri, 23 Oct 2026 01:19:19 +0000 (UTC) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8025310E4D9 for ; Fri, 23 Oct 2026 01:19:13 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 0B96440B46; Fri, 23 Oct 2026 01:19:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2AE681F01825; Fri, 23 Oct 2026 01:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792718352; bh=e2zDuQ/aXEEWomBrxUJGRirsqAdsyLdM9FzdN7nPUwk=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=Uc/rGAGZk8vr+E6AoXyh0t0soaQCApn2WDra6R058New8ww35F55ki8kh5lY4Rkng bX1+JIZRtXNt4lTfQGyAsaL5Hqgg9YrS/EoQ+0L+AD7cXTOhfxS+UgoPbf+f99VjqI BiM3JV0LTKvwaypqoVcmebZYTJmWVMCWnNsfKmdXYIO6fw5L5Z1zt6JPdE5rxIcu3o sxc8Pld+qO/L+7B9hJSVOMRMjG6AuwVCAbNu/KUFFCCZbnGDTIj4gR/Dofdbbo9Xg0 NU9Lxbvf69hLYjNPGAf7S18Xymzqe8/ATcPRTh7ftyo94IZTtxdQsyj9LO4L6wGPBy 5ZLuvkzlG6Dgw== Date: Thu, 22 Oct 2026 18:19:11 -0700 From: Jakub Kicinski To: Mina Almasry Cc: Pavel Begunkov , David Wei , Stanislav Fomichev , Taehee Yoo , Paolo Abeni , Kaiyuan Zhang , Bobby Eshleman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jesper Dangaard Brouer , Ilias Apalodimas , Simon Horman , Shuah Khan , Sumit Semwal , Christian =?UTF-8?B?S8O2bmln?= , Dragos Tatulea , Nikolay Aleksandrov , Daniel Borkmann , Tariq Toukan , Kaifeng Wang Subject: Re: [PATCH net v4 3/4] netdevsim: support devmem RX and TX bindings Message-ID: <20261022181911.5d19ff13@kernel.org> In-Reply-To: References: <20261015163915.1166043-1-almasrymina@google.com> <20261015163915.1166043-4-almasrymina@google.com> <20261020121858.3b9107c5@kernel.org> <20261021132304.23e0a4e7@kernel.org> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "dri-devel" X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Thu, 22 Oct 2026 08:41:43 -0700 Mina Almasry wrote: > On Wed, Oct 21, 2026 at 1:23=E2=80=AFPM Jakub Kicinski = wrote: > > On Tue, 20 Oct 2026 23:17:34 -0700 Mina Almasry wrote: =20 > > > But on the other hand the test coverage is nice, and maybe one day if > > > we add enough devmem support in netdevsim we'll be able to fuzz the > > > data path or something. Is there a way to get the best of both worlds? > > > Like put a comment on top of netdevsim that this is test simulator > > > device and any missing functionality and/or bugs in it should be > > > medium criticality max or something? Or is it too much trouble and I > > > should drop the netdevsim support and tests? =20 > > > > I already strip Fixes tags and apply the patches to net-next. > > But it's still a burden. If you're signing up to fix the issues / > > review the slop we can try. =20 >=20 > I'm more than happy to help but I'm not sure what you have > specifically in mind. What I was going to do is put a comment/readme > in drivers/net/netdevsim with a note to sashiko and LLMs, "this is a > netdev simulator, used for testing; do not call out missing or > incomplete functionality as bugs." And then hope that the LLMs and > sashiko pick the directive. If not, I can tell patch submitters to > ignore sashiko code review bug findings in netdevsim. Is that > sufficient, or do you need something else from me? No, the fact that it's a test harness only impacts whether fixes got to net & stable, not whether bugs need to be fixed. I was expecting you to keep an eye on the list and review any fixes that come, basically. > And we can always revert the added devmem supprot in netdev sim if it > becomes an issue. Right.