From: Florian Fainelli <florian.fainelli@broadcom.com>
To: netdev@vger.kernel.org
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
Jonas Gorski <jonas.gorski@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH net 0/6 RESEND] net: dsa: b53: PCS fixes
Date: Thu, 22 Oct 2026 15:56:50 -0700 [thread overview]
Message-ID: <20261022225656.1387306-1-florian.fainelli@broadcom.com> (raw)
This patch series fixes a number of issues found with a LLM and while
testing on a Broadcom Northstar Plus reference board (BCM958625HR) using
a SFP connected to a fiber converter:
- there was no serialization of the registers across multiple lanes
- the SerDes powering down was incorrectly managed and should have used
.pcs_{enable,disable}
- the interfaces advertisement should have been confined to successfully
initialized PCSes
- the negotation and forced link parameters were incorrectly supported
and should have used pcs_link_up and pcs_inband_caps
- link state should have been reported through the PCS
With these patches disconnecting the fiber cables triggers a link down,
as does disconnecting the fiber converter from its cable or powering it
down, ip link up/down also work properly as a result as well.
Florian Fainelli (6):
net: dsa: b53: serialize SerDes register transactions
net: dsa: b53: manage SerDes power through the PCS callbacks
net: dsa: b53: constrain SerDes interfaces to initialized PCSes
net: dsa: b53: configure PCS negotiation and forced link parameters
net: dsa: b53: report link state through the PCS
net: dsa: b53: apply resolved link settings to serial port MACs
drivers/net/dsa/b53/b53_common.c | 69 ++----
drivers/net/dsa/b53/b53_priv.h | 4 -
drivers/net/dsa/b53/b53_serdes.c | 407 +++++++++++++++++++++++--------
drivers/net/dsa/b53/b53_serdes.h | 13 +-
drivers/net/dsa/b53/b53_srab.c | 12 +-
5 files changed, 345 insertions(+), 160 deletions(-)
--
2.53.0
next reply other threads:[~2026-10-22 22:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 22:56 Florian Fainelli [this message]
2026-10-22 22:56 ` [PATCH net 1/6 RESEND] net: dsa: b53: serialize SerDes register transactions Florian Fainelli
2026-10-22 22:56 ` [PATCH net 2/6 RESEND] net: dsa: b53: manage SerDes power through the PCS callbacks Florian Fainelli
2026-10-26 23:47 ` netdev-bot+sashiko
2026-10-27 17:31 ` Florian Fainelli
2026-10-22 22:56 ` [PATCH net 3/6 RESEND] net: dsa: b53: constrain SerDes interfaces to initialized PCSes Florian Fainelli
2026-10-26 23:47 ` netdev-bot+sashiko
2026-10-27 18:05 ` Florian Fainelli
2026-10-22 22:56 ` [PATCH net 4/6 RESEND] net: dsa: b53: configure PCS negotiation and forced link parameters Florian Fainelli
2026-10-26 23:47 ` netdev-bot+sashiko
2026-10-27 18:06 ` Florian Fainelli
2026-10-22 22:56 ` [PATCH net 5/6 RESEND] net: dsa: b53: report link state through the PCS Florian Fainelli
2026-10-26 23:47 ` netdev-bot+sashiko
2026-10-27 18:07 ` Florian Fainelli
2026-10-22 22:56 ` [PATCH net 6/6 RESEND] net: dsa: b53: apply resolved link settings to serial port MACs Florian Fainelli
2026-10-26 23:47 ` netdev-bot+sashiko
2026-10-27 18:08 ` Florian Fainelli
2026-10-27 9:31 ` [PATCH net 0/6 RESEND] net: dsa: b53: PCS fixes Chenguang Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261022225656.1387306-1-florian.fainelli@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=jonas.gorski@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.