From: Jakub Kicinski <kuba@kernel.org>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
davem@davemloft.net, Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Shuah Khan <skhan@linuxfoundation.org>,
Bobby Eshleman <bobbyeshleman@meta.com>,
Stanislav Fomichev <sdf@fomichev.me>,
Breno Leitao <leitao@debian.org>,
thomas.petazzoni@bootlin.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net] selftests: drv-net: devmem: Skip when hugetlbfs isn't supported
Date: Fri, 23 Oct 2026 10:52:58 -0700 [thread overview]
Message-ID: <20261023105258.2a6349f9@kernel.org> (raw)
In-Reply-To: <20261021090852.996899-1-maxime.chevallier@bootlin.com>
On Wed, 21 Oct 2026 11:08:51 +0200 Maxime Chevallier wrote:
> The devmem selftest requires accessing /proc/sys/vm/nr_hugepages,
> which is only available when hugetlbfs is supported. This isn't the
> case on all CPU architectures, for example it isn't supported on ARM
> 32-bits on cores that don't support LPAE.
>
> On these devices, the devmem kselftest doesn't skip gracefully
We don't require graceful skipping. If anything IMO hiding the stack
traces isn't great.
If the check is extraneous and makes us fail some tests which don't
actually require huge pages please make that clear in the commit
message. Otherwise the net benefit of the changes is unclear.
--
pw-bot: cr
next prev parent reply other threads:[~2026-10-23 17:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 9:08 [PATCH net] selftests: drv-net: devmem: Skip when hugetlbfs isn't supported Maxime Chevallier
2026-10-21 9:47 ` Björn Töpel
2026-10-21 14:55 ` Stanislav Fomichev
2026-10-23 17:52 ` Jakub Kicinski [this message]
2026-10-26 9:38 ` Maxime Chevallier
2026-10-27 21:15 ` Jakub Kicinski
2026-10-28 7:17 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261023105258.2a6349f9@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=bobbyeshleman@meta.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=skhan@linuxfoundation.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.