From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Cc: Florian Westphal <fw@strlen.de>
Subject: [PATCH libnftnl 4/7] expr: nftnl_expr_parse: use nftnl_expr_free on error unwind
Date: Fri, 23 Oct 2026 15:58:03 +0200 [thread overview]
Message-ID: <20261023135806.7259-5-fw@strlen.de> (raw)
In-Reply-To: <20261023135806.7259-1-fw@strlen.de>
nftnl_expr_alloc already ran ->init(expr) and ->parse may have allocating sub-objects
in the data[] region, those allocations leak.
Example is dynset.c: parser might have allocated the set_name, then
encountered a pars error when handling the embedded expressions.
Signed-off-by: Florian Westphal <fw@strlen.de>
---
src/expr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/expr.c b/src/expr.c
index 0fec358e7480..6462119e3eb2 100644
--- a/src/expr.c
+++ b/src/expr.c
@@ -284,7 +284,7 @@ struct nftnl_expr *nftnl_expr_parse(struct nlattr *attr)
return expr;
err2:
- xfree(expr);
+ nftnl_expr_free(expr);
err1:
return NULL;
}
--
2.55.0
next prev parent reply other threads:[~2026-10-23 13:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 13:57 [PATCH libnftnl 0/7] misc LLM fixes Florian Westphal
2026-10-23 13:58 ` [PATCH libnftnl 1/7] include: str_array.h: avoid oob read Florian Westphal
2026-10-23 13:58 ` [PATCH libnftnl 2/7] src: chain: fix NFTNL_CHAIN_TYPE data_len Florian Westphal
2026-10-23 13:58 ` [PATCH libnftnl 3/7] src: common: fix fd leak in nftnl_batch_is_supported Florian Westphal
2026-10-23 13:58 ` Florian Westphal [this message]
2026-10-23 13:58 ` [PATCH libnftnl 5/7] src: flowtable: allow to unset NFTNL_FLOWTABLE_SIZE Florian Westphal
2026-10-23 13:58 ` [PATCH libnftnl 6/7] src: utils: keep old name if strndup fails Florian Westphal
2026-10-23 13:58 ` [PATCH libnftnl 7/7] src: add and use nftnl_mem_blob for user_data Florian Westphal
2026-10-26 14:46 ` [PATCH libnftnl 0/7] misc LLM fixes Fernando Fernandez Mancera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261023135806.7259-5-fw@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.