Re: [PATCH] nfc: nci: drain rx_wq before cmd_wq on unregister

[Simon Horman <horms@kernel.org>]

On Thu, Oct 08, 2026 at 01:31:56PM +0000, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 2 (1) · Medium: 0 · Low: 0
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
> 
> - [High] The new teardown order in nci_unregister_device() does not cover
>   a deferred producer of tx_work: the NCI-HCI msg_rx_work, which runs on…
> - [High] nci_recv_frame() (net/nfc/nci/core.c:1360-1368) tests
>   NCI_UP/NCI_INIT without a lock, then calls skb_queue_tail(&ndev->rx_q)…

I believe above issues are also pre-existing.

> 
> Pre-existing issues:
> - [High] This problem was not introduced by this patch, but
>   nxp_nci_i2c_remove() calls nxp_nci_remove() before…

There is always more to be done.
But this patch looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>